// Copyright 2014 The Chromium Authors // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. #include "third_party/blink/renderer/platform/graphics/paint/paint_controller_test.h" #include "base/dcheck_is_on.h" #include "build/build_config.h" #include "components/viz/common/surfaces/tracked_element_rects.h" #include "testing/gmock/include/gmock/gmock.h" #include "third_party/blink/renderer/platform/graphics/graphics_context.h" #include "third_party/blink/renderer/platform/graphics/paint/display_item_cache_skipper.h" #include "third_party/blink/renderer/platform/graphics/paint/drawing_display_item.h" #include "third_party/blink/renderer/platform/graphics/paint/drawing_recorder.h" #include "third_party/blink/renderer/platform/graphics/paint/scoped_display_item_fragment.h" #include "third_party/blink/renderer/platform/graphics/paint/scoped_paint_chunk_properties.h" #include "third_party/blink/renderer/platform/graphics/paint/subsequence_recorder.h" #include "third_party/blink/renderer/platform/graphics/paint/tracked_element_data.h" #include "third_party/blink/renderer/platform/runtime_enabled_features.h" #include "third_party/blink/renderer/platform/testing/paint_test_configurations.h" #include "third_party/skia/include/core/SkPath.h" #include "third_party/skia/include/core/SkPathBuilder.h" using testing::ElementsAre; namespace blink { PaintControllerTestBase::DrawResult PaintControllerTestBase::Draw( GraphicsContext& context, const DisplayItemClient& client, DisplayItem::Type type, base::FunctionRef draw_function) { if (DrawingRecorder::UseCachedDrawingIfPossible(context, client, type)) { return kCached; } auto& paint_controller = context.GetPaintController(); auto* matching_cached_item = paint_controller.MatchingCachedItemToBeRepainted(); PaintRecord old_record; if (matching_cached_item) { EXPECT_EQ( matching_cached_item->GetId(), DisplayItem::Id(client.Id(), type, paint_controller.CurrentFragment())); old_record = To(matching_cached_item)->GetPaintRecord(); } bool would_be_cached = paint_controller.IsCheckingUnderInvalidationForTesting(); draw_function(); if (would_be_cached) { DCHECK(!matching_cached_item); return kCached; } if (matching_cached_item) { // We should reused the cached paint record and paint into it. PaintRecord new_record = To(UNSAFE_TODO(GetNewPaintArtifact(paint_controller) .GetDisplayItemList() .back())) .GetPaintRecord(); EXPECT_NE(&old_record.GetFirstOp(), &new_record.GetFirstOp()); EXPECT_EQ(old_record.bytes_used(), new_record.bytes_used()); return kRepaintedCachedItem; } return kPaintedNew; } // Tests using this class will be tested with under-invalidation-checking // enabled and disabled. class PaintControllerTest : public PaintTestConfigurations, public PaintControllerTestBase { }; #define EXPECT_DEFAULT_ROOT_CHUNK(size) \ EXPECT_THAT(GetPersistentData().GetPaintChunks(), \ ElementsAre(IsPaintChunk(0, size, DefaultRootChunkId(), \ DefaultPaintChunkProperties()))) INSTANTIATE_TEST_SUITE_P(All, PaintControllerTest, testing::Values(0, kUnderInvalidationChecking)); TEST_P(PaintControllerTest, NestedRecorders) { FakeDisplayItemClient& client = *MakeGarbageCollected("client"); { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); InitRootChunk(paint_controller); EXPECT_EQ(kPaintedNew, DrawRect(context, client, kBackgroundType, gfx::Rect(100, 100, 200, 200))); } EXPECT_THAT(GetPersistentData().GetDisplayItemList(), ElementsAre(IsSameId(client.Id(), kBackgroundType))); EXPECT_DEFAULT_ROOT_CHUNK(1); } TEST_P(PaintControllerTest, UpdateBasic) { FakeDisplayItemClient& first = *MakeGarbageCollected("first"); FakeDisplayItemClient& second = *MakeGarbageCollected("second"); { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); InitRootChunk(paint_controller); EXPECT_EQ(kPaintedNew, DrawRect(context, first, kBackgroundType, gfx::Rect(100, 100, 300, 300))); EXPECT_EQ(kPaintedNew, DrawRect(context, second, kBackgroundType, gfx::Rect(100, 100, 200, 200))); EXPECT_EQ(kPaintedNew, DrawRect(context, first, kForegroundType, gfx::Rect(100, 100, 300, 300))); EXPECT_EQ(0u, NumCachedNewItems(paint_controller)); EXPECT_EQ(0u, NumCachedNewSubsequences(paint_controller)); } EXPECT_THAT(GetPersistentData().GetDisplayItemList(), ElementsAre(IsSameId(first.Id(), kBackgroundType), IsSameId(second.Id(), kBackgroundType), IsSameId(first.Id(), kForegroundType))); EXPECT_DEFAULT_ROOT_CHUNK(3); { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); InitRootChunk(paint_controller); EXPECT_EQ(kCached, DrawRect(context, first, kBackgroundType, gfx::Rect(100, 100, 300, 300))); EXPECT_EQ(kCached, DrawRect(context, first, kForegroundType, gfx::Rect(100, 100, 300, 300))); EXPECT_EQ(2u, NumCachedNewItems(paint_controller)); EXPECT_EQ(0u, NumCachedNewSubsequences(paint_controller)); #if DCHECK_IS_ON() EXPECT_EQ(1u, NumIndexedItems(paint_controller)); EXPECT_EQ(2u, NumSequentialMatches(paint_controller)); EXPECT_EQ(0u, NumOutOfOrderMatches(paint_controller)); #endif } EXPECT_THAT(GetPersistentData().GetDisplayItemList(), ElementsAre(IsSameId(first.Id(), kBackgroundType), IsSameId(first.Id(), kForegroundType))); EXPECT_DEFAULT_ROOT_CHUNK(2); } TEST_P(PaintControllerTest, UpdateSwapOrder) { FakeDisplayItemClient& first = *MakeGarbageCollected("first"); FakeDisplayItemClient& second = *MakeGarbageCollected("second"); FakeDisplayItemClient& unaffected = *MakeGarbageCollected("unaffected"); { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); InitRootChunk(paint_controller); EXPECT_EQ(kPaintedNew, DrawRect(context, first, kBackgroundType, gfx::Rect(100, 100, 100, 100))); EXPECT_EQ(kPaintedNew, DrawRect(context, first, kForegroundType, gfx::Rect(100, 100, 100, 100))); EXPECT_EQ(kPaintedNew, DrawRect(context, second, kBackgroundType, gfx::Rect(100, 100, 50, 200))); EXPECT_EQ(kPaintedNew, DrawRect(context, second, kForegroundType, gfx::Rect(100, 100, 50, 200))); EXPECT_EQ(kPaintedNew, DrawRect(context, unaffected, kBackgroundType, gfx::Rect(300, 300, 10, 10))); EXPECT_EQ(kPaintedNew, DrawRect(context, unaffected, kForegroundType, gfx::Rect(300, 300, 10, 10))); } EXPECT_THAT(GetPersistentData().GetDisplayItemList(), ElementsAre(IsSameId(first.Id(), kBackgroundType), IsSameId(first.Id(), kForegroundType), IsSameId(second.Id(), kBackgroundType), IsSameId(second.Id(), kForegroundType), IsSameId(unaffected.Id(), kBackgroundType), IsSameId(unaffected.Id(), kForegroundType))); { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); InitRootChunk(paint_controller); EXPECT_EQ(kCached, DrawRect(context, second, kBackgroundType, gfx::Rect(100, 100, 50, 200))); EXPECT_EQ(kCached, DrawRect(context, second, kForegroundType, gfx::Rect(100, 100, 50, 200))); EXPECT_EQ(kCached, DrawRect(context, first, kBackgroundType, gfx::Rect(100, 100, 100, 100))); EXPECT_EQ(kCached, DrawRect(context, first, kForegroundType, gfx::Rect(100, 100, 100, 100))); EXPECT_EQ(kCached, DrawRect(context, unaffected, kBackgroundType, gfx::Rect(300, 300, 10, 10))); EXPECT_EQ(kCached, DrawRect(context, unaffected, kForegroundType, gfx::Rect(300, 300, 10, 10))); EXPECT_EQ(6u, NumCachedNewItems(paint_controller)); EXPECT_EQ(0u, NumCachedNewSubsequences(paint_controller)); #if DCHECK_IS_ON() EXPECT_EQ(2u, NumIndexedItems(paint_controller)); // first EXPECT_EQ(5u, NumSequentialMatches( paint_controller)); // second, first foreground, unaffected EXPECT_EQ(1u, NumOutOfOrderMatches(paint_controller)); // first #endif } EXPECT_THAT(GetPersistentData().GetDisplayItemList(), ElementsAre(IsSameId(second.Id(), kBackgroundType), IsSameId(second.Id(), kForegroundType), IsSameId(first.Id(), kBackgroundType), IsSameId(first.Id(), kForegroundType), IsSameId(unaffected.Id(), kBackgroundType), IsSameId(unaffected.Id(), kForegroundType))); EXPECT_DEFAULT_ROOT_CHUNK(6); } TEST_P(PaintControllerTest, UpdateSwapOrderWithInvalidation) { FakeDisplayItemClient& first = *MakeGarbageCollected("first"); FakeDisplayItemClient& second = *MakeGarbageCollected("second"); FakeDisplayItemClient& unaffected = *MakeGarbageCollected("unaffected"); { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); InitRootChunk(paint_controller); EXPECT_EQ(kPaintedNew, DrawRect(context, first, kBackgroundType, gfx::Rect(100, 100, 100, 100))); EXPECT_EQ(kPaintedNew, DrawRect(context, first, kForegroundType, gfx::Rect(100, 100, 100, 100))); EXPECT_EQ(kPaintedNew, DrawRect(context, second, kBackgroundType, gfx::Rect(100, 100, 50, 200))); EXPECT_EQ(kPaintedNew, DrawRect(context, second, kForegroundType, gfx::Rect(100, 100, 50, 200))); EXPECT_EQ(kPaintedNew, DrawRect(context, unaffected, kBackgroundType, gfx::Rect(300, 300, 10, 10))); EXPECT_EQ(kPaintedNew, DrawRect(context, unaffected, kForegroundType, gfx::Rect(300, 300, 10, 10))); } EXPECT_THAT(GetPersistentData().GetDisplayItemList(), ElementsAre(IsSameId(first.Id(), kBackgroundType), IsSameId(first.Id(), kForegroundType), IsSameId(second.Id(), kBackgroundType), IsSameId(second.Id(), kForegroundType), IsSameId(unaffected.Id(), kBackgroundType), IsSameId(unaffected.Id(), kForegroundType))); { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); InitRootChunk(paint_controller); first.Invalidate(); EXPECT_EQ(kCached, DrawRect(context, second, kBackgroundType, gfx::Rect(100, 100, 50, 200))); EXPECT_EQ(kCached, DrawRect(context, second, kForegroundType, gfx::Rect(100, 100, 50, 200))); EXPECT_EQ(kRepaintedCachedItem, DrawRect(context, first, kBackgroundType, gfx::Rect(100, 100, 100, 100))); EXPECT_EQ(kRepaintedCachedItem, DrawRect(context, first, kForegroundType, gfx::Rect(100, 100, 100, 100))); EXPECT_EQ(kCached, DrawRect(context, unaffected, kBackgroundType, gfx::Rect(300, 300, 10, 10))); EXPECT_EQ(kCached, DrawRect(context, unaffected, kForegroundType, gfx::Rect(300, 300, 10, 10))); EXPECT_EQ(4u, NumCachedNewItems(paint_controller)); EXPECT_EQ(0u, NumCachedNewSubsequences(paint_controller)); #if DCHECK_IS_ON() EXPECT_EQ(2u, NumIndexedItems(paint_controller)); EXPECT_EQ(5u, NumSequentialMatches(paint_controller)); EXPECT_EQ(1u, NumOutOfOrderMatches(paint_controller)); #endif } EXPECT_THAT(GetPersistentData().GetDisplayItemList(), ElementsAre(IsSameId(second.Id(), kBackgroundType), IsSameId(second.Id(), kForegroundType), IsSameId(first.Id(), kBackgroundType), IsSameId(first.Id(), kForegroundType), IsSameId(unaffected.Id(), kBackgroundType), IsSameId(unaffected.Id(), kForegroundType))); EXPECT_DEFAULT_ROOT_CHUNK(6); } TEST_P(PaintControllerTest, UpdateNewItemInMiddle) { FakeDisplayItemClient& first = *MakeGarbageCollected("first"); FakeDisplayItemClient& second = *MakeGarbageCollected("second"); FakeDisplayItemClient& third = *MakeGarbageCollected("third"); { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); InitRootChunk(paint_controller); EXPECT_EQ(kPaintedNew, DrawRect(context, first, kBackgroundType, gfx::Rect(100, 100, 100, 100))); EXPECT_EQ(kPaintedNew, DrawRect(context, second, kBackgroundType, gfx::Rect(100, 100, 50, 200))); } EXPECT_THAT(GetPersistentData().GetDisplayItemList(), ElementsAre(IsSameId(first.Id(), kBackgroundType), IsSameId(second.Id(), kBackgroundType))); { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); InitRootChunk(paint_controller); EXPECT_EQ(kCached, DrawRect(context, first, kBackgroundType, gfx::Rect(100, 100, 100, 100))); EXPECT_EQ(kPaintedNew, DrawRect(context, third, kBackgroundType, gfx::Rect(125, 100, 200, 50))); EXPECT_EQ(kCached, DrawRect(context, second, kBackgroundType, gfx::Rect(100, 100, 50, 200))); EXPECT_EQ(2u, NumCachedNewItems(paint_controller)); EXPECT_EQ(0u, NumCachedNewSubsequences(paint_controller)); #if DCHECK_IS_ON() EXPECT_EQ(0u, NumIndexedItems(paint_controller)); EXPECT_EQ(2u, NumSequentialMatches(paint_controller)); // first, second EXPECT_EQ(0u, NumOutOfOrderMatches(paint_controller)); #endif } EXPECT_THAT(GetPersistentData().GetDisplayItemList(), ElementsAre(IsSameId(first.Id(), kBackgroundType), IsSameId(third.Id(), kBackgroundType), IsSameId(second.Id(), kBackgroundType))); EXPECT_DEFAULT_ROOT_CHUNK(3); } TEST_P(PaintControllerTest, UpdateInvalidationWithPhases) { FakeDisplayItemClient& first = *MakeGarbageCollected("first"); FakeDisplayItemClient& second = *MakeGarbageCollected("second"); FakeDisplayItemClient& third = *MakeGarbageCollected("third"); { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); InitRootChunk(paint_controller); DrawRect(context, first, kBackgroundType, gfx::Rect(100, 100, 100, 100)); DrawRect(context, second, kBackgroundType, gfx::Rect(100, 100, 50, 200)); DrawRect(context, third, kBackgroundType, gfx::Rect(300, 100, 50, 50)); DrawRect(context, first, kForegroundType, gfx::Rect(100, 100, 100, 100)); DrawRect(context, second, kForegroundType, gfx::Rect(100, 100, 50, 200)); DrawRect(context, third, kForegroundType, gfx::Rect(300, 100, 50, 50)); } EXPECT_THAT(GetPersistentData().GetDisplayItemList(), ElementsAre(IsSameId(first.Id(), kBackgroundType), IsSameId(second.Id(), kBackgroundType), IsSameId(third.Id(), kBackgroundType), IsSameId(first.Id(), kForegroundType), IsSameId(second.Id(), kForegroundType), IsSameId(third.Id(), kForegroundType))); { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); InitRootChunk(paint_controller); second.Invalidate(); EXPECT_EQ(kCached, DrawRect(context, first, kBackgroundType, gfx::Rect(100, 100, 100, 100))); EXPECT_EQ(kRepaintedCachedItem, DrawRect(context, second, kBackgroundType, gfx::Rect(100, 100, 50, 200))); EXPECT_EQ(kCached, DrawRect(context, third, kBackgroundType, gfx::Rect(300, 100, 50, 50))); EXPECT_EQ(kCached, DrawRect(context, first, kForegroundType, gfx::Rect(100, 100, 100, 100))); EXPECT_EQ(kRepaintedCachedItem, DrawRect(context, second, kForegroundType, gfx::Rect(100, 100, 50, 200))); EXPECT_EQ(kCached, DrawRect(context, third, kForegroundType, gfx::Rect(300, 100, 50, 50))); EXPECT_EQ(4u, NumCachedNewItems(paint_controller)); EXPECT_EQ(0u, NumCachedNewSubsequences(paint_controller)); #if DCHECK_IS_ON() EXPECT_EQ(0u, NumIndexedItems(paint_controller)); EXPECT_EQ(6u, NumSequentialMatches(paint_controller)); EXPECT_EQ(0u, NumOutOfOrderMatches(paint_controller)); #endif } EXPECT_THAT(GetPersistentData().GetDisplayItemList(), ElementsAre(IsSameId(first.Id(), kBackgroundType), IsSameId(second.Id(), kBackgroundType), IsSameId(third.Id(), kBackgroundType), IsSameId(first.Id(), kForegroundType), IsSameId(second.Id(), kForegroundType), IsSameId(third.Id(), kForegroundType))); EXPECT_DEFAULT_ROOT_CHUNK(6); } TEST_P(PaintControllerTest, UpdateAddFirstOverlap) { FakeDisplayItemClient& first = *MakeGarbageCollected("first"); FakeDisplayItemClient& second = *MakeGarbageCollected("second"); { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); InitRootChunk(paint_controller); DrawRect(context, second, kBackgroundType, gfx::Rect(200, 200, 50, 50)); DrawRect(context, second, kForegroundType, gfx::Rect(200, 200, 50, 50)); } EXPECT_THAT(GetPersistentData().GetDisplayItemList(), ElementsAre(IsSameId(second.Id(), kBackgroundType), IsSameId(second.Id(), kForegroundType))); { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); InitRootChunk(paint_controller); first.Invalidate(); second.Invalidate(); EXPECT_EQ(kPaintedNew, DrawRect(context, first, kBackgroundType, gfx::Rect(100, 100, 150, 150))); EXPECT_EQ(kPaintedNew, DrawRect(context, first, kForegroundType, gfx::Rect(100, 100, 150, 150))); EXPECT_EQ(kRepaintedCachedItem, DrawRect(context, second, kBackgroundType, gfx::Rect(150, 250, 100, 100))); EXPECT_EQ(kRepaintedCachedItem, DrawRect(context, second, kForegroundType, gfx::Rect(150, 250, 100, 100))); EXPECT_EQ(0u, NumCachedNewItems(paint_controller)); EXPECT_EQ(0u, NumCachedNewSubsequences(paint_controller)); } EXPECT_THAT(GetPersistentData().GetDisplayItemList(), ElementsAre(IsSameId(first.Id(), kBackgroundType), IsSameId(first.Id(), kForegroundType), IsSameId(second.Id(), kBackgroundType), IsSameId(second.Id(), kForegroundType))); EXPECT_DEFAULT_ROOT_CHUNK(4); { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); InitRootChunk(paint_controller); EXPECT_EQ(kCached, DrawRect(context, second, kBackgroundType, gfx::Rect(150, 250, 100, 100))); EXPECT_EQ(kCached, DrawRect(context, second, kForegroundType, gfx::Rect(150, 250, 100, 100))); EXPECT_EQ(2u, NumCachedNewItems(paint_controller)); EXPECT_EQ(0u, NumCachedNewSubsequences(paint_controller)); #if DCHECK_IS_ON() EXPECT_EQ(2u, NumIndexedItems(paint_controller)); EXPECT_EQ(2u, NumSequentialMatches(paint_controller)); EXPECT_EQ(0u, NumOutOfOrderMatches(paint_controller)); #endif } EXPECT_THAT(GetPersistentData().GetDisplayItemList(), ElementsAre(IsSameId(second.Id(), kBackgroundType), IsSameId(second.Id(), kForegroundType))); EXPECT_DEFAULT_ROOT_CHUNK(2); } TEST_P(PaintControllerTest, UpdateAddLastOverlap) { FakeDisplayItemClient& first = *MakeGarbageCollected("first"); FakeDisplayItemClient& second = *MakeGarbageCollected("second"); { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); InitRootChunk(paint_controller); DrawRect(context, first, kBackgroundType, gfx::Rect(100, 100, 150, 150)); DrawRect(context, first, kForegroundType, gfx::Rect(100, 100, 150, 150)); } EXPECT_THAT(GetPersistentData().GetDisplayItemList(), ElementsAre(IsSameId(first.Id(), kBackgroundType), IsSameId(first.Id(), kForegroundType))); { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); InitRootChunk(paint_controller); first.Invalidate(); second.Invalidate(); EXPECT_EQ(kRepaintedCachedItem, DrawRect(context, first, kBackgroundType, gfx::Rect(150, 150, 100, 100))); EXPECT_EQ(kRepaintedCachedItem, DrawRect(context, first, kForegroundType, gfx::Rect(150, 150, 100, 100))); EXPECT_EQ(kPaintedNew, DrawRect(context, second, kBackgroundType, gfx::Rect(200, 200, 50, 50))); EXPECT_EQ(kPaintedNew, DrawRect(context, second, kForegroundType, gfx::Rect(200, 200, 50, 50))); EXPECT_EQ(0u, NumCachedNewItems(paint_controller)); EXPECT_EQ(0u, NumCachedNewSubsequences(paint_controller)); } EXPECT_THAT(GetPersistentData().GetDisplayItemList(), ElementsAre(IsSameId(first.Id(), kBackgroundType), IsSameId(first.Id(), kForegroundType), IsSameId(second.Id(), kBackgroundType), IsSameId(second.Id(), kForegroundType))); EXPECT_DEFAULT_ROOT_CHUNK(4); { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); InitRootChunk(paint_controller); first.Invalidate(); second.Invalidate(); EXPECT_EQ(kRepaintedCachedItem, DrawRect(context, first, kBackgroundType, gfx::Rect(100, 100, 150, 150))); EXPECT_EQ(kRepaintedCachedItem, DrawRect(context, first, kForegroundType, gfx::Rect(100, 100, 150, 150))); EXPECT_EQ(0u, NumCachedNewItems(paint_controller)); EXPECT_EQ(0u, NumCachedNewSubsequences(paint_controller)); } EXPECT_THAT(GetPersistentData().GetDisplayItemList(), ElementsAre(IsSameId(first.Id(), kBackgroundType), IsSameId(first.Id(), kForegroundType))); EXPECT_DEFAULT_ROOT_CHUNK(2); } TEST_P(PaintControllerTest, CachedDisplayItems) { FakeDisplayItemClient& first = *MakeGarbageCollected("first"); FakeDisplayItemClient& second = *MakeGarbageCollected("second"); { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); InitRootChunk(paint_controller); DrawRect(context, first, kBackgroundType, gfx::Rect(100, 100, 150, 150)); DrawRect(context, second, kBackgroundType, gfx::Rect(100, 100, 150, 150)); } EXPECT_THAT(GetPersistentData().GetDisplayItemList(), ElementsAre(IsSameId(first.Id(), kBackgroundType), IsSameId(second.Id(), kBackgroundType))); EXPECT_TRUE(ClientCacheIsValid(first)); EXPECT_TRUE(ClientCacheIsValid(second)); first.Invalidate(); EXPECT_FALSE(ClientCacheIsValid(first)); EXPECT_TRUE(ClientCacheIsValid(second)); { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); InitRootChunk(paint_controller); EXPECT_EQ(kRepaintedCachedItem, DrawRect(context, first, kBackgroundType, gfx::Rect(100, 100, 150, 150))); EXPECT_EQ(kCached, DrawRect(context, second, kBackgroundType, gfx::Rect(100, 100, 150, 150))); } EXPECT_THAT(GetPersistentData().GetDisplayItemList(), ElementsAre(IsSameId(first.Id(), kBackgroundType), IsSameId(second.Id(), kBackgroundType))); EXPECT_TRUE(ClientCacheIsValid(first)); EXPECT_TRUE(ClientCacheIsValid(second)); InvalidateAll(); EXPECT_FALSE(ClientCacheIsValid(first)); EXPECT_FALSE(ClientCacheIsValid(second)); } TEST_P(PaintControllerTest, UpdateSwapOrderWithChildren) { FakeDisplayItemClient& container1 = *MakeGarbageCollected("container1"); FakeDisplayItemClient& content1 = *MakeGarbageCollected("content1"); FakeDisplayItemClient& container2 = *MakeGarbageCollected("container2"); FakeDisplayItemClient& content2 = *MakeGarbageCollected("content2"); { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); InitRootChunk(paint_controller); DrawRect(context, container1, kBackgroundType, gfx::Rect(100, 100, 100, 100)); DrawRect(context, content1, kBackgroundType, gfx::Rect(100, 100, 50, 200)); DrawRect(context, content1, kForegroundType, gfx::Rect(100, 100, 50, 200)); DrawRect(context, container1, kForegroundType, gfx::Rect(100, 100, 100, 100)); DrawRect(context, container2, kBackgroundType, gfx::Rect(100, 200, 100, 100)); DrawRect(context, content2, kBackgroundType, gfx::Rect(100, 200, 50, 200)); DrawRect(context, content2, kForegroundType, gfx::Rect(100, 200, 50, 200)); DrawRect(context, container2, kForegroundType, gfx::Rect(100, 200, 100, 100)); } EXPECT_THAT(GetPersistentData().GetDisplayItemList(), ElementsAre(IsSameId(container1.Id(), kBackgroundType), IsSameId(content1.Id(), kBackgroundType), IsSameId(content1.Id(), kForegroundType), IsSameId(container1.Id(), kForegroundType), IsSameId(container2.Id(), kBackgroundType), IsSameId(content2.Id(), kBackgroundType), IsSameId(content2.Id(), kForegroundType), IsSameId(container2.Id(), kForegroundType))); { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); InitRootChunk(paint_controller); // Simulate the situation when |container1| gets a z-index that is greater // than that of |container2|. EXPECT_EQ(kCached, DrawRect(context, container2, kBackgroundType, gfx::Rect(100, 200, 100, 100))); EXPECT_EQ(kCached, DrawRect(context, content2, kBackgroundType, gfx::Rect(100, 200, 50, 200))); EXPECT_EQ(kCached, DrawRect(context, content2, kForegroundType, gfx::Rect(100, 200, 50, 200))); EXPECT_EQ(kCached, DrawRect(context, container2, kForegroundType, gfx::Rect(100, 200, 100, 100))); EXPECT_EQ(kCached, DrawRect(context, container1, kBackgroundType, gfx::Rect(100, 100, 100, 100))); EXPECT_EQ(kCached, DrawRect(context, content1, kBackgroundType, gfx::Rect(100, 100, 50, 200))); EXPECT_EQ(kCached, DrawRect(context, content1, kForegroundType, gfx::Rect(100, 100, 50, 200))); EXPECT_EQ(kCached, DrawRect(context, container1, kForegroundType, gfx::Rect(100, 100, 100, 100))); } EXPECT_THAT(GetPersistentData().GetDisplayItemList(), ElementsAre(IsSameId(container2.Id(), kBackgroundType), IsSameId(content2.Id(), kBackgroundType), IsSameId(content2.Id(), kForegroundType), IsSameId(container2.Id(), kForegroundType), IsSameId(container1.Id(), kBackgroundType), IsSameId(content1.Id(), kBackgroundType), IsSameId(content1.Id(), kForegroundType), IsSameId(container1.Id(), kForegroundType))); EXPECT_DEFAULT_ROOT_CHUNK(8); } TEST_P(PaintControllerTest, UpdateSwapOrderWithChildrenAndInvalidation) { FakeDisplayItemClient& content1 = *MakeGarbageCollected("content1"); FakeDisplayItemClient& container1 = *MakeGarbageCollected("container1"); FakeDisplayItemClient& content2 = *MakeGarbageCollected("content2"); FakeDisplayItemClient& container2 = *MakeGarbageCollected("container2"); { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); InitRootChunk(paint_controller); DrawRect(context, container1, kBackgroundType, gfx::Rect(100, 100, 100, 100)); DrawRect(context, content1, kBackgroundType, gfx::Rect(100, 100, 50, 200)); DrawRect(context, content1, kForegroundType, gfx::Rect(100, 100, 50, 200)); DrawRect(context, container1, kForegroundType, gfx::Rect(100, 100, 100, 100)); DrawRect(context, container2, kBackgroundType, gfx::Rect(100, 200, 100, 100)); DrawRect(context, content2, kBackgroundType, gfx::Rect(100, 200, 50, 200)); DrawRect(context, content2, kForegroundType, gfx::Rect(100, 200, 50, 200)); DrawRect(context, container2, kForegroundType, gfx::Rect(100, 200, 100, 100)); } EXPECT_THAT(GetPersistentData().GetDisplayItemList(), ElementsAre(IsSameId(container1.Id(), kBackgroundType), IsSameId(content1.Id(), kBackgroundType), IsSameId(content1.Id(), kForegroundType), IsSameId(container1.Id(), kForegroundType), IsSameId(container2.Id(), kBackgroundType), IsSameId(content2.Id(), kBackgroundType), IsSameId(content2.Id(), kForegroundType), IsSameId(container2.Id(), kForegroundType))); { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); InitRootChunk(paint_controller); // Simulate the situation when |container1| gets a z-index that is greater // than that of |container2|, and |container1| is invalidated. container1.Invalidate(); EXPECT_EQ(kCached, DrawRect(context, container2, kBackgroundType, gfx::Rect(100, 200, 100, 100))); EXPECT_EQ(kCached, DrawRect(context, content2, kBackgroundType, gfx::Rect(100, 200, 50, 200))); EXPECT_EQ(kCached, DrawRect(context, content2, kForegroundType, gfx::Rect(100, 200, 50, 200))); EXPECT_EQ(kCached, DrawRect(context, container2, kForegroundType, gfx::Rect(100, 200, 100, 100))); EXPECT_EQ(kRepaintedCachedItem, DrawRect(context, container1, kBackgroundType, gfx::Rect(100, 100, 100, 100))); EXPECT_EQ(kCached, DrawRect(context, content1, kBackgroundType, gfx::Rect(100, 100, 50, 200))); EXPECT_EQ(kCached, DrawRect(context, content1, kForegroundType, gfx::Rect(100, 100, 50, 200))); EXPECT_EQ(kRepaintedCachedItem, DrawRect(context, container1, kForegroundType, gfx::Rect(100, 100, 100, 100))); } EXPECT_THAT(GetPersistentData().GetDisplayItemList(), ElementsAre(IsSameId(container2.Id(), kBackgroundType), IsSameId(content2.Id(), kBackgroundType), IsSameId(content2.Id(), kForegroundType), IsSameId(container2.Id(), kForegroundType), IsSameId(container1.Id(), kBackgroundType), IsSameId(content1.Id(), kBackgroundType), IsSameId(content1.Id(), kForegroundType), IsSameId(container1.Id(), kForegroundType))); EXPECT_DEFAULT_ROOT_CHUNK(8); } TEST_P(PaintControllerTest, CachedSubsequenceForcePaintChunk) { if (RuntimeEnabledFeatures::PaintUnderInvalidationCheckingEnabled()) return; FakeDisplayItemClient& root = *MakeGarbageCollected("root"); auto root_properties = DefaultPaintChunkProperties(); PaintChunk::Id root_id(root.Id(), DisplayItem::kCaret); FakeDisplayItemClient& container = *MakeGarbageCollected("container"); auto container_properties = DefaultPaintChunkProperties(); PaintChunk::Id container_id(container.Id(), DisplayItem::kCaret); { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); paint_controller.UpdateCurrentPaintChunkProperties(root_id, root, root_properties); DrawRect(context, root, kBackgroundType, gfx::Rect(100, 100, 100, 100)); { SubsequenceRecorder r(context, container); paint_controller.UpdateCurrentPaintChunkProperties( container_id, container, container_properties); DrawRect(context, container, kBackgroundType, gfx::Rect(100, 100, 100, 100)); DrawRect(context, container, kForegroundType, gfx::Rect(100, 100, 100, 100)); } DrawRect(context, root, kForegroundType, gfx::Rect(100, 100, 100, 100)); } // Even though the paint properties match, |container| should receive its // own PaintChunk because it created a subsequence. EXPECT_THAT( GetPersistentData().GetPaintChunks(), ElementsAre(IsPaintChunk(0, 1, root_id, root_properties), IsPaintChunk(1, 3, container_id, container_properties), IsPaintChunk(3, 4, PaintChunk::Id(root.Id(), kForegroundType), root_properties))); { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); paint_controller.UpdateCurrentPaintChunkProperties(root_id, root, root_properties); EXPECT_EQ(kCached, DrawRect(context, root, kBackgroundType, gfx::Rect(100, 100, 100, 100))); EXPECT_TRUE(paint_controller.UseCachedSubsequenceIfPossible(container)); EXPECT_EQ(kCached, DrawRect(context, root, kForegroundType, gfx::Rect(100, 100, 100, 100))); } // |container| should still receive its own PaintChunk because it is a cached // subsequence. EXPECT_THAT( GetPersistentData().GetPaintChunks(), ElementsAre(IsPaintChunk(0, 1, root_id, root_properties), IsPaintChunk(1, 3, container_id, container_properties), IsPaintChunk(3, 4, PaintChunk::Id(root.Id(), kForegroundType), container_properties))); } TEST_P(PaintControllerTest, CachedSubsequenceSwapOrder) { FakeDisplayItemClient& container1 = *MakeGarbageCollected("container1"); FakeDisplayItemClient& content1 = *MakeGarbageCollected("content1"); FakeDisplayItemClient& container2 = *MakeGarbageCollected("container2"); FakeDisplayItemClient& content2 = *MakeGarbageCollected("content2"); PaintChunk::Id container1_id(container1.Id(), kBackgroundType); auto* container1_effect = CreateOpacityEffect(e0(), 0.5); auto container1_properties = DefaultPaintChunkProperties(); container1_properties.SetEffect(*container1_effect); PaintChunk::Id container2_id(container2.Id(), kBackgroundType); auto* container2_effect = CreateOpacityEffect(e0(), 0.5); auto container2_properties = DefaultPaintChunkProperties(); container2_properties.SetEffect(*container2_effect); { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); { paint_controller.UpdateCurrentPaintChunkProperties( container1_id, container1, container1_properties); SubsequenceRecorder r(context, container1); DrawRect(context, container1, kBackgroundType, gfx::Rect(100, 100, 100, 100)); DrawRect(context, content1, kBackgroundType, gfx::Rect(100, 100, 50, 200)); DrawRect(context, content1, kForegroundType, gfx::Rect(100, 100, 50, 200)); DrawRect(context, container1, kForegroundType, gfx::Rect(100, 100, 100, 100)); } { paint_controller.UpdateCurrentPaintChunkProperties( container2_id, container2, container2_properties); SubsequenceRecorder r(context, container2); DrawRect(context, container2, kBackgroundType, gfx::Rect(100, 200, 100, 100)); DrawRect(context, content2, kBackgroundType, gfx::Rect(100, 200, 50, 200)); DrawRect(context, content2, kForegroundType, gfx::Rect(100, 200, 50, 200)); DrawRect(context, container2, kForegroundType, gfx::Rect(100, 200, 100, 100)); } } EXPECT_THAT(GetPersistentData().GetDisplayItemList(), ElementsAre(IsSameId(container1.Id(), kBackgroundType), IsSameId(content1.Id(), kBackgroundType), IsSameId(content1.Id(), kForegroundType), IsSameId(container1.Id(), kForegroundType), IsSameId(container2.Id(), kBackgroundType), IsSameId(content2.Id(), kBackgroundType), IsSameId(content2.Id(), kForegroundType), IsSameId(container2.Id(), kForegroundType))); EXPECT_SUBSEQUENCE(container1, 0, 1); EXPECT_NO_SUBSEQUENCE(content1); EXPECT_SUBSEQUENCE(container2, 1, 2); EXPECT_NO_SUBSEQUENCE(content2); EXPECT_THAT( GetPersistentData().GetPaintChunks(), ElementsAre(IsPaintChunk(0, 4, container1_id, container1_properties), IsPaintChunk(4, 8, container2_id, container2_properties))); { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); // Simulate the situation when |container1| gets a z-index that is greater // than that of |container2|. if (RuntimeEnabledFeatures::PaintUnderInvalidationCheckingEnabled()) { // When under-invalidation-checking is enabled, // UseCachedSubsequenceIfPossible is forced off, and the client is // expected to create the same painting as in the previous paint. EXPECT_FALSE(SubsequenceRecorder::UseCachedSubsequenceIfPossible( context, container2)); { paint_controller.UpdateCurrentPaintChunkProperties( container2_id, container2, container2_properties); SubsequenceRecorder r(context, container2); EXPECT_EQ(kCached, DrawRect(context, container2, kBackgroundType, gfx::Rect(100, 200, 100, 100))); EXPECT_EQ(kCached, DrawRect(context, content2, kBackgroundType, gfx::Rect(100, 200, 50, 200))); EXPECT_EQ(kCached, DrawRect(context, content2, kForegroundType, gfx::Rect(100, 200, 50, 200))); EXPECT_EQ(kCached, DrawRect(context, container2, kForegroundType, gfx::Rect(100, 200, 100, 100))); } EXPECT_FALSE(SubsequenceRecorder::UseCachedSubsequenceIfPossible( context, container1)); { paint_controller.UpdateCurrentPaintChunkProperties( container1_id, container1, container1_properties); SubsequenceRecorder r(context, container1); EXPECT_EQ(kCached, DrawRect(context, container1, kBackgroundType, gfx::Rect(100, 100, 100, 100))); EXPECT_EQ(kCached, DrawRect(context, content1, kBackgroundType, gfx::Rect(100, 100, 50, 200))); EXPECT_EQ(kCached, DrawRect(context, content1, kForegroundType, gfx::Rect(100, 100, 50, 200))); EXPECT_EQ(kCached, DrawRect(context, container1, kForegroundType, gfx::Rect(100, 100, 100, 100))); } } else { EXPECT_TRUE(SubsequenceRecorder::UseCachedSubsequenceIfPossible( context, container2)); EXPECT_TRUE(SubsequenceRecorder::UseCachedSubsequenceIfPossible( context, container1)); } EXPECT_EQ(8u, NumCachedNewItems(paint_controller)); EXPECT_EQ(2u, NumCachedNewSubsequences(paint_controller)); #if DCHECK_IS_ON() EXPECT_EQ(0u, NumIndexedItems(paint_controller)); EXPECT_EQ(0u, NumSequentialMatches(paint_controller)); EXPECT_EQ(0u, NumOutOfOrderMatches(paint_controller)); #endif } EXPECT_THAT(GetPersistentData().GetDisplayItemList(), ElementsAre(IsSameId(container2.Id(), kBackgroundType), IsSameId(content2.Id(), kBackgroundType), IsSameId(content2.Id(), kForegroundType), IsSameId(container2.Id(), kForegroundType), IsSameId(container1.Id(), kBackgroundType), IsSameId(content1.Id(), kBackgroundType), IsSameId(content1.Id(), kForegroundType), IsSameId(container1.Id(), kForegroundType))); EXPECT_SUBSEQUENCE(container1, 1, 2); EXPECT_NO_SUBSEQUENCE(content1); EXPECT_SUBSEQUENCE(container2, 0, 1); EXPECT_NO_SUBSEQUENCE(content2); EXPECT_THAT( GetPersistentData().GetPaintChunks(), ElementsAre(IsPaintChunk(0, 4, container2_id, container2_properties), IsPaintChunk(4, 8, container1_id, container1_properties))); } TEST_P(PaintControllerTest, CachedSubsequenceAndDisplayItemsSwapOrder) { FakeDisplayItemClient& content1 = *MakeGarbageCollected("content1"); FakeDisplayItemClient& container2 = *MakeGarbageCollected("container2"); FakeDisplayItemClient& content2 = *MakeGarbageCollected("content2"); PaintChunk::Id content1_id(content1.Id(), kBackgroundType); PaintChunk::Id container2_id(container2.Id(), kBackgroundType); PaintChunk::Id content2_id(content2.Id(), kBackgroundType); { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); InitRootChunk(paint_controller); DrawRect(context, content1, kBackgroundType, gfx::Rect(100, 100, 50, 200)); { SubsequenceRecorder r(context, container2); DrawRect(context, container2, kBackgroundType, gfx::Rect(100, 200, 100, 100)); DrawRect(context, content2, kBackgroundType, gfx::Rect(100, 200, 50, 200)); DrawRect(context, content2, kForegroundType, gfx::Rect(100, 200, 50, 200)); DrawRect(context, container2, kForegroundType, gfx::Rect(100, 200, 100, 100)); } DrawRect(context, content1, kForegroundType, gfx::Rect(100, 100, 50, 200)); } EXPECT_THAT(GetPersistentData().GetDisplayItemList(), ElementsAre(IsSameId(content1.Id(), kBackgroundType), IsSameId(container2.Id(), kBackgroundType), IsSameId(content2.Id(), kBackgroundType), IsSameId(content2.Id(), kForegroundType), IsSameId(container2.Id(), kForegroundType), IsSameId(content1.Id(), kForegroundType))); EXPECT_NO_SUBSEQUENCE(content1); EXPECT_SUBSEQUENCE(container2, 1, 2); EXPECT_NO_SUBSEQUENCE(content2); EXPECT_THAT( GetPersistentData().GetPaintChunks(), ElementsAre( IsPaintChunk(0, 1, DefaultRootChunkId(), DefaultPaintChunkProperties()), IsPaintChunk(1, 5, PaintChunk::Id(container2.Id(), kBackgroundType), DefaultPaintChunkProperties()), IsPaintChunk(5, 6, PaintChunk::Id(content1.Id(), kForegroundType), DefaultPaintChunkProperties()))); // Simulate the situation when |container2| gets a z-index that is smaller // than that of |content1|. { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); InitRootChunk(paint_controller); if (RuntimeEnabledFeatures::PaintUnderInvalidationCheckingEnabled()) { // When under-invalidation-checking is enabled, // UseCachedSubsequenceIfPossible is forced off, and the client is // expected to create the same painting as in the previous paint. EXPECT_FALSE(SubsequenceRecorder::UseCachedSubsequenceIfPossible( context, container2)); { SubsequenceRecorder r(context, container2); EXPECT_EQ(kCached, DrawRect(context, container2, kBackgroundType, gfx::Rect(100, 200, 100, 100))); EXPECT_EQ(kCached, DrawRect(context, content2, kBackgroundType, gfx::Rect(100, 200, 50, 200))); EXPECT_EQ(kCached, DrawRect(context, content2, kForegroundType, gfx::Rect(100, 200, 50, 200))); EXPECT_EQ(kCached, DrawRect(context, container2, kForegroundType, gfx::Rect(100, 200, 100, 100))); } EXPECT_EQ(kCached, DrawRect(context, content1, kBackgroundType, gfx::Rect(100, 100, 50, 200))); EXPECT_EQ(kCached, DrawRect(context, content1, kForegroundType, gfx::Rect(100, 100, 50, 200))); } else { EXPECT_TRUE(SubsequenceRecorder::UseCachedSubsequenceIfPossible( context, container2)); EXPECT_TRUE(DrawingRecorder::UseCachedDrawingIfPossible(context, content1, kBackgroundType)); EXPECT_TRUE(DrawingRecorder::UseCachedDrawingIfPossible(context, content1, kForegroundType)); } EXPECT_EQ(6u, NumCachedNewItems(paint_controller)); EXPECT_EQ(1u, NumCachedNewSubsequences(paint_controller)); #if DCHECK_IS_ON() EXPECT_EQ(0u, NumIndexedItems(paint_controller)); EXPECT_EQ(2u, NumSequentialMatches(paint_controller)); EXPECT_EQ(0u, NumOutOfOrderMatches(paint_controller)); #endif } EXPECT_THAT(GetPersistentData().GetDisplayItemList(), ElementsAre(IsSameId(container2.Id(), kBackgroundType), IsSameId(content2.Id(), kBackgroundType), IsSameId(content2.Id(), kForegroundType), IsSameId(container2.Id(), kForegroundType), IsSameId(content1.Id(), kBackgroundType), IsSameId(content1.Id(), kForegroundType))); EXPECT_NO_SUBSEQUENCE(content1); EXPECT_SUBSEQUENCE(container2, 0, 1); EXPECT_NO_SUBSEQUENCE(content2); EXPECT_THAT( GetPersistentData().GetPaintChunks(), ElementsAre( IsPaintChunk(0, 4, PaintChunk::Id(container2.Id(), kBackgroundType), DefaultPaintChunkProperties()), IsPaintChunk(4, 6, PaintChunk::Id(content1.Id(), kBackgroundType), DefaultPaintChunkProperties()))); } TEST_P(PaintControllerTest, DisplayItemSwapOrderBeforeCachedSubsequence) { FakeDisplayItemClient& content1a = *MakeGarbageCollected("content1a"); FakeDisplayItemClient& content1b = *MakeGarbageCollected("content1b"); FakeDisplayItemClient& container2 = *MakeGarbageCollected("container2"); FakeDisplayItemClient& content3 = *MakeGarbageCollected("content3"); PaintChunk::Id content1a_id(content1a.Id(), kBackgroundType); PaintChunk::Id content1b_id(content1b.Id(), kBackgroundType); PaintChunk::Id container2_id(container2.Id(), kBackgroundType); PaintChunk::Id content3_id(content3.Id(), kBackgroundType); gfx::Rect rect(100, 100, 50, 200); { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); InitRootChunk(paint_controller); DrawRect(context, content1a, kBackgroundType, rect); DrawRect(context, content1b, kBackgroundType, rect); { SubsequenceRecorder r(context, container2); DrawRect(context, container2, kBackgroundType, rect); } DrawRect(context, content3, kBackgroundType, rect); } EXPECT_THAT(GetPersistentData().GetDisplayItemList(), ElementsAre(IsSameId(content1a.Id(), kBackgroundType), IsSameId(content1b.Id(), kBackgroundType), IsSameId(container2.Id(), kBackgroundType), IsSameId(content3.Id(), kBackgroundType))); // New paint order: // Subsequence(container1): container1, content1b(cached), content1a(cached). // Subsequence(container2): cached // Subsequence(contaienr3): container3, content3 { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); InitRootChunk(paint_controller); if (RuntimeEnabledFeatures::PaintUnderInvalidationCheckingEnabled()) { EXPECT_FALSE(DrawingRecorder::UseCachedDrawingIfPossible( context, content1b, kBackgroundType)); EXPECT_EQ(kCached, DrawRect(context, content1b, kBackgroundType, rect)); EXPECT_FALSE(DrawingRecorder::UseCachedDrawingIfPossible( context, content1a, kBackgroundType)); EXPECT_EQ(kCached, DrawRect(context, content1a, kBackgroundType, rect)); { EXPECT_FALSE(SubsequenceRecorder::UseCachedSubsequenceIfPossible( context, container2)); SubsequenceRecorder r(context, container2); EXPECT_EQ(kCached, DrawRect(context, container2, kBackgroundType, rect)); } EXPECT_FALSE(DrawingRecorder::UseCachedDrawingIfPossible( context, content3, kBackgroundType)); EXPECT_EQ(kCached, DrawRect(context, content3, kBackgroundType, rect)); } else { EXPECT_TRUE(DrawingRecorder::UseCachedDrawingIfPossible( context, content1b, kBackgroundType)); EXPECT_TRUE(DrawingRecorder::UseCachedDrawingIfPossible( context, content1a, kBackgroundType)); EXPECT_TRUE(SubsequenceRecorder::UseCachedSubsequenceIfPossible( context, container2)); EXPECT_TRUE(DrawingRecorder::UseCachedDrawingIfPossible(context, content3, kBackgroundType)); } EXPECT_EQ(4u, NumCachedNewItems(paint_controller)); EXPECT_EQ(1u, NumCachedNewSubsequences(paint_controller)); #if DCHECK_IS_ON() EXPECT_EQ(1u, NumIndexedItems(paint_controller)); EXPECT_EQ(2u, NumSequentialMatches(paint_controller)); EXPECT_EQ(1u, NumOutOfOrderMatches(paint_controller)); #endif } EXPECT_THAT(GetPersistentData().GetDisplayItemList(), ElementsAre(IsSameId(content1b.Id(), kBackgroundType), IsSameId(content1a.Id(), kBackgroundType), IsSameId(container2.Id(), kBackgroundType), IsSameId(content3.Id(), kBackgroundType))); } TEST_P(PaintControllerTest, CachedSubsequenceContainingFragments) { FakeDisplayItemClient& root = *MakeGarbageCollected("root"); constexpr wtf_size_t kFragmentCount = 3; FakeDisplayItemClient& container = *MakeGarbageCollected("container"); auto paint_container = [&container](GraphicsContext& context) { SubsequenceRecorder r(context, container); for (wtf_size_t i = 0; i < kFragmentCount; ++i) { ScopedDisplayItemFragment scoped_fragment(context, i); ScopedPaintChunkProperties content_chunk_properties( context.GetPaintController(), DefaultPaintChunkProperties(), container, kBackgroundType); DrawRect(context, container, kBackgroundType, gfx::Rect(100, 100, 100, 100)); } }; // The first paint. { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); ScopedPaintChunkProperties root_chunk_properties( paint_controller, DefaultPaintChunkProperties(), root, kBackgroundType); DrawRect(context, root, kBackgroundType, gfx::Rect(100, 100, 100, 100)); paint_container(context); DrawRect(context, root, kForegroundType, gfx::Rect(100, 100, 100, 100)); } auto check_paint_results = [this, &root, &container]() { EXPECT_THAT( GetPersistentData().GetPaintChunks(), ElementsAre( IsPaintChunk(0, 1, PaintChunk::Id(root.Id(), kBackgroundType), DefaultPaintChunkProperties()), // One chunk for all of the fragments because they have the // same properties. IsPaintChunk(1, 4, PaintChunk::Id(container.Id(), kBackgroundType), DefaultPaintChunkProperties()), IsPaintChunk(4, 5, PaintChunk::Id(root.Id(), kForegroundType), DefaultPaintChunkProperties()))); }; // Check results of the first paint. check_paint_results(); // The second paint. { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); ScopedPaintChunkProperties root_chunk_properties( paint_controller, DefaultPaintChunkProperties(), root, kBackgroundType); EXPECT_EQ(kCached, DrawRect(context, root, kBackgroundType, gfx::Rect(100, 100, 100, 100))); if (RuntimeEnabledFeatures::PaintUnderInvalidationCheckingEnabled()) { EXPECT_FALSE(paint_controller.UseCachedSubsequenceIfPossible(container)); paint_container(context); } else { EXPECT_TRUE(paint_controller.UseCachedSubsequenceIfPossible(container)); } EXPECT_EQ(kCached, DrawRect(context, root, kForegroundType, gfx::Rect(100, 100, 100, 100))); } // The second paint should produce the exactly same results. check_paint_results(); } TEST_P(PaintControllerTest, UpdateSwapOrderCrossingChunks) { FakeDisplayItemClient& container1 = *MakeGarbageCollected("container1"); FakeDisplayItemClient& content1 = *MakeGarbageCollected("content1"); FakeDisplayItemClient& container2 = *MakeGarbageCollected("container2"); FakeDisplayItemClient& content2 = *MakeGarbageCollected("content2"); PaintChunk::Id container1_id(container1.Id(), kBackgroundType); auto* container1_effect = CreateOpacityEffect(e0(), 0.5); auto container1_properties = DefaultPaintChunkProperties(); container1_properties.SetEffect(*container1_effect); PaintChunk::Id container2_id(container2.Id(), kBackgroundType); auto* container2_effect = CreateOpacityEffect(e0(), 0.5); auto container2_properties = DefaultPaintChunkProperties(); container2_properties.SetEffect(*container2_effect); { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); paint_controller.UpdateCurrentPaintChunkProperties( container1_id, container1, container1_properties); DrawRect(context, container1, kBackgroundType, gfx::Rect(100, 100, 100, 100)); DrawRect(context, content1, kBackgroundType, gfx::Rect(100, 100, 50, 200)); paint_controller.UpdateCurrentPaintChunkProperties( container2_id, container2, container2_properties); DrawRect(context, container2, kBackgroundType, gfx::Rect(100, 200, 100, 100)); DrawRect(context, content2, kBackgroundType, gfx::Rect(100, 200, 50, 200)); } EXPECT_THAT(GetPersistentData().GetDisplayItemList(), ElementsAre(IsSameId(container1.Id(), kBackgroundType), IsSameId(content1.Id(), kBackgroundType), IsSameId(container2.Id(), kBackgroundType), IsSameId(content2.Id(), kBackgroundType))); EXPECT_THAT( GetPersistentData().GetPaintChunks(), ElementsAre(IsPaintChunk(0, 2, container1_id, container1_properties), IsPaintChunk(2, 4, container2_id, container2_properties))); // Move content2 into container1, without invalidation. { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); paint_controller.UpdateCurrentPaintChunkProperties( container1_id, container1, container1_properties); EXPECT_EQ(kCached, DrawRect(context, container1, kBackgroundType, gfx::Rect(100, 100, 100, 100))); EXPECT_EQ(kCached, DrawRect(context, content1, kBackgroundType, gfx::Rect(100, 100, 50, 200))); EXPECT_EQ(kCached, DrawRect(context, content2, kBackgroundType, gfx::Rect(100, 200, 50, 200))); paint_controller.UpdateCurrentPaintChunkProperties( container2_id, container2, container2_properties); EXPECT_EQ(kCached, DrawRect(context, container2, kBackgroundType, gfx::Rect(100, 200, 100, 100))); EXPECT_EQ(4u, NumCachedNewItems(paint_controller)); EXPECT_EQ(0u, NumCachedNewSubsequences(paint_controller)); #if DCHECK_IS_ON() EXPECT_EQ(1u, NumIndexedItems(paint_controller)); EXPECT_EQ(3u, NumSequentialMatches(paint_controller)); EXPECT_EQ(1u, NumOutOfOrderMatches(paint_controller)); #endif } EXPECT_THAT(GetPersistentData().GetDisplayItemList(), ElementsAre(IsSameId(container1.Id(), kBackgroundType), IsSameId(content1.Id(), kBackgroundType), IsSameId(content2.Id(), kBackgroundType), IsSameId(container2.Id(), kBackgroundType))); EXPECT_THAT( GetPersistentData().GetPaintChunks(), ElementsAre(IsPaintChunk(0, 3, container1_id, container1_properties), IsPaintChunk(3, 4, container2_id, container2_properties))); } TEST_P(PaintControllerTest, OutOfOrderNoCrash) { FakeDisplayItemClient& client = *MakeGarbageCollected("client"); const DisplayItem::Type kType1 = DisplayItem::kDrawingFirst; const DisplayItem::Type kType2 = static_cast(DisplayItem::kDrawingFirst + 1); const DisplayItem::Type kType3 = static_cast(DisplayItem::kDrawingFirst + 2); const DisplayItem::Type kType4 = static_cast(DisplayItem::kDrawingFirst + 3); { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); InitRootChunk(paint_controller); DrawRect(context, client, kType1, gfx::Rect(100, 100, 100, 100)); DrawRect(context, client, kType2, gfx::Rect(100, 100, 50, 200)); DrawRect(context, client, kType3, gfx::Rect(100, 100, 50, 200)); DrawRect(context, client, kType4, gfx::Rect(100, 100, 100, 100)); } { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); InitRootChunk(paint_controller); EXPECT_EQ(kCached, DrawRect(context, client, kType2, gfx::Rect(100, 100, 50, 200))); EXPECT_EQ(kCached, DrawRect(context, client, kType3, gfx::Rect(100, 100, 50, 200))); EXPECT_EQ(kCached, DrawRect(context, client, kType1, gfx::Rect(100, 100, 100, 100))); EXPECT_EQ(kCached, DrawRect(context, client, kType4, gfx::Rect(100, 100, 100, 100))); } } TEST_P(PaintControllerTest, CachedNestedSubsequenceUpdate) { FakeDisplayItemClient& container1 = *MakeGarbageCollected("container1"); FakeDisplayItemClient& content1 = *MakeGarbageCollected("content1"); FakeDisplayItemClient& container2 = *MakeGarbageCollected("container2"); FakeDisplayItemClient& content2 = *MakeGarbageCollected("content2"); PaintChunk::Id container1_background_id(container1.Id(), kBackgroundType); auto* container1_effect = CreateOpacityEffect(e0(), 0.5); auto container1_background_properties = DefaultPaintChunkProperties(); container1_background_properties.SetEffect(*container1_effect); PaintChunk::Id container1_foreground_id(container1.Id(), kForegroundType); auto container1_foreground_properties = DefaultPaintChunkProperties(); container1_foreground_properties.SetEffect(*container1_effect); PaintChunk::Id content1_id(content1.Id(), kBackgroundType); auto* content1_effect = CreateOpacityEffect(e0(), 0.6); auto content1_properties = DefaultPaintChunkProperties(); content1_properties.SetEffect(*content1_effect); PaintChunk::Id container2_background_id(container2.Id(), kBackgroundType); auto* container2_effect = CreateOpacityEffect(e0(), 0.7); auto container2_background_properties = DefaultPaintChunkProperties(); container2_background_properties.SetEffect(*container2_effect); PaintChunk::Id content2_id(content2.Id(), kBackgroundType); auto* content2_effect = CreateOpacityEffect(e0(), 0.8); auto content2_properties = DefaultPaintChunkProperties(); content2_properties.SetEffect(*content2_effect); { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); { SubsequenceRecorder r(context, container1); paint_controller.UpdateCurrentPaintChunkProperties( container1_background_id, container1, container1_background_properties); DrawRect(context, container1, kBackgroundType, gfx::Rect(100, 100, 100, 100)); { SubsequenceRecorder inner_r(context, content1); paint_controller.UpdateCurrentPaintChunkProperties( content1_id, content1, content1_properties); DrawRect(context, content1, kBackgroundType, gfx::Rect(100, 100, 50, 200)); DrawRect(context, content1, kForegroundType, gfx::Rect(100, 100, 50, 200)); } paint_controller.UpdateCurrentPaintChunkProperties( container1_foreground_id, container1, container1_foreground_properties); DrawRect(context, container1, kForegroundType, gfx::Rect(100, 100, 100, 100)); } { SubsequenceRecorder r(context, container2); paint_controller.UpdateCurrentPaintChunkProperties( container2_background_id, container2, container2_background_properties); DrawRect(context, container2, kBackgroundType, gfx::Rect(100, 200, 100, 100)); { SubsequenceRecorder inner_r(context, content2); paint_controller.UpdateCurrentPaintChunkProperties( content2_id, content2, content2_properties); DrawRect(context, content2, kBackgroundType, gfx::Rect(100, 200, 50, 200)); } } } EXPECT_THAT(GetPersistentData().GetDisplayItemList(), ElementsAre(IsSameId(container1.Id(), kBackgroundType), IsSameId(content1.Id(), kBackgroundType), IsSameId(content1.Id(), kForegroundType), IsSameId(container1.Id(), kForegroundType), IsSameId(container2.Id(), kBackgroundType), IsSameId(content2.Id(), kBackgroundType))); EXPECT_SUBSEQUENCE(container1, 0, 3); EXPECT_SUBSEQUENCE(content1, 1, 2); EXPECT_SUBSEQUENCE(container2, 3, 5); EXPECT_SUBSEQUENCE(content2, 4, 5); EXPECT_THAT( GetPersistentData().GetPaintChunks(), ElementsAre(IsPaintChunk(0, 1, container1_background_id, container1_background_properties), IsPaintChunk(1, 3, content1_id, content1_properties), IsPaintChunk(3, 4, container1_foreground_id, container1_foreground_properties), IsPaintChunk(4, 5, container2_background_id, container2_background_properties), IsPaintChunk(5, 6, content2_id, content2_properties))); { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); // Invalidate container1 but not content1. container1.Invalidate(); // Container2 itself now becomes empty (but still has the 'content2' child), // and chooses not to output subsequence info. container2.Invalidate(); content2.Invalidate(); EXPECT_FALSE(SubsequenceRecorder::UseCachedSubsequenceIfPossible( context, container2)); EXPECT_FALSE( SubsequenceRecorder::UseCachedSubsequenceIfPossible(context, content2)); // Content2 now outputs foreground only. { SubsequenceRecorder r(context, content2); paint_controller.UpdateCurrentPaintChunkProperties(content2_id, content2, content2_properties); EXPECT_EQ(kPaintedNew, DrawRect(context, content2, kForegroundType, gfx::Rect(100, 200, 50, 200))); } // Repaint container1 with foreground only. { SubsequenceRecorder r(context, container1); EXPECT_FALSE(SubsequenceRecorder::UseCachedSubsequenceIfPossible( context, container1)); // Use cached subsequence of content1. if (RuntimeEnabledFeatures::PaintUnderInvalidationCheckingEnabled()) { // When under-invalidation-checking is enabled, // UseCachedSubsequenceIfPossible is forced off, and the client is // expected to create the same painting as in the previous paint. EXPECT_FALSE(SubsequenceRecorder::UseCachedSubsequenceIfPossible( context, content1)); SubsequenceRecorder inner_r(context, content1); paint_controller.UpdateCurrentPaintChunkProperties( content1_id, content1, content1_properties); EXPECT_EQ(kCached, DrawRect(context, content1, kBackgroundType, gfx::Rect(100, 100, 50, 200))); EXPECT_EQ(kCached, DrawRect(context, content1, kForegroundType, gfx::Rect(100, 100, 50, 200))); } else { EXPECT_TRUE(SubsequenceRecorder::UseCachedSubsequenceIfPossible( context, content1)); } paint_controller.UpdateCurrentPaintChunkProperties( container1_foreground_id, container1, container1_foreground_properties); EXPECT_EQ(kRepaintedCachedItem, DrawRect(context, container1, kForegroundType, gfx::Rect(100, 100, 100, 100))); } EXPECT_EQ(2u, NumCachedNewItems(paint_controller)); EXPECT_EQ(1u, NumCachedNewSubsequences(paint_controller)); #if DCHECK_IS_ON() EXPECT_EQ(6u, NumIndexedItems(paint_controller)); EXPECT_EQ(0u, NumSequentialMatches(paint_controller)); EXPECT_EQ(1u, NumOutOfOrderMatches(paint_controller)); #endif } EXPECT_THAT(GetPersistentData().GetDisplayItemList(), ElementsAre(IsSameId(content2.Id(), kForegroundType), IsSameId(content1.Id(), kBackgroundType), IsSameId(content1.Id(), kForegroundType), IsSameId(container1.Id(), kForegroundType))); EXPECT_NO_SUBSEQUENCE(container2); EXPECT_SUBSEQUENCE(content2, 0, 1); EXPECT_SUBSEQUENCE(container1, 1, 3); EXPECT_SUBSEQUENCE(content1, 1, 2); EXPECT_THAT(GetPersistentData().GetPaintChunks(), ElementsAre(IsPaintChunk(0, 1, content2_id, content2_properties), IsPaintChunk(1, 3, content1_id, content1_properties), IsPaintChunk(3, 4, container1_foreground_id, container1_foreground_properties))); } TEST_P(PaintControllerTest, CachedNestedSubsequenceKeepingDescendants) { if (RuntimeEnabledFeatures::PaintUnderInvalidationCheckingEnabled()) return; FakeDisplayItemClient& root = *MakeGarbageCollected("root"); auto properties = DefaultPaintChunkProperties(); PaintChunk::Id root_id(root.Id(), DisplayItem::kLayerChunk); FakeDisplayItemClient& container1 = *MakeGarbageCollected("container1"); PaintChunk::Id container1_bg_id(container1.Id(), kBackgroundType); PaintChunk::Id container1_fg_id(container1.Id(), kForegroundType); FakeDisplayItemClient& content1a = *MakeGarbageCollected("content1a"); PaintChunk::Id content1a_id(content1a.Id(), kBackgroundType); FakeDisplayItemClient& content1b = *MakeGarbageCollected("content1b"); PaintChunk::Id content1b_id(content1b.Id(), kForegroundType); FakeDisplayItemClient& container2 = *MakeGarbageCollected("container2"); PaintChunk::Id container2_id(container2.Id(), kBackgroundType); FakeDisplayItemClient& content2a = *MakeGarbageCollected("content2a"); PaintChunk::Id content2a_id(content2a.Id(), kBackgroundType); FakeDisplayItemClient& content2b = *MakeGarbageCollected("content2b"); PaintChunk::Id content2b_id(content2b.Id(), kForegroundType); { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); paint_controller.UpdateCurrentPaintChunkProperties(root_id, root, properties); { SubsequenceRecorder r(context, container1); DrawRect(context, container1, kBackgroundType, gfx::Rect(100, 100, 100, 100)); { SubsequenceRecorder inner_r(context, content1a); DrawRect(context, content1a, kBackgroundType, gfx::Rect(100, 100, 50, 200)); } { SubsequenceRecorder inner_r(context, content1b); DrawRect(context, content1b, kForegroundType, gfx::Rect(100, 100, 50, 200)); } DrawRect(context, container1, kForegroundType, gfx::Rect(100, 100, 100, 100)); } { SubsequenceRecorder r(context, container2); DrawRect(context, container2, kBackgroundType, gfx::Rect(100, 200, 100, 100)); { SubsequenceRecorder inner_r(context, content2a); DrawRect(context, content2a, kBackgroundType, gfx::Rect(100, 200, 50, 200)); } { SubsequenceRecorder inner_r(context, content2b); DrawRect(context, content2b, kForegroundType, gfx::Rect(100, 200, 50, 200)); } } EXPECT_EQ(0u, NumCachedNewItems(paint_controller)); EXPECT_EQ(0u, NumCachedNewSubsequences(paint_controller)); } EXPECT_THAT(GetPersistentData().GetDisplayItemList(), ElementsAre(IsSameId(container1.Id(), kBackgroundType), IsSameId(content1a.Id(), kBackgroundType), IsSameId(content1b.Id(), kForegroundType), IsSameId(container1.Id(), kForegroundType), IsSameId(container2.Id(), kBackgroundType), IsSameId(content2a.Id(), kBackgroundType), IsSameId(content2b.Id(), kForegroundType))); EXPECT_SUBSEQUENCE(container1, 0, 4); EXPECT_SUBSEQUENCE(content1a, 1, 2); EXPECT_SUBSEQUENCE(content1b, 2, 3); EXPECT_SUBSEQUENCE(container2, 4, 7); EXPECT_SUBSEQUENCE(content2a, 5, 6); EXPECT_SUBSEQUENCE(content2b, 6, 7); EXPECT_THAT(GetPersistentData().GetPaintChunks(), ElementsAre(IsPaintChunk(0, 1, container1_bg_id, properties), IsPaintChunk(1, 2, content1a_id, properties), IsPaintChunk(2, 3, content1b_id, properties), IsPaintChunk(3, 4, container1_fg_id, properties), IsPaintChunk(4, 5, container2_id, properties), IsPaintChunk(5, 6, content2a_id, properties), IsPaintChunk(6, 7, content2b_id, properties))); // Nothing invalidated. Should keep all subsequences. { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); EXPECT_TRUE(SubsequenceRecorder::UseCachedSubsequenceIfPossible( context, container1)); EXPECT_TRUE(SubsequenceRecorder::UseCachedSubsequenceIfPossible( context, container2)); EXPECT_EQ(7u, NumCachedNewItems(paint_controller)); EXPECT_EQ(6u, NumCachedNewSubsequences(paint_controller)); } EXPECT_THAT(GetPersistentData().GetDisplayItemList(), ElementsAre(IsSameId(container1.Id(), kBackgroundType), IsSameId(content1a.Id(), kBackgroundType), IsSameId(content1b.Id(), kForegroundType), IsSameId(container1.Id(), kForegroundType), IsSameId(container2.Id(), kBackgroundType), IsSameId(content2a.Id(), kBackgroundType), IsSameId(content2b.Id(), kForegroundType))); EXPECT_SUBSEQUENCE(container1, 0, 4); EXPECT_SUBSEQUENCE(content1a, 1, 2); EXPECT_SUBSEQUENCE(content1b, 2, 3); EXPECT_SUBSEQUENCE(container2, 4, 7); EXPECT_SUBSEQUENCE(content2a, 5, 6); EXPECT_SUBSEQUENCE(content2b, 6, 7); EXPECT_THAT(GetPersistentData().GetPaintChunks(), ElementsAre(IsPaintChunk(0, 1, container1_bg_id, properties), IsPaintChunk(1, 2, content1a_id, properties), IsPaintChunk(2, 3, content1b_id, properties), IsPaintChunk(3, 4, container1_fg_id, properties), IsPaintChunk(4, 5, container2_id, properties), IsPaintChunk(5, 6, content2a_id, properties), IsPaintChunk(6, 7, content2b_id, properties))); // Swap order of the subsequences of container1 and container2. // Nothing invalidated. Should keep all subsequences. { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); EXPECT_TRUE(SubsequenceRecorder::UseCachedSubsequenceIfPossible( context, container2)); EXPECT_TRUE(SubsequenceRecorder::UseCachedSubsequenceIfPossible( context, container1)); EXPECT_EQ(7u, NumCachedNewItems(paint_controller)); EXPECT_EQ(6u, NumCachedNewSubsequences(paint_controller)); } EXPECT_THAT(GetPersistentData().GetDisplayItemList(), ElementsAre(IsSameId(container2.Id(), kBackgroundType), IsSameId(content2a.Id(), kBackgroundType), IsSameId(content2b.Id(), kForegroundType), IsSameId(container1.Id(), kBackgroundType), IsSameId(content1a.Id(), kBackgroundType), IsSameId(content1b.Id(), kForegroundType), IsSameId(container1.Id(), kForegroundType))); EXPECT_SUBSEQUENCE(container2, 0, 3); EXPECT_SUBSEQUENCE(content2a, 1, 2); EXPECT_SUBSEQUENCE(content2b, 2, 3); EXPECT_SUBSEQUENCE(container1, 3, 7); EXPECT_SUBSEQUENCE(content1a, 4, 5); EXPECT_SUBSEQUENCE(content1b, 5, 6); EXPECT_THAT(GetPersistentData().GetPaintChunks(), ElementsAre(IsPaintChunk(0, 1, container2_id, properties), IsPaintChunk(1, 2, content2a_id, properties), IsPaintChunk(2, 3, content2b_id, properties), IsPaintChunk(3, 4, container1_bg_id, properties), IsPaintChunk(4, 5, content1a_id, properties), IsPaintChunk(5, 6, content1b_id, properties), IsPaintChunk(6, 7, container1_fg_id, properties))); } TEST_P(PaintControllerTest, SkipCache) { FakeDisplayItemClient& multicol = *MakeGarbageCollected("multicol"); FakeDisplayItemClient& content = *MakeGarbageCollected("content"); gfx::Rect rect1(100, 100, 50, 50); gfx::Rect rect2(150, 100, 50, 50); gfx::Rect rect3(200, 100, 50, 50); { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); InitRootChunk(paint_controller); DrawRect(context, multicol, kBackgroundType, gfx::Rect(100, 200, 100, 100)); paint_controller.BeginSkippingCache(); DrawRect(context, content, kForegroundType, rect1); DrawRect(context, content, kForegroundType, rect2); paint_controller.EndSkippingCache(); } EXPECT_THAT(GetPersistentData().GetDisplayItemList(), ElementsAre(IsSameId(multicol.Id(), kBackgroundType), IsSameId(content.Id(), kForegroundType), IsSameId(content.Id(), kForegroundType))); EXPECT_DEFAULT_ROOT_CHUNK(3); { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); InitRootChunk(paint_controller); // Draw again with nothing invalidated. EXPECT_TRUE(ClientCacheIsValid(multicol)); EXPECT_EQ(kCached, DrawRect(context, multicol, kBackgroundType, gfx::Rect(100, 200, 100, 100))); paint_controller.BeginSkippingCache(); EXPECT_EQ(kPaintedNew, DrawRect(context, content, kForegroundType, rect1)); EXPECT_EQ(kPaintedNew, DrawRect(context, content, kForegroundType, rect2)); paint_controller.EndSkippingCache(); EXPECT_EQ(1u, NumCachedNewItems(paint_controller)); EXPECT_EQ(0u, NumCachedNewSubsequences(paint_controller)); #if DCHECK_IS_ON() EXPECT_EQ(0u, NumIndexedItems(paint_controller)); EXPECT_EQ(1u, NumSequentialMatches(paint_controller)); EXPECT_EQ(0u, NumOutOfOrderMatches(paint_controller)); #endif } EXPECT_THAT(GetPersistentData().GetDisplayItemList(), ElementsAre(IsSameId(multicol.Id(), kBackgroundType), IsSameId(content.Id(), kForegroundType), IsSameId(content.Id(), kForegroundType))); EXPECT_DEFAULT_ROOT_CHUNK(3); { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); InitRootChunk(paint_controller); // Now the multicol becomes 3 columns and repaints. multicol.Invalidate(); EXPECT_EQ(kRepaintedCachedItem, DrawRect(context, multicol, kBackgroundType, gfx::Rect(100, 100, 100, 100))); paint_controller.BeginSkippingCache(); EXPECT_EQ(kPaintedNew, DrawRect(context, content, kForegroundType, rect1)); EXPECT_EQ(kPaintedNew, DrawRect(context, content, kForegroundType, rect2)); EXPECT_EQ(kPaintedNew, DrawRect(context, content, kForegroundType, rect3)); paint_controller.EndSkippingCache(); // We should repaint everything on invalidation of the scope container. const auto& display_item_list = GetNewPaintArtifact(paint_controller).GetDisplayItemList(); EXPECT_THAT(display_item_list, ElementsAre(IsSameId(multicol.Id(), kBackgroundType), IsSameId(content.Id(), kForegroundType), IsSameId(content.Id(), kForegroundType), IsSameId(content.Id(), kForegroundType))); } EXPECT_DEFAULT_ROOT_CHUNK(4); } TEST_P(PaintControllerTest, PartialSkipCache) { FakeDisplayItemClient& content = *MakeGarbageCollected("content"); gfx::Rect rect1(100, 100, 50, 50); gfx::Rect rect2(150, 100, 50, 50); gfx::Rect rect3(200, 100, 50, 50); { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); InitRootChunk(paint_controller); DrawRect(context, content, kBackgroundType, rect1); paint_controller.BeginSkippingCache(); DrawRect(context, content, kForegroundType, rect2); paint_controller.EndSkippingCache(); DrawRect(context, content, kForegroundType, rect3); } EXPECT_THAT(GetPersistentData().GetDisplayItemList(), ElementsAre(IsSameId(content.Id(), kBackgroundType), IsSameId(content.Id(), kForegroundType), IsSameId(content.Id(), kForegroundType))); // Content's cache is invalid because it has display items skipped cache. EXPECT_FALSE(ClientCacheIsValid(content)); EXPECT_EQ(PaintInvalidationReason::kUncacheable, content.GetPaintInvalidationReason()); { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); InitRootChunk(paint_controller); // Draw again with nothing invalidated. EXPECT_EQ(kPaintedNew, DrawRect(context, content, kBackgroundType, rect1)); paint_controller.BeginSkippingCache(); EXPECT_EQ(kPaintedNew, DrawRect(context, content, kForegroundType, rect2)); paint_controller.EndSkippingCache(); EXPECT_EQ(kPaintedNew, DrawRect(context, content, kForegroundType, rect3)); EXPECT_EQ(0u, NumCachedNewItems(paint_controller)); EXPECT_EQ(0u, NumCachedNewSubsequences(paint_controller)); #if DCHECK_IS_ON() EXPECT_EQ(0u, NumIndexedItems(paint_controller)); EXPECT_EQ(0u, NumSequentialMatches(paint_controller)); EXPECT_EQ(0u, NumOutOfOrderMatches(paint_controller)); #endif } EXPECT_THAT(GetPersistentData().GetDisplayItemList(), ElementsAre(IsSameId(content.Id(), kBackgroundType), IsSameId(content.Id(), kForegroundType), IsSameId(content.Id(), kForegroundType))); } TEST_P(PaintControllerTest, SkipCacheDuplicatedItemAndChunkIds) { FakeDisplayItemClient& chunk_client = *MakeGarbageCollected("chunk client"); FakeDisplayItemClient& item_client = *MakeGarbageCollected("item client"); auto properties = DefaultPaintChunkProperties(); PaintChunk::Id chunk_id(chunk_client.Id(), DisplayItem::kLayerChunk); { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); paint_controller.BeginSkippingCache(); { SubsequenceRecorder r(context, chunk_client); paint_controller.UpdateCurrentPaintChunkProperties(chunk_id, chunk_client, properties); DrawRect(context, item_client, kBackgroundType, gfx::Rect(0, 0, 100, 100)); } paint_controller.UpdateCurrentPaintChunkProperties(chunk_id, chunk_client, properties); DrawRect(context, item_client, kBackgroundType, gfx::Rect(0, 0, 100, 100)); paint_controller.EndSkippingCache(); } EXPECT_THAT(GetPersistentData().GetDisplayItemList(), ElementsAre(IsSameId(item_client.Id(), kBackgroundType), IsSameId(item_client.Id(), kBackgroundType))); EXPECT_FALSE( UNSAFE_TODO(GetPersistentData().GetDisplayItemList()[0]).IsCacheable()); EXPECT_FALSE( UNSAFE_TODO(GetPersistentData().GetDisplayItemList()[1]).IsCacheable()); EXPECT_THAT(GetPersistentData().GetPaintChunks(), ElementsAre(IsPaintChunk(0, 1, chunk_id, properties), IsPaintChunk(1, 2, chunk_id, properties))); EXPECT_FALSE(GetPersistentData().GetPaintChunks()[0].is_cacheable); EXPECT_FALSE(GetPersistentData().GetPaintChunks()[1].is_cacheable); } TEST_P(PaintControllerTest, SmallPaintControllerHasOnePaintChunk) { FakeDisplayItemClient& client = *MakeGarbageCollected("test client"); { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); InitRootChunk(paint_controller); DrawRect(context, client, kBackgroundType, gfx::Rect(0, 0, 100, 100)); } EXPECT_THAT(GetPersistentData().GetPaintChunks(), ElementsAre(IsPaintChunk(0, 1))); } void DrawPath(GraphicsContext& context, DisplayItemClient& client, DisplayItem::Type type, unsigned count) { if (DrawingRecorder::UseCachedDrawingIfPossible(context, client, type)) return; DrawingRecorder recorder(context, client, type, gfx::Rect(0, 0, 100, 100)); const SkPath path = SkPathBuilder() .moveTo(0, 0) .lineTo(0, 100) .lineTo(50, 50) .lineTo(100, 100) .lineTo(100, 0) .close() .detach(); cc::PaintFlags flags; flags.setAntiAlias(true); for (unsigned i = 0; i < count; i++) context.DrawPath(path, flags, AutoDarkMode::Disabled()); } TEST_P(PaintControllerTest, BeginAndEndFrame) { class FakeFrame {}; PaintController paint_controller; // PaintController should have one null frame in the stack since beginning. paint_controller.SetFirstPainted(); FrameFirstPaint result = paint_controller.EndFrame(nullptr); EXPECT_TRUE(result.first_painted); EXPECT_FALSE(result.text_painted); EXPECT_FALSE(result.image_painted); // Readd the null frame. paint_controller.BeginFrame(nullptr); std::unique_ptr frame1(new FakeFrame); paint_controller.BeginFrame(frame1.get()); paint_controller.SetFirstPainted(); paint_controller.SetTextPainted(); paint_controller.SetImagePainted(); result = paint_controller.EndFrame(frame1.get()); EXPECT_TRUE(result.first_painted); EXPECT_TRUE(result.text_painted); EXPECT_TRUE(result.image_painted); std::unique_ptr frame2(new FakeFrame); paint_controller.BeginFrame(frame2.get()); paint_controller.SetFirstPainted(); std::unique_ptr frame3(new FakeFrame); paint_controller.BeginFrame(frame3.get()); paint_controller.SetTextPainted(); paint_controller.SetImagePainted(); result = paint_controller.EndFrame(frame3.get()); EXPECT_FALSE(result.first_painted); EXPECT_TRUE(result.text_painted); EXPECT_TRUE(result.image_painted); result = paint_controller.EndFrame(frame2.get()); EXPECT_TRUE(result.first_painted); EXPECT_FALSE(result.text_painted); EXPECT_FALSE(result.image_painted); } TEST_P(PaintControllerTest, InsertValidItemInFront) { FakeDisplayItemClient& first = *MakeGarbageCollected("first"); FakeDisplayItemClient& second = *MakeGarbageCollected("second"); FakeDisplayItemClient& third = *MakeGarbageCollected("third"); FakeDisplayItemClient& fourth = *MakeGarbageCollected("fourth"); { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); InitRootChunk(paint_controller); DrawRect(context, first, kBackgroundType, gfx::Rect(100, 100, 300, 300)); DrawRect(context, second, kBackgroundType, gfx::Rect(100, 100, 200, 200)); DrawRect(context, third, kBackgroundType, gfx::Rect(100, 100, 100, 100)); DrawRect(context, fourth, kBackgroundType, gfx::Rect(100, 100, 50, 50)); EXPECT_EQ(0u, NumCachedNewItems(paint_controller)); EXPECT_EQ(0u, NumCachedNewSubsequences(paint_controller)); } EXPECT_THAT(GetPersistentData().GetDisplayItemList(), ElementsAre(IsSameId(first.Id(), kBackgroundType), IsSameId(second.Id(), kBackgroundType), IsSameId(third.Id(), kBackgroundType), IsSameId(fourth.Id(), kBackgroundType))); EXPECT_TRUE(first.IsValid()); EXPECT_TRUE(second.IsValid()); EXPECT_TRUE(third.IsValid()); EXPECT_TRUE(fourth.IsValid()); // Simulate that a composited scrolling element is scrolled down, and "first" // and "second" are scrolled out of the interest rect. { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); InitRootChunk(paint_controller); EXPECT_EQ(kCached, DrawRect(context, third, kBackgroundType, gfx::Rect(100, 100, 100, 100))); EXPECT_EQ(kCached, DrawRect(context, fourth, kBackgroundType, gfx::Rect(100, 100, 50, 50))); EXPECT_EQ(2u, NumCachedNewItems(paint_controller)); EXPECT_EQ(0u, NumCachedNewSubsequences(paint_controller)); #if DCHECK_IS_ON() // We indexed "first" and "second" when finding the cached item for "third". EXPECT_EQ(2u, NumIndexedItems(paint_controller)); EXPECT_EQ(2u, NumSequentialMatches(paint_controller)); EXPECT_EQ(0u, NumOutOfOrderMatches(paint_controller)); #endif } EXPECT_THAT(GetPersistentData().GetDisplayItemList(), ElementsAre(IsSameId(third.Id(), kBackgroundType), IsSameId(fourth.Id(), kBackgroundType))); EXPECT_TRUE(first.IsValid()); EXPECT_TRUE(second.IsValid()); EXPECT_TRUE(third.IsValid()); EXPECT_TRUE(fourth.IsValid()); // Simulate "first" and "second" are scrolled back into the interest rect. { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); InitRootChunk(paint_controller); EXPECT_EQ(kPaintedNew, DrawRect(context, first, kBackgroundType, gfx::Rect(100, 100, 300, 300))); EXPECT_EQ(kPaintedNew, DrawRect(context, second, kBackgroundType, gfx::Rect(100, 100, 200, 200))); EXPECT_EQ(kCached, DrawRect(context, third, kBackgroundType, gfx::Rect(100, 100, 100, 100))); EXPECT_EQ(kCached, DrawRect(context, fourth, kBackgroundType, gfx::Rect(100, 100, 50, 50))); EXPECT_EQ(2u, NumCachedNewItems(paint_controller)); EXPECT_EQ(0u, NumCachedNewSubsequences(paint_controller)); #if DCHECK_IS_ON() // We indexed "third" and "fourth" when finding the cached item for "first". EXPECT_EQ(2u, NumIndexedItems(paint_controller)); EXPECT_EQ(2u, NumSequentialMatches(paint_controller)); EXPECT_EQ(0u, NumOutOfOrderMatches(paint_controller)); #endif } EXPECT_THAT(GetPersistentData().GetDisplayItemList(), ElementsAre(IsSameId(first.Id(), kBackgroundType), IsSameId(second.Id(), kBackgroundType), IsSameId(third.Id(), kBackgroundType), IsSameId(fourth.Id(), kBackgroundType))); EXPECT_TRUE(first.IsValid()); EXPECT_TRUE(second.IsValid()); EXPECT_TRUE(third.IsValid()); EXPECT_TRUE(fourth.IsValid()); } TEST_P(PaintControllerTest, TransientPaintControllerIncompleteCycle) { PaintController paint_controller; GraphicsContext context(paint_controller); FakeDisplayItemClient& client = *MakeGarbageCollected("client"); InitRootChunk(paint_controller); DrawRect(context, client, kBackgroundType, gfx::Rect(100, 100, 50, 50)); // The client of a transient paint controller can abort without // CommintNewDisplayItems() and FinishCycle(). This should not crash. } TEST_P(PaintControllerTest, AllowDuplicatedIdForTransientPaintController) { PaintController paint_controller; GraphicsContext context(paint_controller); FakeDisplayItemClient& client = *MakeGarbageCollected("client"); InitRootChunk(paint_controller); { SubsequenceRecorder r(context, client); ScopedPaintChunkProperties p(paint_controller, DefaultPaintChunkProperties(), client, kBackgroundType); DrawRect(context, client, kBackgroundType, gfx::Rect(100, 100, 50, 50)); } { ScopedPaintChunkProperties p(paint_controller, DefaultPaintChunkProperties(), client, kBackgroundType); DrawRect(context, client, kBackgroundType, gfx::Rect(100, 100, 50, 50)); } auto& paint_artifact = paint_controller.CommitNewDisplayItems(); EXPECT_EQ(2u, paint_artifact.GetDisplayItemList().size()); EXPECT_EQ(2u, paint_artifact.GetPaintChunks().size()); } TEST_P(PaintControllerTest, AllowDuplicatedIdForUncacheableItem) { if (RuntimeEnabledFeatures::PaintUnderInvalidationCheckingEnabled()) return; gfx::Rect r(100, 100, 300, 300); FakeDisplayItemClient& cacheable = *MakeGarbageCollected("cacheable"); FakeDisplayItemClient& uncacheable = *MakeGarbageCollected("uncacheable"); uncacheable.Invalidate(PaintInvalidationReason::kUncacheable); EXPECT_TRUE(cacheable.IsCacheable()); EXPECT_FALSE(uncacheable.IsCacheable()); { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); InitRootChunk(paint_controller); { SubsequenceRecorder recorder(context, cacheable); DrawRect(context, cacheable, kBackgroundType, gfx::Rect(r)); DrawRect(context, uncacheable, kBackgroundType, gfx::Rect(r)); // This should not trigger the duplicated id assert. DrawRect(context, uncacheable, kBackgroundType, gfx::Rect(r)); } } EXPECT_TRUE( UNSAFE_TODO(GetPersistentData().GetDisplayItemList()[0]).IsCacheable()); EXPECT_FALSE( UNSAFE_TODO(GetPersistentData().GetDisplayItemList()[1]).IsCacheable()); EXPECT_FALSE( UNSAFE_TODO(GetPersistentData().GetDisplayItemList()[2]).IsCacheable()); EXPECT_TRUE(cacheable.IsCacheable()); EXPECT_FALSE(uncacheable.IsCacheable()); { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); InitRootChunk(paint_controller); EXPECT_TRUE(paint_controller.UseCachedSubsequenceIfPossible(cacheable)); } EXPECT_TRUE( UNSAFE_TODO(GetPersistentData().GetDisplayItemList()[0]).IsCacheable()); EXPECT_FALSE( UNSAFE_TODO(GetPersistentData().GetDisplayItemList()[1]).IsCacheable()); EXPECT_FALSE( UNSAFE_TODO(GetPersistentData().GetDisplayItemList()[2]).IsCacheable()); EXPECT_TRUE(cacheable.IsCacheable()); EXPECT_FALSE(uncacheable.IsCacheable()); } TEST_P(PaintControllerTest, RecordRegionCaptureDataValidData) { static const auto kCropId = RegionCaptureCropId(base::Token::CreateRandom()); static const gfx::Rect kBounds(1, 2, 640, 480); FakeDisplayItemClient& client = *MakeGarbageCollected("client"); { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); InitRootChunk(paint_controller); paint_controller.RecordRegionCaptureData(client, kCropId, kBounds); DrawRect(context, client, kBackgroundType, gfx::Rect(100, 100, 200, 200)); } EXPECT_THAT(GetPersistentData().GetDisplayItemList(), ElementsAre(IsSameId(client.Id(), kBackgroundType))); EXPECT_DEFAULT_ROOT_CHUNK(1); const PaintChunks& chunks = GetPersistentData().GetPaintChunks(); EXPECT_EQ(1u, chunks.size()); EXPECT_EQ(kBounds, chunks[0].region_capture_data->map.find(kCropId)->second); } TEST_P(PaintControllerTest, RecordTrackedElementData) { static const auto kId = TrackedElementId(base::Token::CreateRandom()); static const gfx::Rect kBounds(1, 2, 640, 480); const auto kFeature0 = static_cast(0); const auto kFeature1 = static_cast(1); const auto kFeature0ElementSubRect = TrackedElementSubRect(kId); const auto kFeature1ElementSubRect = TrackedElementSubRect( kId, /*should_add_to_compositor_frame_metadata=*/true); TrackedElementSubRects tracked_element_sub_rects; tracked_element_sub_rects.insert_or_assign( kFeature0, std::move(kFeature0ElementSubRect)); tracked_element_sub_rects.insert_or_assign( kFeature1, std::move(kFeature1ElementSubRect)); FakeDisplayItemClient& client = *MakeGarbageCollected("client"); { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); InitRootChunk(paint_controller); paint_controller.RecordTrackedElementData(client, kBounds, tracked_element_sub_rects); } ASSERT_EQ(1u, GetPersistentData().GetPaintChunks().size()); const auto& chunk = GetPersistentData().GetPaintChunks()[0]; ASSERT_TRUE(chunk.tracked_element_rects); ASSERT_EQ(2u, chunk.tracked_element_rects->map.size()); // Check the data for feature 0. ASSERT_TRUE(chunk.tracked_element_rects->map.contains(kFeature0)); const auto& feature0_rects = chunk.tracked_element_rects->map.at(kFeature0); ASSERT_EQ(1u, feature0_rects.size()); EXPECT_EQ(kId, feature0_rects[0].id); EXPECT_EQ(kBounds, feature0_rects[0].bounds); EXPECT_FALSE(feature0_rects[0].should_add_to_compositor_frame_metadata); // Check the data for feature 1. ASSERT_TRUE(chunk.tracked_element_rects->map.contains(kFeature1)); const auto& feature1_rects = chunk.tracked_element_rects->map.at(kFeature1); ASSERT_EQ(1u, feature1_rects.size()); EXPECT_EQ(kId, feature1_rects[0].id); EXPECT_EQ(kBounds, feature1_rects[0].bounds); EXPECT_TRUE(feature1_rects[0].should_add_to_compositor_frame_metadata); } // Death tests don't work properly on Android. #if defined(GTEST_HAS_DEATH_TEST) && !BUILDFLAG(IS_ANDROID) TEST_P(PaintControllerTest, RecordRegionCaptureDataEmptyToken) { static const auto kCropId = RegionCaptureCropId(base::Token{}); static const gfx::Rect kBounds(1, 2, 640, 480); FakeDisplayItemClient& client = *MakeGarbageCollected("client"); { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); InitRootChunk(paint_controller); // If DCHECKs are on the test stops here. Remainder verifies non-DCHECK // behavior. if (DCHECK_IS_ON()) { EXPECT_DEATH( paint_controller.RecordRegionCaptureData(client, kCropId, kBounds), "DCHECK failed: !crop_id->is_zero"); return; } // If DCHECKs are not enabled, we should just record the data as-is. paint_controller.RecordRegionCaptureData(client, kCropId, kBounds); DrawRect(context, client, kBackgroundType, gfx::Rect(100, 100, 200, 200)); } EXPECT_THAT(GetPersistentData().GetDisplayItemList(), ElementsAre(IsSameId(client.Id(), kBackgroundType))); EXPECT_DEFAULT_ROOT_CHUNK(1); const PaintChunks& chunks = GetPersistentData().GetPaintChunks(); EXPECT_EQ(1u, chunks.size()); EXPECT_EQ(kBounds, chunks[0].region_capture_data->map.at(kCropId)); } TEST_P(PaintControllerTest, DuplicatedSubsequences) { FakeDisplayItemClient& client = *MakeGarbageCollected("test"); auto paint_duplicated_subsequences = [&]() { { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); InitRootChunk(paint_controller); { SubsequenceRecorder r(context, client); DrawRect(context, client, kBackgroundType, gfx::Rect(100, 100, 100, 100)); } { SubsequenceRecorder r(context, client); DrawRect(context, client, kForegroundType, gfx::Rect(100, 100, 100, 100)); } } }; #if DCHECK_IS_ON() EXPECT_DEATH(paint_duplicated_subsequences(), "Multiple subsequences for client: \"test\""); #else // The following is for non-DCHECK path. No security CHECK should trigger. { paint_duplicated_subsequences(); // Paint again. AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); InitRootChunk(paint_controller); if (RuntimeEnabledFeatures::PaintUnderInvalidationCheckingEnabled()) { EXPECT_FALSE(paint_controller.UseCachedSubsequenceIfPossible(client)); SubsequenceRecorder r(context, client); DrawRect(context, client, kBackgroundType, gfx::Rect(100, 100, 100, 100)); } else { EXPECT_TRUE(paint_controller.UseCachedSubsequenceIfPossible(client)); } { // Should not use the cached duplicated subsequence. This currently hits a // DUMP_WILL_BE_NOTREACHED(), crashing in non-official builds. #if defined(OFFICIAL_BUILD) EXPECT_FALSE(paint_controller.UseCachedSubsequenceIfPossible(client)); #endif // defined(OFFICIAL_BUILD) SubsequenceRecorder r(context, client); DrawRect(context, client, kForegroundType, gfx::Rect(100, 100, 100, 100)); } } #endif } TEST_P(PaintControllerTest, DeletedClientInUnderInvalidatedSubsequence) { if (RuntimeEnabledFeatures::PaintUnderInvalidationCheckingEnabled()) return; FakeDisplayItemClient& container = *MakeGarbageCollected("container"); auto* content = MakeGarbageCollected("content"); { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); InitRootChunk(paint_controller); { SubsequenceRecorder r(context, container); DrawRect(context, *content, kBackgroundType, gfx::Rect(100, 100, 300, 300)); } } content = nullptr; { AutoCommitPaintController paint_controller(GetPersistentData()); GraphicsContext context(paint_controller); InitRootChunk(paint_controller); // Leave container not invalidated; this should not crash. EXPECT_TRUE(SubsequenceRecorder::UseCachedSubsequenceIfPossible(context, container)); } } #endif // defined(GTEST_HAS_DEATH_TEST) && !BUILDFLAG(IS_ANDROID) } // namespace blink