/* * Copyright (C) 2015 Google Inc. All rights reserved. * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions are * met: * * * Redistributions of source code must retain the above copyright * notice, this list of conditions and the following disclaimer. * * Redistributions in binary form must reproduce the above * copyright notice, this list of conditions and the following disclaimer * in the documentation and/or other materials provided with the * distribution. * * Neither the name of Google Inc. nor the names of its * contributors may be used to endorse or promote products derived from * this software without specific prior written permission. * * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ #include "third_party/blink/renderer/core/frame/browser_controls.h" #include "build/build_config.h" #include "testing/gmock/include/gmock/gmock.h" #include "testing/gtest/include/gtest/gtest.h" #include "third_party/blink/public/common/input/web_coalesced_input_event.h" #include "third_party/blink/public/common/page/page_zoom.h" #include "third_party/blink/public/web/web_element.h" #include "third_party/blink/public/web/web_settings.h" #include "third_party/blink/renderer/core/css/css_variable_data.h" #include "third_party/blink/renderer/core/css/document_style_environment_variables.h" #include "third_party/blink/renderer/core/css/style_engine.h" #include "third_party/blink/renderer/core/dom/element.h" #include "third_party/blink/renderer/core/dom/qualified_name.h" #include "third_party/blink/renderer/core/frame/frame_test_helpers.h" #include "third_party/blink/renderer/core/frame/local_frame.h" #include "third_party/blink/renderer/core/frame/local_frame_view.h" #include "third_party/blink/renderer/core/frame/visual_viewport.h" #include "third_party/blink/renderer/core/frame/web_local_frame_impl.h" #include "third_party/blink/renderer/core/fullscreen/fullscreen.h" #include "third_party/blink/renderer/core/geometry/dom_rect.h" #include "third_party/blink/renderer/core/layout/layout_view.h" #include "third_party/blink/renderer/core/page/page.h" #include "third_party/blink/renderer/core/paint/paint_and_raster_invalidation_test.h" #include "third_party/blink/renderer/core/paint/paint_layer.h" #include "third_party/blink/renderer/core/paint/paint_layer_scrollable_area.h" #include "third_party/blink/renderer/core/testing/scoped_mock_overlay_scrollbars.h" #include "third_party/blink/renderer/core/testing/sim/sim_request.h" #include "third_party/blink/renderer/core/testing/sim/sim_test.h" #include "third_party/blink/renderer/platform/testing/task_environment.h" #include "third_party/blink/renderer/platform/testing/testing_platform_support.h" #include "third_party/blink/renderer/platform/testing/unit_test_helpers.h" #include "third_party/blink/renderer/platform/testing/url_loader_mock_factory.h" #include "third_party/blink/renderer/platform/testing/url_test_helpers.h" #include "ui/gfx/geometry/insets.h" namespace blink { namespace { // From browser_controls_offset_manager.cc. const int64_t kShowHideMaxDurationMs = 200; } // namespace // These tests cover interactions between scrolling and browser controls, with a // focus on Blink-observable side effects. Scrolling happens in the compositor, // but browser controls state is propagated into blink::BrowserControls through // LayerTreeHost::ApplyCompositorChanges. Additional tests relating to cc state // can be found under LayerTreeHostImplBrowserControlsTest. class BrowserControlsTest : public testing::Test, public ScopedMockOverlayScrollbars { public: BrowserControlsTest() : base_url_("http://www.test.com/") { RegisterMockedHttpURLLoad("large-div.html"); RegisterMockedHttpURLLoad("overflow-scrolling.html"); RegisterMockedHttpURLLoad("iframe-scrolling.html"); RegisterMockedHttpURLLoad("iframe-scrolling-inner.html"); RegisterMockedHttpURLLoad("percent-height.html"); RegisterMockedHttpURLLoad("v-size.html"); RegisterMockedHttpURLLoad("sv-size.html"); RegisterMockedHttpURLLoad("lv-size.html"); RegisterMockedHttpURLLoad("dv-size.html"); RegisterMockedHttpURLLoad("vh-height-width-800.html"); RegisterMockedHttpURLLoad("95-vh.html"); RegisterMockedHttpURLLoad("vh-height-width-800-extra-wide.html"); RegisterMockedHttpURLLoad("fullscreen_iframe.html"); RegisterMockedHttpURLLoad("fullscreen_div.html"); } ~BrowserControlsTest() override { URLLoaderMockFactory::GetSingletonInstance() ->UnregisterAllURLsAndClearMemoryCache(); } WebViewImpl* Initialize(const std::string& page_name = "large-div.html") { // Load a page with large body and set viewport size to 400x400 to ensure // main frame is scrollable. helper_.InitializeAndLoad(base_url_ + page_name, nullptr, nullptr, &ConfigureSettings); helper_.Resize(gfx::Size(400, 400)); return GetWebView(); } static void ConfigureSettings(WebSettings* settings) { settings->SetJavaScriptEnabled(true); frame_test_helpers::WebViewHelper::UpdateAndroidCompositingSettings( settings); } void RegisterMockedHttpURLLoad(const std::string& file_name) { url_test_helpers::RegisterMockedURLLoadFromBase( WebString::FromUtf8(base_url_), test::CoreTestDataPath(), WebString::FromUtf8(file_name)); } WebGestureEvent GenerateEvent(WebInputEvent::Type type, int delta_x = 0, int delta_y = 0) { WebGestureEvent event(type, WebInputEvent::kNoModifiers, WebInputEvent::GetStaticTimeStampForTests(), WebGestureDevice::kTouchscreen); event.SetPositionInWidget(gfx::PointF(100, 100)); if (type == WebInputEvent::Type::kGestureScrollUpdate) { event.data.scroll_update.delta_x = delta_x; event.data.scroll_update.delta_y = delta_y; } else if (type == WebInputEvent::Type::kGestureScrollBegin) { event.data.scroll_begin.delta_x_hint = delta_x; event.data.scroll_begin.delta_y_hint = delta_y; } return event; } void VerticalScroll(float delta_y) { GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollBegin, 0, delta_y)); GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollUpdate, 0, delta_y)); GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollEnd)); // Runs LayerTreeHost::ApplyCompositorChanges, which sends scroll deltas etc // back to Blink. CompositeForTest(); } Element* GetElementById(const WebString& id) { return static_cast( GetWebView()->MainFrameImpl()->GetDocument().GetElementById(id)); } WebViewImpl* GetWebView() const { return helper_.GetWebView(); } LocalFrame* GetFrame() const { return helper_.LocalMainFrame()->GetFrame(); } VisualViewport& GetVisualViewport() const { return helper_.GetWebView()->GetPage()->GetVisualViewport(); } frame_test_helpers::TestWebFrameWidget* GetWebFrameWidget() const { return helper_.GetMainFrameWidget(); } void UpdateAllLifecyclePhases() { GetWebView()->MainFrameViewWidget()->UpdateAllLifecyclePhases( DocumentUpdateReason::kTest); } void CompositeForTest(base::TimeDelta animation_delay = base::TimeDelta()) { accumulated_animation_delay_ += animation_delay; helper_.GetLayerTreeHost()->CompositeForTest( base::TimeTicks::Now() + accumulated_animation_delay_, false, base::OnceClosure()); } void FinishAnimation() { // First tick (through LTHI::Animate), to initialize // BrowserControlsOffsetManager::Animation::start_time_. CompositeForTest(); // Second tick to set final value. CompositeForTest(base::Milliseconds(kShowHideMaxDurationMs)); } void SetMaxSafeAreaInsets(LocalFrame* frame, const gfx::Insets& insets) { GetWebView()->GetPage()->SetMaxSafeAreaInsets(frame, insets); } String ResolveSafeAreaInsetsBottom() { return ResolveSafeAreaInsetsBottom(GetFrame()); } String ResolveSafeAreaInsetsBottom(LocalFrame* frame) { return ResolveEnvVar(frame, "safe-area-inset-bottom"); } String ResolveEnvVar(const char* var_name) { return ResolveEnvVar(GetFrame(), var_name); } String ResolveEnvVar(LocalFrame* frame, const char* var_name) { DocumentStyleEnvironmentVariables& vars = frame->GetDocument()->GetStyleEngine().EnsureEnvironmentVariables(); CSSVariableData* data = vars.ResolveVariable(AtomicString(var_name), {}); EXPECT_NE(nullptr, data); return data->Serialize(); } private: test::TaskEnvironment task_environment_; ScopedTestingPlatformSupport platform_; std::string base_url_; frame_test_helpers::WebViewHelper helper_; base::TimeDelta accumulated_animation_delay_; }; class BrowserControlsSimTest : public SimTest { public: BrowserControlsSimTest() {} void SetUp() override { SimTest::SetUp(); frame_test_helpers::WebViewHelper::UpdateAndroidCompositingSettings( WebView().GetSettings()); WebView().SetDefaultPageScaleLimits(0.25f, 5); Compositor().LayerTreeHost()->UpdateBrowserControlsState( cc::BrowserControlsState::kBoth, cc::BrowserControlsState::kShown, false, std::nullopt); WebView().ResizeWithBrowserControls(gfx::Size(412, 604), 56.f, 50.f, true); } WebGestureEvent GenerateEvent(WebInputEvent::Type type, int delta_x = 0, int delta_y = 0) { WebGestureEvent event(type, WebInputEvent::kNoModifiers, WebInputEvent::GetStaticTimeStampForTests(), WebGestureDevice::kTouchscreen); event.SetPositionInWidget(gfx::PointF(100, 100)); if (type == WebInputEvent::Type::kGestureScrollUpdate) { event.data.scroll_update.delta_x = delta_x; event.data.scroll_update.delta_y = delta_y; } else if (type == WebInputEvent::Type::kGestureScrollBegin) { event.data.scroll_begin.delta_x_hint = delta_x; event.data.scroll_begin.delta_y_hint = delta_y; } return event; } void VerticalScroll(float delta_y) { GetWebFrameWidget().DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollBegin, 0, delta_y)); GetWebFrameWidget().DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollUpdate, 0, delta_y)); GetWebFrameWidget().DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollEnd)); // Runs LayerTreeHost::ApplyCompositorChanges, which sends scroll deltas etc // back to Blink. Compositor().BeginFrame(); } }; struct ViewportUnitTestCase { // The file to load in the WebView. See mocked files in BrowserControlsTest(). const char* filename; // The width that 50*vw should resolve to. float width; // The height that 50*vh should resolve to. float height; }; class BrowserControlsViewportUnitTest : public BrowserControlsTest, public ::testing::WithParamInterface {}; // Disable these tests on Mac OSX until further investigation. // Local build on Mac is OK but the bot fails. This is not an issue as // Browser Controls are currently only used on Android. #if BUILDFLAG(IS_MAC) #define MAYBE(test) DISABLED_##test #else #define MAYBE(test) test #endif // Scrolling down should hide browser controls. TEST_F(BrowserControlsTest, MAYBE(HideOnScrollDown)) { WebViewImpl* web_view = Initialize(); // initialize browser controls to be shown. web_view->ResizeWithBrowserControls(web_view->MainFrameViewWidget()->Size(), 50.f, 0, true); web_view->GetBrowserControls().SetShownRatio(1, 1); CompositeForTest(); GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollBegin)); EXPECT_FLOAT_EQ(50.f, web_view->GetBrowserControls().ContentOffset()); // Browser controls should be scrolled partially and page should not scroll. GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollUpdate, 0, -25.f)); CompositeForTest(); EXPECT_FLOAT_EQ(25.f, web_view->GetBrowserControls().ContentOffset()); EXPECT_EQ(ScrollOffset(0, 0), GetFrame()->View()->LayoutViewport()->GetScrollOffset()); // Browser controls should consume 25px and become hidden. Excess scroll // should be // consumed by the page. GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollUpdate, 0, -40.f)); CompositeForTest(); EXPECT_FLOAT_EQ(0.f, web_view->GetBrowserControls().ContentOffset()); EXPECT_EQ(ScrollOffset(0, 15), GetFrame()->View()->LayoutViewport()->GetScrollOffset()); // Only page should consume scroll GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollUpdate, 0, -20.f)); CompositeForTest(); EXPECT_FLOAT_EQ(0.f, web_view->GetBrowserControls().ContentOffset()); EXPECT_EQ(ScrollOffset(0, 35), GetFrame()->View()->LayoutViewport()->GetScrollOffset()); } // Scrolling down should hide bottom browser controls. TEST_F(BrowserControlsTest, MAYBE(HideBottomControlsOnScrollDown)) { WebViewImpl* web_view = Initialize(); // initialize browser controls to be shown. web_view->ResizeWithBrowserControls(web_view->MainFrameViewWidget()->Size(), 0, 50.f, true); web_view->GetBrowserControls().SetShownRatio(0.0, 1); CompositeForTest(); GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollBegin)); EXPECT_FLOAT_EQ(0.f, web_view->GetBrowserControls().ContentOffset()); // Bottom controls and page content should both scroll and there should be // no content offset. GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollUpdate, 0, -25.f)); CompositeForTest(); EXPECT_FLOAT_EQ(0.f, web_view->GetBrowserControls().ContentOffset()); EXPECT_FLOAT_EQ(0.5f, web_view->GetBrowserControls().BottomShownRatio()); EXPECT_EQ(ScrollOffset(0, 25.f), GetFrame()->View()->LayoutViewport()->GetScrollOffset()); // Browser controls should become completely hidden. GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollBegin)); GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollUpdate, 0, -40.f)); GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollEnd)); CompositeForTest(); EXPECT_FLOAT_EQ(0.f, web_view->GetBrowserControls().ContentOffset()); EXPECT_FLOAT_EQ(0.f, web_view->GetBrowserControls().BottomShownRatio()); EXPECT_EQ(ScrollOffset(0, 65.f), GetFrame()->View()->LayoutViewport()->GetScrollOffset()); } TEST_F(BrowserControlsTest, MAYBE(DynamicSafeAreaInsetBottomScrollDown)) { WebViewImpl* web_view = Initialize(); web_view->GetSettings()->SetDynamicSafeAreaInsetsEnabled(true); SetMaxSafeAreaInsets(GetFrame(), gfx::Insets().set_bottom(30)); // initialize browser controls to be shown. web_view->ResizeWithBrowserControls(web_view->MainFrameViewWidget()->Size(), 0, 50.f, true); web_view->GetBrowserControls().SetShownRatio(0.0, 1); CompositeForTest(); // Bottom insets should be 0, as browser control is presented and it's taller // than the bottom of the insets. EXPECT_EQ("0px", ResolveSafeAreaInsetsBottom()); // Bottom controls and page content should both scroll and there should be // no content offset. VerticalScroll(-40.0f); // Calculate the bottom safe area insets, as there's no min height for bottom // controls. // shown_ratio (0.2) = 1 - scroll_offset(40) / bottom_controls_height(50) // inset.bottom (20) = safe_area_insets.bottom(30) - // bottom_controls_height(50) * shown_ratio (0.2) EXPECT_FLOAT_EQ(0.2f, web_view->GetBrowserControls().BottomShownRatio()); EXPECT_EQ("20px", ResolveSafeAreaInsetsBottom()); // Browser controls should become completely hidden. VerticalScroll(-40.0f); EXPECT_FLOAT_EQ(0.f, web_view->GetBrowserControls().BottomShownRatio()); EXPECT_EQ("30px", ResolveSafeAreaInsetsBottom()); } TEST_F(BrowserControlsTest, SafeAreaInsetAccountsForBrowserZoom) { WebViewImpl* web_view = Initialize(); web_view->GetSettings()->SetDynamicSafeAreaInsetsEnabled(true); web_view->MainFrameViewWidget()->SetZoomLevel(ZoomFactorToZoomLevel(1.6)); SetMaxSafeAreaInsets(GetFrame(), gfx::Insets().set_bottom(30)); web_view->ResizeWithBrowserControls(web_view->MainFrameViewWidget()->Size(), 0, 50.f, true); CompositeForTest(); EXPECT_EQ("18.75px", ResolveSafeAreaInsetsBottom()); } TEST_F(BrowserControlsTest, SafeAreaInsetAccountsForDSF) { WebViewImpl* web_view = Initialize(); web_view->GetSettings()->SetDynamicSafeAreaInsetsEnabled(true); web_view->MainFrameViewWidget()->SetDeviceScaleFactorForTesting(2.5); web_view->MainFrameViewWidget()->SetZoomLevel(ZoomFactorToZoomLevel(2.0)); SetMaxSafeAreaInsets(GetFrame(), gfx::Insets().set_bottom(30)); web_view->ResizeWithBrowserControls(web_view->MainFrameViewWidget()->Size(), 0, 50.f, true); CompositeForTest(); EXPECT_EQ("15px", ResolveSafeAreaInsetsBottom()); } // Scrolling up should show browser controls. TEST_F(BrowserControlsTest, MAYBE(ShowOnScrollUp)) { WebViewImpl* web_view = Initialize(); // initialize browser controls to be hidden. web_view->ResizeWithBrowserControls(web_view->MainFrameViewWidget()->Size(), 50.f, 0, false); web_view->GetBrowserControls().SetShownRatio(0, 0); CompositeForTest(); GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollBegin)); EXPECT_FLOAT_EQ(0.f, web_view->GetBrowserControls().ContentOffset()); GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollUpdate, 0, 10.f)); CompositeForTest(); EXPECT_FLOAT_EQ(10.f, web_view->GetBrowserControls().ContentOffset()); EXPECT_EQ(ScrollOffset(0, 0), GetFrame()->View()->LayoutViewport()->GetScrollOffset()); GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollUpdate, 0, 50.f)); CompositeForTest(); EXPECT_FLOAT_EQ(50.f, web_view->GetBrowserControls().ContentOffset()); EXPECT_EQ(ScrollOffset(0, 0), GetFrame()->View()->LayoutViewport()->GetScrollOffset()); } // Scrolling up should show the bottom browser controls. TEST_F(BrowserControlsTest, MAYBE(ShowBottomControlsOnScrollUp)) { WebViewImpl* web_view = Initialize(); // initialize browser controls to be hidden. web_view->ResizeWithBrowserControls(web_view->MainFrameViewWidget()->Size(), 0, 50.f, false); web_view->GetBrowserControls().SetShownRatio(0, 0); CompositeForTest(); GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollBegin)); EXPECT_FLOAT_EQ(0.f, web_view->GetBrowserControls().ContentOffset()); // Allow some space to scroll up. GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollBegin)); GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollUpdate, 0, -50.f)); GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollEnd)); CompositeForTest(); GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollBegin)); GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollUpdate, 0, 25.f)); CompositeForTest(); EXPECT_FLOAT_EQ(0.5f, web_view->GetBrowserControls().BottomShownRatio()); GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollEnd)); FinishAnimation(); EXPECT_FLOAT_EQ(0.f, web_view->GetBrowserControls().ContentOffset()); EXPECT_FLOAT_EQ(1.f, web_view->GetBrowserControls().BottomShownRatio()); EXPECT_EQ(ScrollOffset(0, 25), GetFrame()->View()->LayoutViewport()->GetScrollOffset()); } TEST_F(BrowserControlsTest, MAYBE(DynamicSafeAreaInsetBottomScrollUp)) { WebViewImpl* web_view = Initialize(); web_view->GetSettings()->SetDynamicSafeAreaInsetsEnabled(true); SetMaxSafeAreaInsets(GetFrame(), gfx::Insets().set_bottom(30)); // initialize browser controls to be shown. web_view->ResizeWithBrowserControls(web_view->MainFrameViewWidget()->Size(), 0, 50.f, true); web_view->GetBrowserControls().SetShownRatio(0, 0); CompositeForTest(); // Bottom insets should be 30, as browser control is fully hidden. EXPECT_EQ("30px", ResolveSafeAreaInsetsBottom()); VerticalScroll(20.0f); // shown_ratio (0.4) = scroll_offset(20) / bottom_controls_height(50) // inset.bottom (0) = safe_area_insets.bottom(30) - // bottom_controls_height(50) * shown_ratio (0.4) EXPECT_FLOAT_EQ(0.4f, web_view->GetBrowserControls().BottomShownRatio()); EXPECT_EQ("10px", ResolveSafeAreaInsetsBottom()); VerticalScroll(20.0f); // Calculate the bottom safe area insets, as there's no min height for bottom // controls. // shown_ratio (0.8) = scroll_offset(40) / bottom_controls_height(50) // inset.bottom (0) = max(0, safe_area_insets.bottom(30) - // bottom_controls_height(50) * shown_ratio (0.8)) EXPECT_FLOAT_EQ(0.8f, web_view->GetBrowserControls().BottomShownRatio()); EXPECT_EQ("0px", ResolveSafeAreaInsetsBottom()); } // Scrolling up after previous scroll downs should cause browser controls to be // shown only after all previously scrolled down amount is compensated. TEST_F(BrowserControlsTest, MAYBE(ScrollDownThenUp)) { WebViewImpl* web_view = Initialize(); // initialize browser controls to be shown and position page at 100px. web_view->ResizeWithBrowserControls(web_view->MainFrameViewWidget()->Size(), 50.f, 0, true); web_view->GetBrowserControls().SetShownRatio(1, 1); GetFrame()->View()->GetScrollableArea()->SetScrollOffset( ScrollOffset(0, 100), mojom::blink::ScrollType::kProgrammatic, cc::ScrollSourceType::kNone); CompositeForTest(); GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollBegin)); EXPECT_FLOAT_EQ(50.f, web_view->GetBrowserControls().ContentOffset()); // Scroll down to completely hide browser controls. Excess deltaY (100px) // should be consumed by the page. GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollUpdate, 0, -150.f)); CompositeForTest(); EXPECT_FLOAT_EQ(0.f, web_view->GetBrowserControls().ContentOffset()); EXPECT_EQ(ScrollOffset(0, 200), GetFrame()->View()->LayoutViewport()->GetScrollOffset()); // Scroll up and ensure the browser controls does not move until we recover // 100px previously scrolled. GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollUpdate, 0, 40.f)); CompositeForTest(); EXPECT_FLOAT_EQ(0.f, web_view->GetBrowserControls().ContentOffset()); EXPECT_EQ(ScrollOffset(0, 160), GetFrame()->View()->LayoutViewport()->GetScrollOffset()); GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollUpdate, 0, 60.f)); CompositeForTest(); EXPECT_FLOAT_EQ(0.f, web_view->GetBrowserControls().ContentOffset()); EXPECT_EQ(ScrollOffset(0, 100), GetFrame()->View()->LayoutViewport()->GetScrollOffset()); // Now we have hit the threshold so further scroll up should be consumed by // browser controls. GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollUpdate, 0, 30.f)); CompositeForTest(); EXPECT_FLOAT_EQ(30.f, web_view->GetBrowserControls().ContentOffset()); EXPECT_EQ(ScrollOffset(0, 100), GetFrame()->View()->LayoutViewport()->GetScrollOffset()); // Once top control is fully shown then page should consume any excess scroll. GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollUpdate, 0, 70.f)); CompositeForTest(); EXPECT_FLOAT_EQ(50.f, web_view->GetBrowserControls().ContentOffset()); EXPECT_EQ(ScrollOffset(0, 50), GetFrame()->View()->LayoutViewport()->GetScrollOffset()); } // Scrolling down should always cause visible browser controls to start hiding // even if we have been scrolling up previously. TEST_F(BrowserControlsTest, MAYBE(ScrollUpThenDown)) { WebViewImpl* web_view = Initialize(); // initialize browser controls to be hidden and position page at 100px. web_view->ResizeWithBrowserControls(web_view->MainFrameViewWidget()->Size(), 50.f, 0, false); web_view->GetBrowserControls().SetShownRatio(0, 0); GetFrame()->View()->GetScrollableArea()->SetScrollOffset( ScrollOffset(0, 100), mojom::blink::ScrollType::kProgrammatic, cc::ScrollSourceType::kNone); CompositeForTest(); GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollBegin)); EXPECT_FLOAT_EQ(0.f, web_view->GetBrowserControls().ContentOffset()); // Scroll up to completely show browser controls. Excess deltaY (50px) should // be consumed by the page. GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollUpdate, 0, 100.f)); CompositeForTest(); EXPECT_FLOAT_EQ(50.f, web_view->GetBrowserControls().ContentOffset()); EXPECT_EQ(ScrollOffset(0, 50), GetFrame()->View()->LayoutViewport()->GetScrollOffset()); // Scroll down and ensure only browser controls is scrolled GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollUpdate, 0, -40.f)); CompositeForTest(); EXPECT_FLOAT_EQ(10.f, web_view->GetBrowserControls().ContentOffset()); EXPECT_EQ(ScrollOffset(0, 50), GetFrame()->View()->LayoutViewport()->GetScrollOffset()); GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollUpdate, 0, -60.f)); CompositeForTest(); EXPECT_FLOAT_EQ(0.f, web_view->GetBrowserControls().ContentOffset()); EXPECT_EQ(ScrollOffset(0, 100), GetFrame()->View()->LayoutViewport()->GetScrollOffset()); } // Browser controls should not consume horizontal scroll. TEST_F(BrowserControlsTest, MAYBE(HorizontalScroll)) { WebViewImpl* web_view = Initialize(); // initialize browser controls to be shown. web_view->ResizeWithBrowserControls(web_view->MainFrameViewWidget()->Size(), 50.f, 0, true); web_view->GetBrowserControls().SetShownRatio(1, 1); CompositeForTest(); GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollBegin)); EXPECT_FLOAT_EQ(50.f, web_view->GetBrowserControls().ContentOffset()); // Browser controls should not consume horizontal scroll. GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollUpdate, -110.f, -100.f)); CompositeForTest(); EXPECT_FLOAT_EQ(0.f, web_view->GetBrowserControls().ContentOffset()); EXPECT_EQ(ScrollOffset(110, 50), GetFrame()->View()->LayoutViewport()->GetScrollOffset()); GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollUpdate, -40.f, 0)); CompositeForTest(); EXPECT_FLOAT_EQ(0.f, web_view->GetBrowserControls().ContentOffset()); EXPECT_EQ(ScrollOffset(150, 50), GetFrame()->View()->LayoutViewport()->GetScrollOffset()); } // Page scale should not impact browser controls scrolling TEST_F(BrowserControlsTest, MAYBE(PageScaleHasNoImpact)) { WebViewImpl* web_view = Initialize(); GetWebView()->SetDefaultPageScaleLimits(0.25f, 5); web_view->SetPageScaleFactor(2.0); // Initialize browser controls to be shown. web_view->ResizeWithBrowserControls(web_view->MainFrameViewWidget()->Size(), 50.f, 0, true); web_view->GetBrowserControls().SetShownRatio(1, 1); CompositeForTest(); GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollBegin)); EXPECT_FLOAT_EQ(50.f, web_view->GetBrowserControls().ContentOffset()); // Browser controls should be scrolled partially and page should not scroll. GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollUpdate, 0, -20.f)); CompositeForTest(); EXPECT_FLOAT_EQ(30.f, web_view->GetBrowserControls().ContentOffset()); EXPECT_EQ(ScrollOffset(0, 0), GetFrame()->View()->GetScrollableArea()->GetScrollOffset()); // Browser controls should consume 30px and become hidden. Excess scroll // should be consumed by the page at 2x scale. GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollUpdate, 0, -70.f)); CompositeForTest(); EXPECT_FLOAT_EQ(0.f, web_view->GetBrowserControls().ContentOffset()); EXPECT_EQ(ScrollOffset(0, 20), GetFrame()->View()->GetScrollableArea()->GetScrollOffset()); GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollEnd)); // Change page scale and test. web_view->SetPageScaleFactor(0.5); CompositeForTest(); GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollBegin)); EXPECT_FLOAT_EQ(0.f, web_view->GetBrowserControls().ContentOffset()); EXPECT_EQ(ScrollOffset(0, 20), GetFrame()->View()->GetScrollableArea()->GetScrollOffset()); GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollUpdate, 0, 50.f)); CompositeForTest(); EXPECT_FLOAT_EQ(50.f, web_view->GetBrowserControls().ContentOffset()); EXPECT_EQ(ScrollOffset(0, 20), GetFrame()->View()->GetScrollableArea()->GetScrollOffset()); // At 0.5x scale scrolling 10px should take us to the top of the page. GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollUpdate, 0, 10.f)); CompositeForTest(); EXPECT_FLOAT_EQ(50.f, web_view->GetBrowserControls().ContentOffset()); EXPECT_EQ(ScrollOffset(0, 0), GetFrame()->View()->GetScrollableArea()->GetScrollOffset()); } // Scrollable subregions should scroll before browser controls TEST_F(BrowserControlsTest, MAYBE(ScrollableSubregionScrollFirst)) { WebViewImpl* web_view = Initialize("overflow-scrolling.html"); web_view->ResizeWithBrowserControls(web_view->MainFrameViewWidget()->Size(), 50.f, 0, true); web_view->GetBrowserControls().SetShownRatio(1, 1); GetFrame()->View()->GetScrollableArea()->SetScrollOffset( ScrollOffset(0, 50), mojom::blink::ScrollType::kProgrammatic, cc::ScrollSourceType::kNone); CompositeForTest(); // Test scroll down // A full scroll down should scroll the overflow div first but browser // controls and main frame should not scroll. VerticalScroll(-800.f); EXPECT_FLOAT_EQ(50.f, web_view->GetBrowserControls().ContentOffset()); EXPECT_EQ(ScrollOffset(0, 50), GetFrame()->View()->LayoutViewport()->GetScrollOffset()); // Now scroll down should start hiding browser controls but main frame // should not scroll. GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollBegin, 0, -40.f)); GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollUpdate, 0, -40.f)); CompositeForTest(); EXPECT_FLOAT_EQ(10.f, web_view->GetBrowserControls().ContentOffset()); EXPECT_EQ(ScrollOffset(0, 50), GetFrame()->View()->LayoutViewport()->GetScrollOffset()); // Continued scroll down should scroll down the main frame GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollUpdate, 0, -40.f)); GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollEnd)); CompositeForTest(); EXPECT_FLOAT_EQ(0.f, web_view->GetBrowserControls().ContentOffset()); EXPECT_EQ(ScrollOffset(0, 80), GetFrame()->View()->LayoutViewport()->GetScrollOffset()); // Test scroll up // A full scroll up should scroll overflow div first VerticalScroll(800.f); EXPECT_FLOAT_EQ(0.f, web_view->GetBrowserControls().ContentOffset()); EXPECT_EQ(ScrollOffset(0, 80), GetFrame()->View()->LayoutViewport()->GetScrollOffset()); // Now scroll up should start showing browser controls but main frame // should not scroll. GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollBegin, 0, 40.f)); GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollUpdate, 0, 40.f)); CompositeForTest(); EXPECT_FLOAT_EQ(40.f, web_view->GetBrowserControls().ContentOffset()); EXPECT_EQ(ScrollOffset(0, 80), GetFrame()->View()->LayoutViewport()->GetScrollOffset()); // Continued scroll up scroll up the main frame GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollUpdate, 0, 40.f)); GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollEnd)); CompositeForTest(); EXPECT_FLOAT_EQ(50.f, web_view->GetBrowserControls().ContentOffset()); EXPECT_EQ(ScrollOffset(0, 50), GetFrame()->View()->LayoutViewport()->GetScrollOffset()); } // Scrollable iframes should scroll before browser controls TEST_F(BrowserControlsTest, MAYBE(ScrollableIframeScrollFirst)) { WebViewImpl* web_view = Initialize("iframe-scrolling.html"); web_view->ResizeWithBrowserControls(web_view->MainFrameViewWidget()->Size(), 50.f, 0, true); web_view->GetBrowserControls().SetShownRatio(1, 1); GetFrame()->View()->GetScrollableArea()->SetScrollOffset( ScrollOffset(0, 50), mojom::blink::ScrollType::kProgrammatic, cc::ScrollSourceType::kNone); CompositeForTest(); // Test scroll down // A full scroll down should scroll the iframe first but browser controls and // main frame should not scroll. VerticalScroll(-800.f); EXPECT_FLOAT_EQ(50.f, web_view->GetBrowserControls().ContentOffset()); EXPECT_EQ(ScrollOffset(0, 50), GetFrame()->View()->LayoutViewport()->GetScrollOffset()); // Now scroll down should start hiding browser controls but main frame // should not scroll. GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollBegin, 0, -40.f)); GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollUpdate, 0, -40.f)); CompositeForTest(); EXPECT_FLOAT_EQ(10.f, web_view->GetBrowserControls().ContentOffset()); EXPECT_EQ(ScrollOffset(0, 50), GetFrame()->View()->LayoutViewport()->GetScrollOffset()); // Continued scroll down should scroll down the main frame GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollUpdate, 0, -40.f)); GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollEnd)); CompositeForTest(); EXPECT_FLOAT_EQ(0.f, web_view->GetBrowserControls().ContentOffset()); EXPECT_EQ(ScrollOffset(0, 80), GetFrame()->View()->LayoutViewport()->GetScrollOffset()); // Test scroll up // A full scroll up should scroll iframe first VerticalScroll(800.f); EXPECT_FLOAT_EQ(0.f, web_view->GetBrowserControls().ContentOffset()); EXPECT_EQ(ScrollOffset(0, 80), GetFrame()->View()->LayoutViewport()->GetScrollOffset()); // Now scroll up should start showing browser controls but main frame // should not scroll. GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollBegin, 0, 40.f)); GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollUpdate, 0, 40.f)); CompositeForTest(); EXPECT_FLOAT_EQ(40.f, web_view->GetBrowserControls().ContentOffset()); EXPECT_EQ(ScrollOffset(0, 80), GetFrame()->View()->LayoutViewport()->GetScrollOffset()); // Continued scroll up scroll up the main frame GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollUpdate, 0, 40.f)); GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollEnd)); CompositeForTest(); EXPECT_FLOAT_EQ(50.f, web_view->GetBrowserControls().ContentOffset()); EXPECT_EQ(ScrollOffset(0, 50), GetFrame()->View()->LayoutViewport()->GetScrollOffset()); } TEST_F(BrowserControlsTest, MAYBE(SetMaxSafeAreaInsetWithDynamicSafeAreaInsets)) { WebViewImpl* web_view = Initialize(); web_view->GetSettings()->SetDynamicSafeAreaInsetsEnabled(true); SetMaxSafeAreaInsets(GetFrame(), gfx::Insets().set_bottom(30)); // initialize browser controls to be shown. web_view->GetBrowserControls().SetShownRatio(0.0, 1); web_view->ResizeWithBrowserControls(web_view->MainFrameViewWidget()->Size(), 0, 50.f, true); CompositeForTest(); // Bottom insets should be 0, as browser control is presented and it's taller // than the bottom of the insets. EXPECT_EQ("0px", ResolveSafeAreaInsetsBottom()); // Simulate setting a new max safe area inset (e.g. screen rotation). SetMaxSafeAreaInsets(GetFrame(), gfx::Insets().set_bottom(60)); // New safe area 10px = 60px - 50px. EXPECT_EQ("10px", ResolveSafeAreaInsetsBottom(GetFrame())); } TEST_F(BrowserControlsTest, MAYBE(SetMaxSafeAreaInsetWithSubFrames)) { WebViewImpl* web_view = Initialize("fullscreen_iframe.html"); web_view->GetSettings()->SetDynamicSafeAreaInsetsEnabled(false); SetMaxSafeAreaInsets(GetFrame(), gfx::Insets().set_bottom(30)); // initialize browser controls to be shown. web_view->ResizeWithBrowserControls(web_view->MainFrameViewWidget()->Size(), 0, 50.f, true); web_view->GetBrowserControls().SetShownRatio(0, 0); CompositeForTest(); EXPECT_EQ("30px", ResolveSafeAreaInsetsBottom()); // Find the sub frame, and request entering fullscreen. LocalFrame* iframe = To(web_view->MainFrame()->FirstChild())->GetFrame(); Document* document = iframe->GetDocument(); LocalFrame::NotifyUserActivation( iframe, mojom::UserActivationNotificationType::kTest); Element* div_fullscreen = document->getElementById(AtomicString("div1")); Fullscreen::RequestFullscreen(*div_fullscreen); web_view->DidEnterFullscreen(); UpdateAllLifecyclePhases(); // Main frame's SAI should remain the same. SetMaxSafeAreaInsets(iframe, gfx::Insets().set_bottom(40)); EXPECT_EQ("30px", ResolveSafeAreaInsetsBottom(GetFrame())); EXPECT_EQ("40px", ResolveSafeAreaInsetsBottom(iframe)); } TEST_F(BrowserControlsTest, MAYBE(SetMaxSafeAreaInsetWithSubFramesWithDynamicSafeAreaInsets)) { WebViewImpl* web_view = Initialize("fullscreen_iframe.html"); web_view->GetSettings()->SetDynamicSafeAreaInsetsEnabled(true); SetMaxSafeAreaInsets(GetFrame(), gfx::Insets().set_bottom(30)); // initialize browser controls to be shown. web_view->ResizeWithBrowserControls(web_view->MainFrameViewWidget()->Size(), 0, 50.f, true); web_view->GetBrowserControls().SetShownRatio(0, 0); CompositeForTest(); EXPECT_EQ("30px", ResolveSafeAreaInsetsBottom()); // Find the sub frame, and request entering fullscreen. LocalFrame* iframe = To(web_view->MainFrame()->FirstChild())->GetFrame(); Document* document = iframe->GetDocument(); LocalFrame::NotifyUserActivation( iframe, mojom::UserActivationNotificationType::kTest); Element* div_fullscreen = document->getElementById(AtomicString("div1")); Fullscreen::RequestFullscreen(*div_fullscreen); web_view->DidEnterFullscreen(); UpdateAllLifecyclePhases(); // Main frame's SAI should remain the same. SetMaxSafeAreaInsets(iframe, gfx::Insets().set_bottom(40)); EXPECT_EQ("30px", ResolveSafeAreaInsetsBottom(GetFrame())); EXPECT_EQ("40px", ResolveSafeAreaInsetsBottom(iframe)); // Simulate setting the main frame with a different max SAI - the main frame's // SAI is forced to go through even there's a fullscreen element. SetMaxSafeAreaInsets(GetFrame(), gfx::Insets().set_bottom(40)); EXPECT_EQ("40px", ResolveSafeAreaInsetsBottom(GetFrame())); EXPECT_EQ("40px", ResolveSafeAreaInsetsBottom(iframe)); } TEST_F(BrowserControlsTest, MAYBE(SafeAreaMaxInsetVars)) { WebViewImpl* web_view = Initialize(); web_view->GetSettings()->SetDynamicSafeAreaInsetsEnabled(true); gfx::Size widget_size = web_view->MainFrameViewWidget()->Size(); SetMaxSafeAreaInsets(GetFrame(), gfx::Insets().set_bottom(30)); // Initialize with bottom controls shown. web_view->GetBrowserControls().SetShownRatio(0, 1); web_view->ResizeWithBrowserControls(widget_size, 0, 50.f, true); CompositeForTest(); EXPECT_EQ("0px", ResolveSafeAreaInsetsBottom()); EXPECT_EQ("30px", ResolveEnvVar("safe-area-max-inset-bottom")); // Scroll to hide bottom controls. VerticalScroll(-40.0f); FinishAnimation(); web_view->ResizeWithBrowserControls(widget_size, 0, 50.f, false); UpdateAllLifecyclePhases(); // safe-area-max-inset-bottom should stay the same. EXPECT_EQ("30px", ResolveSafeAreaInsetsBottom()); EXPECT_EQ("30px", ResolveEnvVar("safe-area-max-inset-bottom")); // Simulate setting a new max safe area inset (e.g. screen rotation). SetMaxSafeAreaInsets(GetFrame(), gfx::Insets().set_bottom(60)); EXPECT_EQ("60px", ResolveEnvVar("safe-area-max-inset-bottom")); // Other safe-area-max-inset-* vars are 0. EXPECT_EQ("0px", ResolveEnvVar("safe-area-max-inset-top")); EXPECT_EQ("0px", ResolveEnvVar("safe-area-max-inset-left")); EXPECT_EQ("0px", ResolveEnvVar("safe-area-max-inset-right")); } // Browser controls visibility should remain consistent when height is changed. TEST_F(BrowserControlsTest, MAYBE(HeightChangeMaintainsVisibility)) { WebViewImpl* web_view = Initialize(); web_view->ResizeWithBrowserControls(web_view->MainFrameViewWidget()->Size(), 20.f, 0, false); web_view->GetBrowserControls().SetShownRatio(0, 0); web_view->ResizeWithBrowserControls(web_view->MainFrameViewWidget()->Size(), 20.f, 0, false); EXPECT_FLOAT_EQ(0.f, web_view->GetBrowserControls().ContentOffset()); web_view->ResizeWithBrowserControls(web_view->MainFrameViewWidget()->Size(), 40.f, 0, false); EXPECT_FLOAT_EQ(0.f, web_view->GetBrowserControls().ContentOffset()); CompositeForTest(); // Scroll up to show browser controls. VerticalScroll(40.f); EXPECT_FLOAT_EQ(40.f, web_view->GetBrowserControls().ContentOffset()); // Changing height of a fully shown browser controls should correctly adjust // content offset web_view->ResizeWithBrowserControls(web_view->MainFrameViewWidget()->Size(), 30.f, 0, false); EXPECT_FLOAT_EQ(30.f, web_view->GetBrowserControls().ContentOffset()); } // Zero delta should not have any effect on browser controls. TEST_F(BrowserControlsTest, MAYBE(ZeroHeightMeansNoEffect)) { WebViewImpl* web_view = Initialize(); web_view->ResizeWithBrowserControls(web_view->MainFrameViewWidget()->Size(), 0, 0, false); web_view->GetBrowserControls().SetShownRatio(0, 0); GetFrame()->View()->GetScrollableArea()->SetScrollOffset( ScrollOffset(0, 100), mojom::blink::ScrollType::kProgrammatic, cc::ScrollSourceType::kNone); CompositeForTest(); EXPECT_FLOAT_EQ(0.f, web_view->GetBrowserControls().ContentOffset()); VerticalScroll(20.f); EXPECT_FLOAT_EQ(0.f, web_view->GetBrowserControls().ContentOffset()); EXPECT_EQ(ScrollOffset(0, 80), GetFrame()->View()->LayoutViewport()->GetScrollOffset()); VerticalScroll(-30.f); EXPECT_FLOAT_EQ(0.f, web_view->GetBrowserControls().ContentOffset()); EXPECT_EQ(ScrollOffset(0, 110), GetFrame()->View()->LayoutViewport()->GetScrollOffset()); web_view->GetBrowserControls().SetShownRatio(1, 1); EXPECT_FLOAT_EQ(0.f, web_view->GetBrowserControls().ContentOffset()); } // Browser controls should not hide when scrolling up past limit TEST_F(BrowserControlsTest, MAYBE(ScrollUpPastLimitDoesNotHide)) { WebViewImpl* web_view = Initialize(); // Initialize browser controls to be shown web_view->ResizeWithBrowserControls(web_view->MainFrameViewWidget()->Size(), 50.f, 0, true); web_view->GetBrowserControls().SetShownRatio(1, 1); // Use 2x scale so that both visual viewport and frameview are scrollable web_view->SetPageScaleFactor(2.0); // Fully scroll frameview but visualviewport remains scrollable web_view->MainFrameImpl()->SetScrollOffset(gfx::PointF(0, 10000)); GetVisualViewport().SetLocation(gfx::PointF(0, 0)); CompositeForTest(); GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollBegin, 0, -10.f)); GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollUpdate, 0, -10.f)); CompositeForTest(); EXPECT_FLOAT_EQ(40, web_view->GetBrowserControls().ContentOffset()); GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollEnd)); FinishAnimation(); EXPECT_FLOAT_EQ(50, web_view->GetBrowserControls().ContentOffset()); web_view->GetBrowserControls().SetShownRatio(1, 1); // Fully scroll visual veiwport but frameview remains scrollable web_view->MainFrameImpl()->SetScrollOffset(gfx::PointF(0, 0)); GetVisualViewport().SetLocation(gfx::PointF(0, 10000)); GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollBegin, 0, -20.f)); GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollUpdate, 0, -20.f)); CompositeForTest(); EXPECT_FLOAT_EQ(30, web_view->GetBrowserControls().ContentOffset()); GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollEnd)); FinishAnimation(); EXPECT_FLOAT_EQ(50, web_view->GetBrowserControls().ContentOffset()); web_view->GetBrowserControls().SetShownRatio(1, 1); // Fully scroll both frameview and visual viewport web_view->MainFrameImpl()->SetScrollOffset(gfx::PointF(0, 10000)); GetVisualViewport().SetLocation(gfx::PointF(0, 10000)); CompositeForTest(); VerticalScroll(-30.f); // Browser controls should not move because neither frameview nor visual // viewport // are scrollable EXPECT_FLOAT_EQ(50.f, web_view->GetBrowserControls().ContentOffset()); } // Browser controls should honor its constraints TEST_F(BrowserControlsSimTest, MAYBE(StateConstraints)) { SimRequest request("https://example.com/test.html", "text/html"); LoadURL("https://example.com/test.html"); request.Complete(R"HTML( )HTML"); Compositor().BeginFrame(); WebView().ResizeWithBrowserControls(gfx::Size(400, 400), 50.f, 0, false); Compositor().BeginFrame(); GetDocument().View()->GetScrollableArea()->SetScrollOffset( ScrollOffset(0, 100), mojom::blink::ScrollType::kProgrammatic, cc::ScrollSourceType::kNone); // Setting permitted state should change the content offset to match the // constraint. Compositor().LayerTreeHost()->UpdateBrowserControlsState( cc::BrowserControlsState::kShown, cc::BrowserControlsState::kShown, false, std::nullopt); Compositor().BeginFrame(); EXPECT_FLOAT_EQ(50.f, WebView().GetBrowserControls().ContentOffset()); WebView().ResizeWithBrowserControls(gfx::Size(400, 400), 50.f, 50.f, false); Compositor().BeginFrame(); // Bottom controls shouldn't affect the content offset. EXPECT_FLOAT_EQ(50.f, WebView().GetBrowserControls().ContentOffset()); // Only shown state is permitted so controls cannot hide. VerticalScroll(-20.f); EXPECT_FLOAT_EQ(50, WebView().GetBrowserControls().ContentOffset()); EXPECT_EQ(ScrollOffset(0, 120), GetDocument().View()->LayoutViewport()->GetScrollOffset()); // Setting permitted state should change content offset to match the // constraint. Compositor().LayerTreeHost()->UpdateBrowserControlsState( cc::BrowserControlsState::kHidden, cc::BrowserControlsState::kHidden, false, std::nullopt); Compositor().BeginFrame(); EXPECT_FLOAT_EQ(0, WebView().GetBrowserControls().ContentOffset()); // Only hidden state is permitted so controls cannot show VerticalScroll(30.f); EXPECT_FLOAT_EQ(0, WebView().GetBrowserControls().ContentOffset()); EXPECT_EQ(ScrollOffset(0, 90), GetDocument().View()->LayoutViewport()->GetScrollOffset()); // Setting permitted state to "both" should not change content offset. Compositor().LayerTreeHost()->UpdateBrowserControlsState( cc::BrowserControlsState::kBoth, cc::BrowserControlsState::kBoth, false, std::nullopt); Compositor().BeginFrame(); EXPECT_FLOAT_EQ(0, WebView().GetBrowserControls().ContentOffset()); // Both states are permitted so controls can either show or hide VerticalScroll(50.f); EXPECT_FLOAT_EQ(50, WebView().GetBrowserControls().ContentOffset()); EXPECT_EQ(ScrollOffset(0, 90), GetDocument().View()->LayoutViewport()->GetScrollOffset()); VerticalScroll(-50.f); EXPECT_FLOAT_EQ(0, WebView().GetBrowserControls().ContentOffset()); EXPECT_EQ(ScrollOffset(0, 90), GetDocument().View()->LayoutViewport()->GetScrollOffset()); // Setting permitted state to "both" should not change an in-flight offset. GetWebFrameWidget().DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollBegin, 0, 20.f)); GetWebFrameWidget().DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollUpdate, 0, 20.f)); Compositor().BeginFrame(); EXPECT_FLOAT_EQ(20, WebView().GetBrowserControls().ContentOffset()); GetWebFrameWidget().DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollEnd)); Compositor().BeginFrame(); Compositor().BeginFrame(kShowHideMaxDurationMs / 1000.0); EXPECT_FLOAT_EQ(0, WebView().GetBrowserControls().ContentOffset()); Compositor().LayerTreeHost()->UpdateBrowserControlsState( cc::BrowserControlsState::kBoth, cc::BrowserControlsState::kBoth, false, std::nullopt); Compositor().BeginFrame(); EXPECT_FLOAT_EQ(0, WebView().GetBrowserControls().ContentOffset()); // Setting just the constraint should affect the content offset. Compositor().LayerTreeHost()->UpdateBrowserControlsState( cc::BrowserControlsState::kHidden, cc::BrowserControlsState::kBoth, false, std::nullopt); Compositor().BeginFrame(); EXPECT_FLOAT_EQ(0, WebView().GetBrowserControls().ContentOffset()); Compositor().LayerTreeHost()->UpdateBrowserControlsState( cc::BrowserControlsState::kShown, cc::BrowserControlsState::kBoth, false, std::nullopt); Compositor().BeginFrame(); EXPECT_FLOAT_EQ(50, WebView().GetBrowserControls().ContentOffset()); } // Ensure that browser controls do not affect the layout by showing and hiding // except for position: fixed elements. TEST_F(BrowserControlsTest, MAYBE(DontAffectLayoutHeight)) { // Initialize with the browser controls showing. WebViewImpl* web_view = Initialize("percent-height.html"); web_view->ResizeWithBrowserControls(gfx::Size(400, 300), 100.f, 0, true); web_view->GetBrowserControls().UpdateConstraintsAndState( cc::BrowserControlsState::kBoth, cc::BrowserControlsState::kShown); web_view->GetBrowserControls().SetShownRatio(1, 1); CompositeForTest(); ASSERT_EQ(100.f, web_view->GetBrowserControls().ContentOffset()); // When the browser controls are showing, there's 300px for the layout height // so // 50% should result in both the position:fixed and position: absolute divs // having 150px of height. Element* abs_pos = GetElementById(WebString("abs")); Element* fixed_pos = GetElementById(WebString("fixed")); EXPECT_FLOAT_EQ(150.f, abs_pos->GetBoundingClientRect()->height()); EXPECT_FLOAT_EQ(150.f, fixed_pos->GetBoundingClientRect()->height()); // The layout size on the LocalFrameView should not include the browser // controls. EXPECT_EQ(300, GetFrame()->View()->GetLayoutSize().height()); // Hide the browser controls. VerticalScroll(-100.f); web_view->ResizeWithBrowserControls(gfx::Size(400, 400), 100.f, 0, false); UpdateAllLifecyclePhases(); ASSERT_EQ(0.f, web_view->GetBrowserControls().ContentOffset()); // Hiding the browser controls shouldn't change the height of the initial // containing block for non-position: fixed. Position: fixed however should // use the entire height of the viewport however. EXPECT_FLOAT_EQ(150.f, abs_pos->GetBoundingClientRect()->height()); EXPECT_FLOAT_EQ(200.f, fixed_pos->GetBoundingClientRect()->height()); // The layout size should not change as a result of browser controls hiding. EXPECT_EQ(300, GetFrame()->View()->GetLayoutSize().height()); } // Ensure that browser controls do not affect the layout by showing and hiding // except for position: fixed elements. TEST_F(BrowserControlsSimTest, MAYBE(AffectLayoutHeightWhenConstrained)) { SimRequest request("https://example.com/test.html", "text/html"); LoadURL("https://example.com/test.html"); request.Complete(R"HTML(
)HTML"); Compositor().BeginFrame(); WebView().ResizeWithBrowserControls(gfx::Size(400, 300), 100.f, 0, true); Compositor().LayerTreeHost()->UpdateBrowserControlsState( cc::BrowserControlsState::kBoth, cc::BrowserControlsState::kShown, false, std::nullopt); Compositor().BeginFrame(); Element* abs_pos = GetDocument().getElementById(WebString("abs")); Element* fixed_pos = GetDocument().getElementById(WebString("fixed")); ASSERT_EQ(100.f, WebView().GetBrowserControls().ContentOffset()); // Hide the browser controls. VerticalScroll(-100.f); WebView().ResizeWithBrowserControls(gfx::Size(400, 400), 100.f, 0, false); Compositor().BeginFrame(); ASSERT_EQ(300, GetDocument().GetFrame()->View()->GetLayoutSize().height()); // Now lock the controls in a hidden state. The layout and elements should // resize without a WebView::resize. Compositor().LayerTreeHost()->UpdateBrowserControlsState( cc::BrowserControlsState::kHidden, cc::BrowserControlsState::kBoth, false, std::nullopt); Compositor().BeginFrame(); EXPECT_FLOAT_EQ(200.f, abs_pos->GetBoundingClientRect()->height()); EXPECT_FLOAT_EQ(200.f, fixed_pos->GetBoundingClientRect()->height()); EXPECT_EQ(400, GetDocument().GetFrame()->View()->GetLayoutSize().height()); // Unlock the controls, the sizes should change even though the controls are // still hidden. Compositor().LayerTreeHost()->UpdateBrowserControlsState( cc::BrowserControlsState::kBoth, cc::BrowserControlsState::kBoth, false, std::nullopt); Compositor().BeginFrame(); EXPECT_FLOAT_EQ(150.f, abs_pos->GetBoundingClientRect()->height()); EXPECT_FLOAT_EQ(200.f, fixed_pos->GetBoundingClientRect()->height()); EXPECT_EQ(300, GetDocument().GetFrame()->View()->GetLayoutSize().height()); // Now lock the controls in a shown state. Compositor().LayerTreeHost()->UpdateBrowserControlsState( cc::BrowserControlsState::kShown, cc::BrowserControlsState::kBoth, false, std::nullopt); WebView().ResizeWithBrowserControls(gfx::Size(400, 300), 100.f, 0, true); Compositor().BeginFrame(); EXPECT_FLOAT_EQ(150.f, abs_pos->GetBoundingClientRect()->height()); EXPECT_FLOAT_EQ(150.f, fixed_pos->GetBoundingClientRect()->height()); EXPECT_EQ(300, GetDocument().GetFrame()->View()->GetLayoutSize().height()); // Shown -> Hidden WebView().ResizeWithBrowserControls(gfx::Size(400, 400), 100.f, 0, false); Compositor().LayerTreeHost()->UpdateBrowserControlsState( cc::BrowserControlsState::kHidden, cc::BrowserControlsState::kBoth, false, std::nullopt); Compositor().BeginFrame(); EXPECT_FLOAT_EQ(200.f, abs_pos->GetBoundingClientRect()->height()); EXPECT_FLOAT_EQ(200.f, fixed_pos->GetBoundingClientRect()->height()); EXPECT_EQ(400, GetDocument().GetFrame()->View()->GetLayoutSize().height()); // Go from Unlocked and showing, to locked and hidden but issue the resize // before the constraint update to check for race issues. Compositor().LayerTreeHost()->UpdateBrowserControlsState( cc::BrowserControlsState::kBoth, cc::BrowserControlsState::kShown, false, std::nullopt); WebView().ResizeWithBrowserControls(gfx::Size(400, 300), 100.f, 0, true); Compositor().BeginFrame(); ASSERT_EQ(300, GetDocument().GetFrame()->View()->GetLayoutSize().height()); WebView().ResizeWithBrowserControls(gfx::Size(400, 400), 100.f, 0, false); Compositor().LayerTreeHost()->UpdateBrowserControlsState( cc::BrowserControlsState::kHidden, cc::BrowserControlsState::kHidden, false, std::nullopt); Compositor().BeginFrame(); EXPECT_FLOAT_EQ(200.f, abs_pos->GetBoundingClientRect()->height()); EXPECT_FLOAT_EQ(200.f, fixed_pos->GetBoundingClientRect()->height()); EXPECT_EQ(400, GetDocument().GetFrame()->View()->GetLayoutSize().height()); } // Ensure that browser controls affect layout of viewport constrained // position: sticky elements. TEST_F(BrowserControlsSimTest, MAYBE(AffectViewportConstrainedSticky)) { SimRequest request("https://example.com/test.html", "text/html"); LoadURL("https://example.com/test.html"); request.Complete(R"HTML(
)HTML"); Compositor().BeginFrame(); WebView().ResizeWithBrowserControls(gfx::Size(400, 300), 100.f, 0, true); Compositor().LayerTreeHost()->UpdateBrowserControlsState( cc::BrowserControlsState::kBoth, cc::BrowserControlsState::kShown, false, std::nullopt); Compositor().BeginFrame(); Element* sticky_pos = GetDocument().getElementById(WebString("sticky")); ASSERT_EQ(100.f, WebView().GetBrowserControls().ContentOffset()); ASSERT_EQ(300, GetDocument().GetFrame()->View()->GetLayoutSize().height()); EXPECT_FLOAT_EQ(300.f, sticky_pos->GetBoundingClientRect()->bottom()); // Hide the browser controls. VerticalScroll(-100.f); WebView().ResizeWithBrowserControls(gfx::Size(400, 400), 100.f, 0, false); Compositor().BeginFrame(); ASSERT_EQ(300, GetDocument().GetFrame()->View()->GetLayoutSize().height()); EXPECT_FLOAT_EQ(400.f, sticky_pos->GetBoundingClientRect()->bottom()); // Now lock the controls in a hidden state. The layout and elements should // resize without a WebView::resize. Compositor().LayerTreeHost()->UpdateBrowserControlsState( cc::BrowserControlsState::kHidden, cc::BrowserControlsState::kBoth, false, std::nullopt); Compositor().BeginFrame(); EXPECT_EQ(400, GetDocument().GetFrame()->View()->GetLayoutSize().height()); EXPECT_FLOAT_EQ(400.f, sticky_pos->GetBoundingClientRect()->bottom()); // Unlock the controls, the sizes should change even though the controls are // still hidden. Compositor().LayerTreeHost()->UpdateBrowserControlsState( cc::BrowserControlsState::kBoth, cc::BrowserControlsState::kBoth, false, std::nullopt); Compositor().BeginFrame(); EXPECT_EQ(300, GetDocument().GetFrame()->View()->GetLayoutSize().height()); EXPECT_FLOAT_EQ(400.f, sticky_pos->GetBoundingClientRect()->bottom()); // Now lock the controls in a shown state. Compositor().LayerTreeHost()->UpdateBrowserControlsState( cc::BrowserControlsState::kShown, cc::BrowserControlsState::kBoth, false, std::nullopt); WebView().ResizeWithBrowserControls(gfx::Size(400, 300), 100.f, 0, true); Compositor().BeginFrame(); EXPECT_EQ(300, GetDocument().GetFrame()->View()->GetLayoutSize().height()); EXPECT_FLOAT_EQ(300.f, sticky_pos->GetBoundingClientRect()->bottom()); } // Ensure that browser controls do not affect "static" viewport units // (vh, svh, lvh). TEST_P(BrowserControlsViewportUnitTest, MAYBE(DontAffectStaticUnits)) { auto param = GetParam(); SCOPED_TRACE(param.filename); // Initialize with the browser controls showing. WebViewImpl* web_view = Initialize(param.filename); web_view->GetPage()->GetChromeClient().SetBrowserControlsState(100.0f, 0.0f, true); web_view->GetBrowserControls().UpdateConstraintsAndState( cc::BrowserControlsState::kBoth, cc::BrowserControlsState::kShown); web_view->GetBrowserControls().SetShownRatio(1, 1); CompositeForTest(); ASSERT_EQ(100.f, web_view->GetBrowserControls().ContentOffset()); // Static '*vh' units should be based on the viewport when the browser // controls are hidden. Element* abs_pos = GetElementById(WebString("abs")); Element* fixed_pos = GetElementById(WebString("fixed")); EXPECT_FLOAT_EQ(param.height, abs_pos->GetBoundingClientRect()->height()); EXPECT_FLOAT_EQ(param.height, fixed_pos->GetBoundingClientRect()->height()); // The size used for viewport units should not be reduced by the top // controls. EXPECT_EQ(400, GetFrame()->View()->LargeViewportSizeForViewportUnits().height()); // Hide the browser controls. VerticalScroll(-100.f); web_view->GetPage()->GetChromeClient().SetBrowserControlsState(100.0f, 0.0f, false); UpdateAllLifecyclePhases(); ASSERT_EQ(0.f, web_view->GetBrowserControls().ContentOffset()); // Static *vh units should be static with respect to the browser controls so // neither
should change size as a result of the browser controls // hiding. EXPECT_FLOAT_EQ(param.height, abs_pos->GetBoundingClientRect()->height()); EXPECT_FLOAT_EQ(param.height, fixed_pos->GetBoundingClientRect()->height()); // The viewport size used for static *vh units should not change as a result // of top controls hiding. EXPECT_EQ(400, GetFrame()->View()->LargeViewportSizeForViewportUnits().height()); // Static *vw units should not change when scrollbar disappears. EXPECT_FLOAT_EQ(param.width, abs_pos->GetBoundingClientRect()->width()); EXPECT_FLOAT_EQ(param.width, fixed_pos->GetBoundingClientRect()->width()); Element* spacer = GetElementById(WebString("spacer")); ASSERT_TRUE(spacer); spacer->remove(); UpdateAllLifecyclePhases(); EXPECT_FLOAT_EQ(param.width, abs_pos->GetBoundingClientRect()->width()); EXPECT_FLOAT_EQ(param.width, fixed_pos->GetBoundingClientRect()->width()); } static ViewportUnitTestCase viewport_unit_test_cases[] = { {"v-size.html", 200.f, 200.f}, {"lv-size.html", 200.f, 200.f}, {"sv-size.html", 200.f, 150.f}, }; INSTANTIATE_TEST_SUITE_P(All, BrowserControlsViewportUnitTest, testing::ValuesIn(viewport_unit_test_cases)); // Ensure that browser controls *do* affect dvh units. TEST_F(BrowserControlsTest, MAYBE(DoAffectDVHUnits)) { // Initialize with the browser controls showing. WebViewImpl* web_view = Initialize("dv-size.html"); web_view->GetPage()->GetChromeClient().SetBrowserControlsState(100.0f, 0.0f, true); web_view->GetBrowserControls().UpdateConstraintsAndState( cc::BrowserControlsState::kBoth, cc::BrowserControlsState::kShown); web_view->GetBrowserControls().SetShownRatio(1, 1); CompositeForTest(); ASSERT_EQ(100.f, web_view->GetBrowserControls().ContentOffset()); // 'dvh' units should respond according to the current state of the controls. Element* abs_pos = GetElementById(WebString("abs")); Element* fixed_pos = GetElementById(WebString("fixed")); EXPECT_FLOAT_EQ(150.f, abs_pos->GetBoundingClientRect()->height()); EXPECT_FLOAT_EQ(150.f, fixed_pos->GetBoundingClientRect()->height()); // The size used for viewport units should not be reduced by the top // controls. EXPECT_EQ(300, GetFrame()->View()->DynamicViewportSizeForViewportUnits().height()); // Hide the browser controls. VerticalScroll(-100.f); web_view->GetPage()->GetChromeClient().SetBrowserControlsState(100.0f, 0.0f, false); UpdateAllLifecyclePhases(); ASSERT_EQ(0.f, web_view->GetBrowserControls().ContentOffset()); // dvh units should be dynamic with respect to the browser controls so both //
s should change size as a result of the browser controls hiding. EXPECT_FLOAT_EQ(200.f, abs_pos->GetBoundingClientRect()->height()); EXPECT_FLOAT_EQ(200.f, fixed_pos->GetBoundingClientRect()->height()); // The viewport size used for dvh units should change as a result of top // controls hiding. EXPECT_EQ(400, GetFrame()->View()->DynamicViewportSizeForViewportUnits().height()); // The viewport size used for dvh units should not change as a result of top // controls partially showing. ApplyViewportChangesArgs args; args.page_scale_delta = 1.f; args.is_pinch_gesture_active = false; args.top_controls_delta = 0.5f; args.bottom_controls_delta = 0.f; args.browser_controls_constraint = cc::BrowserControlsState::kBoth; args.scroll_gesture_did_end = false; web_view->ApplyViewportChanges(args); UpdateAllLifecyclePhases(); EXPECT_EQ(400, GetFrame()->View()->DynamicViewportSizeForViewportUnits().height()); // dvw units should not change when scrollbar disappears. EXPECT_FLOAT_EQ(200.f, abs_pos->GetBoundingClientRect()->width()); EXPECT_FLOAT_EQ(200.f, fixed_pos->GetBoundingClientRect()->width()); Element* spacer = GetElementById(WebString("spacer")); ASSERT_TRUE(spacer); spacer->remove(); UpdateAllLifecyclePhases(); EXPECT_FLOAT_EQ(200.f, abs_pos->GetBoundingClientRect()->width()); EXPECT_FLOAT_EQ(200.f, fixed_pos->GetBoundingClientRect()->width()); } // Ensure that on a legacy page (there's a non-1 minimum scale) 100vh units fill // the viewport, with browser controls hidden, when the viewport encompasses the // layout width. TEST_F(BrowserControlsTest, MAYBE(DontAffectVHUnitsWithScale)) { // Initialize with the browser controls showing. WebViewImpl* web_view = Initialize("vh-height-width-800.html"); web_view->ResizeWithBrowserControls(gfx::Size(400, 300), 100.f, 0, true); web_view->GetBrowserControls().UpdateConstraintsAndState( cc::BrowserControlsState::kBoth, cc::BrowserControlsState::kShown); web_view->GetBrowserControls().SetShownRatio(1, 1); CompositeForTest(); ASSERT_EQ(100.f, web_view->GetBrowserControls().ContentOffset()); // Device viewport is 400px but the page is width=800 so minimum-scale // should be 0.5. This is also the scale at which the viewport fills the // layout width. ASSERT_EQ(0.5f, web_view->MinimumPageScaleFactor()); // We should size vh units so that 100vh fills the viewport at min-scale so // we have to account for the minimum page scale factor. Since both boxes // are 50vh, and layout scale = 0.5, we have a vh viewport of 400 / 0.5 = 800 // so we expect 50vh to be 400px. Element* abs_pos = GetElementById(WebString("abs")); Element* fixed_pos = GetElementById(WebString("fixed")); EXPECT_FLOAT_EQ(400.f, abs_pos->GetBoundingClientRect()->height()); EXPECT_FLOAT_EQ(400.f, fixed_pos->GetBoundingClientRect()->height()); // The size used for viewport units should not be reduced by the top // controls. EXPECT_EQ(800, GetFrame()->View()->LargeViewportSizeForViewportUnits().height()); // Hide the browser controls. VerticalScroll(-100.f); web_view->ResizeWithBrowserControls(gfx::Size(400, 400), 100.f, 0, false); UpdateAllLifecyclePhases(); ASSERT_EQ(0.f, web_view->GetBrowserControls().ContentOffset()); // vh units should be static with respect to the browser controls so neighter //
should change size are a result of the browser controls hiding. EXPECT_FLOAT_EQ(400.f, abs_pos->GetBoundingClientRect()->height()); EXPECT_FLOAT_EQ(400.f, fixed_pos->GetBoundingClientRect()->height()); // The viewport size used for vh units should not change as a result of top // controls hiding. EXPECT_EQ(800, GetFrame()->View()->LargeViewportSizeForViewportUnits().height()); } // Ensure that on a legacy page (there's a non-1 minimum scale) whose viewport // at minimum-scale is larger than the layout size, 100vh units fill the // viewport, with browser controls hidden, when the viewport is scaled such that // its width equals the layout width. TEST_F(BrowserControlsTest, MAYBE(DontAffectVHUnitsUseLayoutSize)) { // Initialize with the browser controls showing. WebViewImpl* web_view = Initialize("vh-height-width-800-extra-wide.html"); web_view->ResizeWithBrowserControls(gfx::Size(400, 300), 100.f, 0, true); web_view->GetBrowserControls().UpdateConstraintsAndState( cc::BrowserControlsState::kBoth, cc::BrowserControlsState::kShown); web_view->GetBrowserControls().SetShownRatio(1, 1); UpdateAllLifecyclePhases(); ASSERT_EQ(100.f, web_view->GetBrowserControls().ContentOffset()); // Device viewport is 400px and page is width=800 but there's an element // that's 1600px wide so the minimum scale is 0.25 to encompass that. ASSERT_EQ(0.25f, web_view->MinimumPageScaleFactor()); // The viewport will match the layout width at scale=0.5 so the height used // for vh should be (300 / 0.5) for the layout height + (100 / 0.5) for top // controls = 800. EXPECT_EQ(800, GetFrame()->View()->LargeViewportSizeForViewportUnits().height()); } // Ensure that vh units are correctly calculated when a top controls min-height // is set. TEST_F(BrowserControlsTest, MAYBE(VHUnitsWithTopMinHeight)) { // Initialize with the browser controls showing. // Top controls height: 100, top controls min-height: 20. WebViewImpl* web_view = Initialize("v-size.html"); web_view->ResizeWithBrowserControls(gfx::Size(400, 300), gfx::Size(400, 300), {100, 20, 0, 0, false, true}); web_view->GetBrowserControls().UpdateConstraintsAndState( cc::BrowserControlsState::kBoth, cc::BrowserControlsState::kShown); web_view->GetBrowserControls().SetShownRatio(1, 1); CompositeForTest(); EXPECT_FLOAT_EQ(100.f, web_view->GetBrowserControls().ContentOffset()); // 'vh' units should be based on the viewport when the browser controls are // hidden. However, the viewport height will be limited by the min-height // since the top controls can't completely hide. Element* abs_pos = GetElementById(WebString("abs")); Element* fixed_pos = GetElementById(WebString("fixed")); float div_height = 0.5f * (300 + (100 - 20)); EXPECT_FLOAT_EQ(div_height, abs_pos->GetBoundingClientRect()->height()); EXPECT_FLOAT_EQ(div_height, fixed_pos->GetBoundingClientRect()->height()); // The size used for viewport units should be reduced by the top controls // min-height. EXPECT_EQ(380, GetFrame()->View()->LargeViewportSizeForViewportUnits().height()); // Scroll the top controls to hide. They won't scroll past the min-height. VerticalScroll(-100.f); web_view->ResizeWithBrowserControls(gfx::Size(400, 380), gfx::Size(400, 380), {100, 20, 0, 0, false, false}); UpdateAllLifecyclePhases(); EXPECT_FLOAT_EQ(20.f, web_view->GetBrowserControls().ContentOffset()); // vh units should be static with respect to the browser controls so neither //
should change size are a result of the browser controls hiding. EXPECT_FLOAT_EQ(190.f, abs_pos->GetBoundingClientRect()->height()); EXPECT_FLOAT_EQ(190.f, fixed_pos->GetBoundingClientRect()->height()); // The viewport size used for vh units should not change as a result of top // controls hiding. ASSERT_EQ(380, GetFrame()->View()->LargeViewportSizeForViewportUnits().height()); } // Ensure that vh units are correctly calculated when a bottom controls // min-height is set. TEST_F(BrowserControlsTest, MAYBE(VHUnitsWithBottomMinHeight)) { // Initialize with the browser controls showing. // Top controls height: 100, top controls min-height: 20. // Bottom controls height: 50, bottom controls min-height: 10. WebViewImpl* web_view = Initialize("v-size.html"); web_view->ResizeWithBrowserControls(gfx::Size(400, 250), gfx::Size(400, 250), {100, 20, 50, 10, false, true}); web_view->GetBrowserControls().UpdateConstraintsAndState( cc::BrowserControlsState::kBoth, cc::BrowserControlsState::kShown); web_view->GetBrowserControls().SetShownRatio(1, 1); CompositeForTest(); EXPECT_FLOAT_EQ(100.f, web_view->GetBrowserControls().ContentOffset()); // 'vh' units should be based on the viewport when the browser controls are // hidden. However, the viewport height will be limited by the min-height // since the top and bottom controls can't completely hide. Element* abs_pos = GetElementById(WebString("abs")); Element* fixed_pos = GetElementById(WebString("fixed")); float div_height = 0.5f * (250 + (100 - 20) + (50 - 10)); EXPECT_FLOAT_EQ(div_height, abs_pos->GetBoundingClientRect()->height()); EXPECT_FLOAT_EQ(div_height, fixed_pos->GetBoundingClientRect()->height()); // The size used for viewport units should be reduced by the top/bottom // controls min-height. EXPECT_EQ(370, GetFrame()->View()->LargeViewportSizeForViewportUnits().height()); // Scroll the controls to hide. They won't scroll past the min-height. VerticalScroll(-100.f); web_view->ResizeWithBrowserControls(gfx::Size(400, 370), gfx::Size(400, 370), {100, 20, 50, 10, false, false}); UpdateAllLifecyclePhases(); EXPECT_FLOAT_EQ(20.f, web_view->GetBrowserControls().ContentOffset()); EXPECT_FLOAT_EQ(10.f, web_view->GetBrowserControls().BottomContentOffset()); // vh units should be static with respect to the browser controls so neither //
should change size are a result of the browser controls hiding. EXPECT_FLOAT_EQ(185.f, abs_pos->GetBoundingClientRect()->height()); EXPECT_FLOAT_EQ(185.f, fixed_pos->GetBoundingClientRect()->height()); // The viewport size used for vh units should not change as a result of the // controls hiding. ASSERT_EQ(370, GetFrame()->View()->LargeViewportSizeForViewportUnits().height()); } // Ensure that vh units are correctly calculated with changing min-heights. TEST_F(BrowserControlsTest, MAYBE(VHUnitsWithMinHeightsChanging)) { // Initialize with the browser controls showing. // Top controls height: 100, top controls min-height: 20. // Bottom controls height: 50, bottom controls min-height: 10. WebViewImpl* web_view = Initialize("v-size.html"); web_view->ResizeWithBrowserControls(gfx::Size(400, 250), gfx::Size(400, 250), {100, 20, 50, 10, false, true}); web_view->GetBrowserControls().UpdateConstraintsAndState( cc::BrowserControlsState::kBoth, cc::BrowserControlsState::kShown); web_view->GetBrowserControls().SetShownRatio(1, 1); UpdateAllLifecyclePhases(); EXPECT_FLOAT_EQ(100.f, web_view->GetBrowserControls().ContentOffset()); // 'vh' units should be based on the viewport when the browser controls are // hidden. However, the viewport height will be limited by the min-height // since the top and bottom controls can't completely hide. Element* abs_pos = GetElementById(WebString("abs")); Element* fixed_pos = GetElementById(WebString("fixed")); float div_height = 0.5f * (250 + (100 - 20) + (50 - 10)); EXPECT_FLOAT_EQ(div_height, abs_pos->GetBoundingClientRect()->height()); EXPECT_FLOAT_EQ(div_height, fixed_pos->GetBoundingClientRect()->height()); // The size used for viewport units should be reduced by the top/bottom // controls min-height. EXPECT_EQ(370, GetFrame()->View()->LargeViewportSizeForViewportUnits().height()); // Make the min-heights 0. web_view->ResizeWithBrowserControls(gfx::Size(400, 250), gfx::Size(400, 250), {100, 0, 50, 0, false, true}); UpdateAllLifecyclePhases(); // The viewport size used for vh units should be updated to reflect the change // to the min-heights. float height = 250 + (100 - 0) + (50 - 0); ASSERT_EQ(height, GetFrame()->View()->LargeViewportSizeForViewportUnits().height()); } // This tests that the viewport remains anchored when browser controls are // brought in while the document is fully scrolled. This normally causes // clamping of the visual viewport to keep it bounded by the layout viewport // so we're testing that the viewport anchoring logic is working to keep the // view unchanged. TEST_F(BrowserControlsTest, MAYBE(AnchorViewportDuringBrowserControlsAdjustment)) { int content_height = 1016; int layout_viewport_height = 500; int visual_viewport_height = 500; int browser_controls_height = 100; int page_scale = 2; int min_scale = 1; // Initialize with the browser controls showing. WebViewImpl* web_view = Initialize("large-div.html"); GetWebView()->SetDefaultPageScaleLimits(min_scale, 5); web_view->ResizeWithBrowserControls(gfx::Size(800, layout_viewport_height), browser_controls_height, 0, true); web_view->GetBrowserControls().UpdateConstraintsAndState( cc::BrowserControlsState::kBoth, cc::BrowserControlsState::kShown); web_view->GetBrowserControls().SetShownRatio(1, 1); UpdateAllLifecyclePhases(); LocalFrameView* view = GetFrame()->View(); ScrollableArea* root_viewport = GetFrame()->View()->GetScrollableArea(); int expected_visual_offset = ((layout_viewport_height + browser_controls_height / min_scale) * page_scale - (visual_viewport_height + browser_controls_height)) / page_scale; int expected_layout_offset = content_height - (layout_viewport_height + browser_controls_height / min_scale); int expected_root_offset = expected_visual_offset + expected_layout_offset; // Zoom in to 2X and fully scroll both viewports. web_view->SetPageScaleFactor(page_scale); CompositeForTest(); { GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollBegin)); GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollUpdate, 0, -10000)); CompositeForTest(); ASSERT_EQ(0.f, web_view->GetBrowserControls().ContentOffset()); EXPECT_EQ(expected_visual_offset, GetVisualViewport().GetScrollOffset().y()); EXPECT_EQ(expected_layout_offset, view->LayoutViewport()->GetScrollOffset().y()); EXPECT_EQ(expected_root_offset, root_viewport->GetScrollOffset().y()); GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollEnd)); } // Commit the browser controls resize so that the browser controls do not // shrink the layout size. This should not have moved any of the viewports. web_view->ResizeWithBrowserControls( gfx::Size(800, layout_viewport_height + browser_controls_height), browser_controls_height, 0, false); UpdateAllLifecyclePhases(); ASSERT_EQ(expected_visual_offset, GetVisualViewport().GetScrollOffset().y()); ASSERT_EQ(expected_layout_offset, view->LayoutViewport()->GetScrollOffset().y()); ASSERT_EQ(expected_root_offset, root_viewport->GetScrollOffset().y()); // Now scroll back up just enough to show the browser controls. The browser // controls should shrink both viewports but the layout viewport by a greater // amount. This means the visual viewport's offset must be clamped to keep it // within the layout viewport. Make sure we adjust the scroll position to // account for this and keep the visual viewport at the same location relative // to the document (i.e. the user shouldn't see a movement). { GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollBegin)); GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollUpdate, 0, 80)); CompositeForTest(); GetVisualViewport().ClampToBoundaries(); view->LayoutViewport()->SetScrollOffset( view->LayoutViewport()->GetScrollOffset(), mojom::blink::ScrollType::kProgrammatic, cc::ScrollSourceType::kNone); ASSERT_EQ(80.f, web_view->GetBrowserControls().ContentOffset()); EXPECT_EQ(expected_root_offset, root_viewport->GetScrollOffset().y()); GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollEnd)); } } // Ensure that vh units are correct when browser controls are in a locked // state. That is, normally we need to add the browser controls height to vh // units since 100vh includes the browser controls even if they're hidden while // the ICB height does not. When the controls are locked hidden, the ICB size // is the full viewport height so there's no need to add the browser controls // height. crbug.com/688738. TEST_F(BrowserControlsSimTest, MAYBE(ViewportUnitsWhenControlsLocked)) { // Initialize with the browser controls showing. SimRequest request("https://example.com/test.html", "text/html"); LoadURL("https://example.com/test.html"); request.Complete(R"HTML(
)HTML"); WebView().ResizeWithBrowserControls(gfx::Size(400, 300), 100.f, 0, true); Compositor().LayerTreeHost()->UpdateBrowserControlsState( cc::BrowserControlsState::kBoth, cc::BrowserControlsState::kShown, false, std::nullopt); Compositor().BeginFrame(); ASSERT_EQ(1.f, WebView().GetBrowserControls().TopShownRatio()); ASSERT_EQ(100.f, WebView().GetBrowserControls().ContentOffset()); ASSERT_EQ(300, GetDocument().View()->GetLayoutSize().height()); Element* abs_pos = GetDocument().getElementById(AtomicString("abs")); Element* fixed_pos = GetDocument().getElementById(AtomicString("fixed")); // Lock the browser controls to hidden. { Compositor().LayerTreeHost()->UpdateBrowserControlsState( cc::BrowserControlsState::kHidden, cc::BrowserControlsState::kHidden, false, std::nullopt); WebView().ResizeWithBrowserControls(gfx::Size(400, 400), 100.f, 0, false); Compositor().BeginFrame(); ASSERT_EQ(0.f, WebView().GetBrowserControls().ContentOffset()); ASSERT_EQ(400, GetDocument().View()->GetLayoutSize().height()); // Make sure we're not adding the browser controls height to the vh units // as when they're locked to hidden, the ICB fills the entire viewport // already. EXPECT_FLOAT_EQ(200.f, abs_pos->GetBoundingClientRect()->height()); EXPECT_FLOAT_EQ(200.f, fixed_pos->GetBoundingClientRect()->height()); EXPECT_EQ( 400, GetDocument().View()->LargeViewportSizeForViewportUnits().height()); } // Lock the browser controls to shown. This should cause the vh units to // behave as usual by including the browser controls region in 100vh. { Compositor().LayerTreeHost()->UpdateBrowserControlsState( cc::BrowserControlsState::kShown, cc::BrowserControlsState::kShown, false, std::nullopt); WebView().ResizeWithBrowserControls(gfx::Size(400, 300), 100.f, 0, true); Compositor().BeginFrame(); ASSERT_EQ(100.f, WebView().GetBrowserControls().ContentOffset()); ASSERT_EQ(300, GetDocument().View()->GetLayoutSize().height()); // Make sure we're not adding the browser controls height to the vh units as // when they're locked to shown, the ICB fills the entire viewport already. EXPECT_FLOAT_EQ(150.f, abs_pos->GetBoundingClientRect()->height()); EXPECT_FLOAT_EQ(150.f, fixed_pos->GetBoundingClientRect()->height()); EXPECT_EQ( 400, GetDocument().View()->LargeViewportSizeForViewportUnits().height()); } } // Test the size adjustment sent to the viewport when top controls exist. TEST_F(BrowserControlsTest, MAYBE(TopControlsSizeAdjustment)) { WebViewImpl* web_view = Initialize(); web_view->ResizeWithBrowserControls(web_view->MainFrameViewWidget()->Size(), 50.f, 0, false); web_view->GetBrowserControls().SetShownRatio(1, 0.0); EXPECT_FLOAT_EQ(-50.f, web_view->GetBrowserControls().UnreportedSizeAdjustment()); web_view->GetBrowserControls().SetShownRatio(0.5, 0.0); EXPECT_FLOAT_EQ(-25.f, web_view->GetBrowserControls().UnreportedSizeAdjustment()); web_view->GetBrowserControls().SetShownRatio(0.0, 0.0); EXPECT_FLOAT_EQ(0.f, web_view->GetBrowserControls().UnreportedSizeAdjustment()); } // Test the size adjustment sent to the viewport when bottom controls exist. // There should never be an adjustment since the bottom controls do not change // the content offset. TEST_F(BrowserControlsTest, MAYBE(BottomControlsSizeAdjustment)) { WebViewImpl* web_view = Initialize(); web_view->ResizeWithBrowserControls(web_view->MainFrameViewWidget()->Size(), 0, 50.f, false); web_view->GetBrowserControls().SetShownRatio(0.0, 1); EXPECT_FLOAT_EQ(0.f, web_view->GetBrowserControls().UnreportedSizeAdjustment()); web_view->GetBrowserControls().SetShownRatio(0.0, 0.5); EXPECT_FLOAT_EQ(0.f, web_view->GetBrowserControls().UnreportedSizeAdjustment()); web_view->GetBrowserControls().SetShownRatio(0.0, 0.0); EXPECT_FLOAT_EQ(0.f, web_view->GetBrowserControls().UnreportedSizeAdjustment()); } TEST_F(BrowserControlsTest, MAYBE(TopControlsMinHeightNoSizeAdjustment)) { WebViewImpl* web_view = Initialize(); gfx::Size viewport_size = web_view->MainFrameViewWidget()->Size(); cc::BrowserControlsParams params; params.top_controls_height = 50.f; params.top_controls_min_height = 50.f; params.browser_controls_shrink_blink_size = false; web_view->ResizeWithBrowserControls(viewport_size, viewport_size, params); web_view->GetBrowserControls().SetShownRatio(/* top_ratio */ 1, /* bottom_ratio */ 0); // With top controls shown and height == min_height, there should be no size // adjustment, even with browser_controls_shrink_blink_size == false. EXPECT_FLOAT_EQ(0.f, web_view->GetBrowserControls().UnreportedSizeAdjustment()); EXPECT_FLOAT_EQ(0.f, GetVisualViewport().MaximumScrollOffset().y()); } TEST_F(BrowserControlsTest, MAYBE(GrowingHeightKeepsTopControlsHidden)) { WebViewImpl* web_view = Initialize(); float bottom_height = web_view->GetBrowserControls().BottomHeight(); web_view->ResizeWithBrowserControls(web_view->MainFrameViewWidget()->Size(), 1.f, bottom_height, false); web_view->GetBrowserControls().UpdateConstraintsAndState( cc::BrowserControlsState::kHidden, cc::BrowserControlsState::kHidden); // As we expand the top controls height while hidden, the content offset // shouldn't change. EXPECT_EQ(0.f, web_view->GetBrowserControls().ContentOffset()); web_view->ResizeWithBrowserControls(web_view->MainFrameViewWidget()->Size(), 50.f, bottom_height, false); EXPECT_EQ(0.f, web_view->GetBrowserControls().ContentOffset()); web_view->ResizeWithBrowserControls(web_view->MainFrameViewWidget()->Size(), 100.f, bottom_height, false); EXPECT_EQ(0.f, web_view->GetBrowserControls().ContentOffset()); } TEST_F(BrowserControlsTest, MAYBE(HidingBrowserControlsInvalidatesCompositedLayer)) { // Initialize with the browser controls showing. WebViewImpl* web_view = Initialize("95-vh.html"); web_view->ResizeWithBrowserControls(gfx::Size(412, 604), 56.f, 0, true); web_view->GetBrowserControls().SetShownRatio(1, 1); UpdateAllLifecyclePhases(); GetFrame()->View()->SetTracksRasterInvalidations(true); // Hide the browser controls. VerticalScroll(-100.f); web_view->ResizeWithBrowserControls(gfx::Size(412, 660), 56.f, 0, false); UpdateAllLifecyclePhases(); // Ensure there is a raster invalidation of the bottom of the layer. const auto& raster_invalidations = GetRasterInvalidationTracking(*GetFrame()->View())->Invalidations(); EXPECT_EQ(1u, raster_invalidations.size()); EXPECT_EQ(gfx::Rect(0, 643, 412, 17), raster_invalidations[0].rect); EXPECT_EQ(PaintInvalidationReason::kIncremental, raster_invalidations[0].reason); GetFrame()->View()->SetTracksRasterInvalidations(false); } // Test that the browser controls have different shown ratios when scrolled with // a minimum height set for only top controls. TEST_F(BrowserControlsTest, MAYBE(ScrollWithMinHeightSetForTopControlsOnly)) { WebViewImpl* web_view = Initialize(); float top_height = 56; float bottom_height = 50; web_view->ResizeWithBrowserControls(web_view->MainFrameViewWidget()->Size(), top_height, bottom_height, false); web_view->GetBrowserControls().SetShownRatio(1.f, 1.f); web_view->GetBrowserControls().SetParams( {top_height, 20, bottom_height, 0, false, true}); CompositeForTest(); // Scroll down to hide the controls. GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollBegin)); GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollUpdate, 0, -100)); CompositeForTest(); // The bottom controls should be completely hidden while the top controls are // at the minimum height. EXPECT_EQ(0.f, web_view->GetBrowserControls().BottomShownRatio()); EXPECT_GT(web_view->GetBrowserControls().TopShownRatio(), 0); EXPECT_EQ(20, web_view->GetBrowserControls().ContentOffset()); // Scrolling back up should bring the browser controls shown ratios back to 1. GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollUpdate, 0, 100)); CompositeForTest(); EXPECT_EQ(1.f, web_view->GetBrowserControls().BottomShownRatio()); EXPECT_EQ(1.f, web_view->GetBrowserControls().TopShownRatio()); EXPECT_EQ(top_height, web_view->GetBrowserControls().ContentOffset()); } // Test that the browser controls don't scroll off when a minimum height is set. TEST_F(BrowserControlsTest, MAYBE(ScrollWithMinHeightSet)) { WebViewImpl* web_view = Initialize(); float top_height = 56; float bottom_height = 50; web_view->ResizeWithBrowserControls(web_view->MainFrameViewWidget()->Size(), top_height, bottom_height, false); web_view->GetBrowserControls().SetShownRatio(1.f, 1.f); web_view->GetBrowserControls().SetParams( {top_height, 20, bottom_height, 10, false, true}); CompositeForTest(); GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollBegin)); GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollUpdate, 0, -100)); GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollEnd)); CompositeForTest(); // Browser controls don't scroll off completely, and stop scrolling at the min // height. EXPECT_FLOAT_EQ(20, web_view->GetBrowserControls().ContentOffset()); EXPECT_FLOAT_EQ(10, web_view->GetBrowserControls().BottomContentOffset()); // Ending the scroll then scrolling again shouldn't make any difference. GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollBegin)); GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollUpdate, 0, -50)); GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollEnd)); CompositeForTest(); EXPECT_FLOAT_EQ(20, web_view->GetBrowserControls().ContentOffset()); EXPECT_FLOAT_EQ(10, web_view->GetBrowserControls().BottomContentOffset()); // Finally, scroll back up to show the controls completely. GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollBegin)); GetWebFrameWidget()->DispatchThroughCcInputHandler( GenerateEvent(WebInputEvent::Type::kGestureScrollUpdate, 0, 100)); CompositeForTest(); EXPECT_FLOAT_EQ(top_height, web_view->GetBrowserControls().ContentOffset()); EXPECT_FLOAT_EQ(bottom_height, web_view->GetBrowserControls().BottomContentOffset()); } #undef MAYBE // Test that sending both an animated and non-animated browser control update // doesn't cause the animated one to squash the non-animated. // https://crbug.com/861618. TEST_F(BrowserControlsSimTest, MixAnimatedAndNonAnimatedUpdateState) { SimRequest request("https://example.com/test.html", "text/html"); LoadURL("https://example.com/test.html"); request.Complete(R"HTML( )HTML"); Compositor().BeginFrame(); ASSERT_EQ(1.f, WebView().GetBrowserControls().TopShownRatio()); // Kick off a non-animated clamp to hide the top controls. Compositor().LayerTreeHost()->UpdateBrowserControlsState( cc::BrowserControlsState::kHidden, cc::BrowserControlsState::kBoth, false /* animated */, std::nullopt); // Now kick off an animated one to do the same thing. Compositor().LayerTreeHost()->UpdateBrowserControlsState( cc::BrowserControlsState::kHidden, cc::BrowserControlsState::kBoth, true /* animated */, std::nullopt); // Advance time. In https://crbug.com/861618, the animation didn't realize // yet we're already at 0, so it would play the compositor-side up to 80ms, // somewhere mid-way hidden. Later on in this BeginFrame the changes from the // main thread are committed so the top controls shown ratio will set to 0. Compositor().BeginFrame(0.080); EXPECT_EQ(0.f, WebView().GetBrowserControls().TopShownRatio()); // Tick the animation again. The animation should have been stopped. In // https://crbug.com/861618, the animation would continue to play since it // was kicked off after the non-animated call as far as the compositor could // see. This means this animation tick would set the delta to some non-0 value // again. This value will be committed to the main thread causing the controls // to show. Compositor().BeginFrame(); EXPECT_EQ(0.f, WebView().GetBrowserControls().TopShownRatio()); } // Test that requesting an animated hide on the top controls actually // animates rather than happening instantly. TEST_F(BrowserControlsSimTest, HideAnimated) { SimRequest request("https://example.com/test.html", "text/html"); LoadURL("https://example.com/test.html"); request.Complete(R"HTML( )HTML"); Compositor().BeginFrame(); ASSERT_EQ(1.f, WebView().GetBrowserControls().TopShownRatio()); ASSERT_EQ(1.f, WebView().GetBrowserControls().BottomShownRatio()); // Kick off an animated hide. Compositor().LayerTreeHost()->UpdateBrowserControlsState( cc::BrowserControlsState::kBoth, cc::BrowserControlsState::kHidden, true /* animated */, std::nullopt); Compositor().BeginFrame(); ASSERT_EQ(1.f, WebView().GetBrowserControls().TopShownRatio()); ASSERT_EQ(1.f, WebView().GetBrowserControls().BottomShownRatio()); // Advance time. Compositor().BeginFrame(0.080); EXPECT_NE(0.f, WebView().GetBrowserControls().TopShownRatio()); EXPECT_NE(1.f, WebView().GetBrowserControls().TopShownRatio()); EXPECT_EQ(WebView().GetBrowserControls().TopShownRatio(), WebView().GetBrowserControls().BottomShownRatio()); } // Test that requesting an animated show on the top controls actually // animates rather than happening instantly. TEST_F(BrowserControlsSimTest, ShowAnimated) { SimRequest request("https://example.com/test.html", "text/html"); LoadURL("https://example.com/test.html"); request.Complete(R"HTML( )HTML"); Compositor().BeginFrame(); Compositor().LayerTreeHost()->UpdateBrowserControlsState( cc::BrowserControlsState::kBoth, cc::BrowserControlsState::kHidden, false, std::nullopt); Compositor().BeginFrame(); ASSERT_EQ(0.f, WebView().GetBrowserControls().TopShownRatio()); ASSERT_EQ(0.f, WebView().GetBrowserControls().BottomShownRatio()); // Kick off an animated show. Compositor().LayerTreeHost()->UpdateBrowserControlsState( cc::BrowserControlsState::kBoth, cc::BrowserControlsState::kShown, true /* animated */, std::nullopt); Compositor().BeginFrame(); ASSERT_EQ(0.f, WebView().GetBrowserControls().TopShownRatio()); ASSERT_EQ(0.f, WebView().GetBrowserControls().BottomShownRatio()); // Advance time. Compositor().BeginFrame(0.080); EXPECT_NE(0.f, WebView().GetBrowserControls().TopShownRatio()); EXPECT_NE(1.f, WebView().GetBrowserControls().TopShownRatio()); // The bottom controls shown ratio should follow the top controls. EXPECT_EQ(WebView().GetBrowserControls().TopShownRatio(), WebView().GetBrowserControls().BottomShownRatio()); } // Test that setting a constraint inside Blink doesn't clamp the ratio to the // constraint. This is required since the CC-side will set the ratio correctly. // If we did clamp the ratio, an animation running in CC would get clobbered // when we commit. TEST_F(BrowserControlsSimTest, ConstraintDoesntClampRatioInBlink) { SimRequest request("https://example.com/test.html", "text/html"); LoadURL("https://example.com/test.html"); request.Complete(R"HTML( )HTML"); Compositor().BeginFrame(); ASSERT_EQ(1.f, WebView().GetBrowserControls().TopShownRatio()); ASSERT_EQ(1.f, WebView().GetBrowserControls().BottomShownRatio()); { // Pass a hidden constraint to Blink (without going through CC). Make sure // the shown ratio doesn't change since CC is responsible for updating the // ratio. WebView().GetBrowserControls().UpdateConstraintsAndState( cc::BrowserControlsState::kHidden, cc::BrowserControlsState::kBoth); EXPECT_EQ(1.f, WebView().GetBrowserControls().TopShownRatio()); EXPECT_EQ(1.f, WebView().GetBrowserControls().BottomShownRatio()); WebView().GetBrowserControls().UpdateConstraintsAndState( cc::BrowserControlsState::kHidden, cc::BrowserControlsState::kBoth); EXPECT_EQ(1.f, WebView().GetBrowserControls().TopShownRatio()); EXPECT_EQ(1.f, WebView().GetBrowserControls().BottomShownRatio()); // Constrain the controls to hidden from the compositor. This should // actually cause the controls to hide when we commit. Compositor().LayerTreeHost()->UpdateBrowserControlsState( cc::BrowserControlsState::kBoth, cc::BrowserControlsState::kHidden, false /* animated */, std::nullopt); Compositor().BeginFrame(); EXPECT_EQ(0.f, WebView().GetBrowserControls().TopShownRatio()); EXPECT_EQ(0.f, WebView().GetBrowserControls().BottomShownRatio()); } { // Pass a shown constraint to Blink (without going through CC). Make sure // the shown ratio doesn't change. WebView().GetBrowserControls().UpdateConstraintsAndState( cc::BrowserControlsState::kShown, cc::BrowserControlsState::kBoth); EXPECT_EQ(0.f, WebView().GetBrowserControls().TopShownRatio()); EXPECT_EQ(0.f, WebView().GetBrowserControls().BottomShownRatio()); WebView().GetBrowserControls().UpdateConstraintsAndState( cc::BrowserControlsState::kShown, cc::BrowserControlsState::kBoth); EXPECT_EQ(0.f, WebView().GetBrowserControls().TopShownRatio()); EXPECT_EQ(0.f, WebView().GetBrowserControls().BottomShownRatio()); // Constrain the controls to hidden from the compositor. This should // actually cause the controls to hide when we commit. Compositor().LayerTreeHost()->UpdateBrowserControlsState( cc::BrowserControlsState::kBoth, cc::BrowserControlsState::kShown, false /* animated */, std::nullopt); Compositor().BeginFrame(); EXPECT_EQ(1.f, WebView().GetBrowserControls().TopShownRatio()); EXPECT_EQ(1.f, WebView().GetBrowserControls().BottomShownRatio()); } } } // namespace blink