// Copyright 2014 The Chromium Authors // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. #import "ios/chrome/browser/autofill/model/form_suggestion_controller.h" #import #import "base/test/scoped_feature_list.h" #import "components/autofill/core/browser/filling/filling_product.h" #import "components/autofill/core/browser/ui/mock_autofill_suggestion_delegate.h" #import "components/autofill/ios/browser/form_suggestion.h" #import "components/autofill/ios/browser/form_suggestion_provider.h" #import "components/autofill/ios/form_util/form_activity_params.h" #import "components/autofill/ios/form_util/test_form_activity_tab_helper.h" #import "ios/chrome/browser/autofill/form_input_accessory/coordinator/form_input_accessory_mediator.h" #import "ios/chrome/browser/autofill/form_input_accessory/coordinator/form_input_accessory_mediator_handler.h" #import "ios/chrome/browser/autofill/form_input_accessory/ui/form_input_accessory_consumer.h" #import "ios/chrome/browser/autofill/model/features.h" #import "ios/chrome/test/ios_chrome_scoped_testing_local_state.h" #import "ios/web/public/test/fakes/fake_web_frame.h" #import "ios/web/public/test/fakes/fake_web_state.h" #import "ios/web/public/test/web_task_environment.h" #import "testing/gtest_mac.h" #import "testing/platform_test.h" #import "third_party/ocmock/OCMock/OCMock.h" #import "third_party/ocmock/gtest_support.h" using autofill::FieldRendererId; using autofill::FillingProduct; using autofill::FormRendererId; using ActivityType = autofill::FormActivityParams::ActivityType; using FieldType = autofill::FormActivityParams::FieldType; // Test provider that records invocations of its interface methods. @interface TestSuggestionProvider : NSObject @property(weak, nonatomic, readonly) FormSuggestion* suggestion; @property(nonatomic, assign) NSInteger index; @property(weak, nonatomic, readonly) NSString* formName; @property(weak, nonatomic, readonly) NSString* fieldIdentifier; @property(weak, nonatomic, readonly) NSString* frameID; @property(nonatomic, assign) BOOL selected; @property(nonatomic, assign) BOOL askedIfSuggestionsAvailable; @property(nonatomic, assign) BOOL askedForSuggestions; @property(nonatomic, assign) SuggestionProviderType type; @property(nonatomic, readonly) FillingProduct mainFillingProduct; // The number of times the selected provider was asked for suggestions when // handling a request. @property(nonatomic, assign) int askForSuggestionsCount; // Creates a test provider with default suggesstions. + (instancetype)providerWithSuggestions; - (instancetype)initWithSuggestions:(NSArray*)suggestions; @end @implementation TestSuggestionProvider { NSArray* _suggestions; NSString* _formName; FormRendererId _formRendererID; NSString* _fieldIdentifier; FieldRendererId _fieldRendererID; NSString* _frameID; FormSuggestion* _suggestion; } @synthesize selected = _selected; @synthesize askedIfSuggestionsAvailable = _askedIfSuggestionsAvailable; @synthesize askedForSuggestions = _askedForSuggestions; + (instancetype)providerWithSuggestions { NSArray* suggestions = @[ [FormSuggestion suggestionWithValue:@"foo" displayDescription:nil icon:nil type:autofill::SuggestionType::kAutocompleteEntry payload:autofill::Suggestion::Payload() requiresReauth:NO], [FormSuggestion suggestionWithValue:@"bar" displayDescription:nil icon:nil type:autofill::SuggestionType::kAddressEntry payload:autofill::Suggestion::Payload() requiresReauth:NO] ]; return [[TestSuggestionProvider alloc] initWithSuggestions:suggestions]; } - (instancetype)initWithSuggestions:(NSArray*)suggestions { self = [super init]; if (self) { _suggestions = [suggestions copy]; _type = SuggestionProviderTypeUnknown; } return self; } - (NSString*)formName { return _formName; } - (NSString*)fieldIdentifier { return _fieldIdentifier; } - (NSString*)frameID { return _frameID; } - (FormSuggestion*)suggestion { return _suggestion; } - (void)setSuggestions:(NSArray*)suggestions { _suggestions = [suggestions copy]; } - (void)checkIfSuggestionsAvailableForForm: (FormSuggestionProviderQuery*)formQuery hasUserGesture:(BOOL)hasUserGesture webState:(web::WebState*)webState completionHandler: (SuggestionsAvailableCompletion)completion { self.askedIfSuggestionsAvailable = YES; completion([_suggestions count] > 0); } - (void)retrieveSuggestionsForForm:(FormSuggestionProviderQuery*)formQuery webState:(web::WebState*)webState completionHandler:(SuggestionsReadyCompletion)completion { self.askedForSuggestions = YES; ++_askForSuggestionsCount; completion(_suggestions, self); } - (void)didSelectSuggestion:(FormSuggestion*)suggestion atIndex:(NSInteger)index form:(NSString*)formName formRendererID:(FormRendererId)formRendererID fieldIdentifier:(NSString*)fieldIdentifier fieldRendererID:(FieldRendererId)fieldRendererID frameID:(NSString*)frameID completionHandler:(SuggestionHandledCompletion)completion { self.selected = YES; _suggestion = suggestion; _index = index; _formName = [formName copy]; _formRendererID = formRendererID; _fieldIdentifier = [fieldIdentifier copy]; _fieldRendererID = fieldRendererID; _frameID = [frameID copy]; completion(); } @end @interface AsyncTestSuggestionProvider : TestSuggestionProvider // Returns the number of concurrent requests that are currently pending. @property(nonatomic, assign) int pendingRequestsCount; + (instancetype)providerWithSuggestions; @end @implementation AsyncTestSuggestionProvider + (instancetype)providerWithSuggestions { NSArray* suggestions = @[ [FormSuggestion suggestionWithValue:@"foo" displayDescription:nil icon:nil type:autofill::SuggestionType::kAutocompleteEntry payload:autofill::Suggestion::Payload() requiresReauth:NO], [FormSuggestion suggestionWithValue:@"bar" displayDescription:nil icon:nil type:autofill::SuggestionType::kAddressEntry payload:autofill::Suggestion::Payload() requiresReauth:NO] ]; return [[AsyncTestSuggestionProvider alloc] initWithSuggestions:suggestions]; } #pragma mark - TestSuggestionProvider - (instancetype)initWithSuggestions:(NSArray*)suggestions { self = [super initWithSuggestions:suggestions]; if (self) { _pendingRequestsCount = 0; } return self; } - (void)checkIfSuggestionsAvailableForForm: (FormSuggestionProviderQuery*)formQuery hasUserGesture:(BOOL)hasUserGesture webState:(web::WebState*)webState completionHandler: (SuggestionsAvailableCompletion)completion { ++self.pendingRequestsCount; __weak __typeof(self) weakSelf = self; base::SequencedTaskRunner::GetCurrentDefault()->PostTask( FROM_HERE, base::BindOnce(^{ [weakSelf checkIfSuggestionsAvailableForFormSuper:formQuery hasUserGesture:hasUserGesture webState:webState completionHandler:completion]; --weakSelf.pendingRequestsCount; })); } #pragma mark - Private // Wrapper around -checkIfSuggestionsAvailableForForm to call the -check // from super when done from a completion block. - (void)checkIfSuggestionsAvailableForFormSuper: (FormSuggestionProviderQuery*)formQuery hasUserGesture:(BOOL)hasUserGesture webState:(web::WebState*)webState completionHandler: (SuggestionsAvailableCompletion)completion { [super checkIfSuggestionsAvailableForForm:formQuery hasUserGesture:hasUserGesture webState:webState completionHandler:completion]; } @end namespace { // Test fixture for FormSuggestionController testing. class FormSuggestionControllerTest : public PlatformTest, public ::testing::WithParamInterface { public: FormSuggestionControllerTest() : test_form_activity_tab_helper_(&fake_web_state_) {} FormSuggestionControllerTest(const FormSuggestionControllerTest&) = delete; FormSuggestionControllerTest& operator=(const FormSuggestionControllerTest&) = delete; void SetUp() override { PlatformTest::SetUp(); if (!IsStateless()) { scoped_feature_list_.InitAndDisableFeature( kStatelessFormSuggestionController); } fake_web_state_.SetWebViewProxy(mock_web_view_proxy_); } void TearDown() override { [accessory_mediator_ disconnect]; [suggestion_controller_ detachFromWebState]; PlatformTest::TearDown(); } protected: // Sets up `suggestion_controller_` with the specified array of // FormSuggestionProviders. void SetUpController(NSArray* providers) { suggestion_controller_ = [[FormSuggestionController alloc] initWithWebState:&fake_web_state_ providers:providers]; [suggestion_controller_ setWebViewProxy:mock_web_view_proxy_]; id mock_consumer = [OCMockObject niceMockForProtocol:@protocol(FormInputAccessoryConsumer)]; // Mock the consumer to verify the suggestion views. OCMStub([mock_consumer showAccessorySuggestions:[OCMArg checkWithBlock:^BOOL( NSArray* suggestions) { received_suggestions_ = suggestions; return YES; }]]); id mock_window = OCMClassMock([UIWindow class]); id mock_web_state_view = OCMClassMock([UIView class]); OCMStub([mock_web_state_view window]).andReturn(mock_window); fake_web_state_.SetView(mock_web_state_view); mock_handler_ = [OCMockObject niceMockForProtocol:@protocol(FormInputAccessoryMediatorHandler)]; accessory_mediator_ = [[FormInputAccessoryMediator alloc] initWithConsumer:mock_consumer handler:mock_handler_ webStateList:nullptr personalDataManager:nullptr profilePasswordStore:nullptr accountPasswordStore:nullptr securityAlertHandler:nil reauthenticationModule:nil engagementTracker:nil]; [accessory_mediator_ injectWebState:&fake_web_state_]; [accessory_mediator_ injectProvider:suggestion_controller_]; } bool IsStateless() { return GetParam(); } // Returns true if suggestions were actually received by the consumer. bool SuggestionsReceived() { return received_suggestions_; } // The scoped feature list to enable/disable features. This needs to be placed // before task_environment_, as per // https://source.chromium.org/chromium/chromium/src/+/main:base/test/scoped_feature_list.h;l=37-41;drc=fe05104cfedb627fa99f218d7d1af6862871566c. base::test::ScopedFeatureList scoped_feature_list_; // The associated test Web Threads. web::WebTaskEnvironment task_environment_; // Installs the local state in ApplicationContext. IOSChromeScopedTestingLocalState scoped_testing_local_state_; // The FormSuggestionController under test. FormSuggestionController* suggestion_controller_; // The suggestions the controller sent to the client, if any. NSArray* received_suggestions_ = nil; // Mock CRWWebViewProxy used by the controller and accessory mediator. id mock_web_view_proxy_; // Accessory view controller. FormInputAccessoryMediator* accessory_mediator_; // The fake WebState to simulate navigation and JavaScript events. web::FakeWebState fake_web_state_; // The fake form tracker to simulate form events. autofill::TestFormActivityTabHelper test_form_activity_tab_helper_; // Mock FormInputAccessoryMediatorHandler used by the accessory mediator. id mock_handler_; }; // Tests that no suggestions are displayed when no providers are registered. TEST_P(FormSuggestionControllerTest, FormActivityShouldRetrieveSuggestions_NoProvidersAvailable) { // Set up the controller without any providers. SetUpController(@[]); GURL url("http://foo.com"); fake_web_state_.SetCurrentURL(url); auto main_frame = web::FakeWebFrame::CreateMainWebFrame(url); autofill::FormActivityParams params; params.form_name = "form"; params.field_identifier = "field_id"; params.field_type = FieldType::kText; params.type = ActivityType::kFocus; params.value = "value"; params.input_missing = false; test_form_activity_tab_helper_.FormActivityRegistered(main_frame.get(), params); // The suggestions should be empty. EXPECT_TRUE(received_suggestions_); EXPECT_EQ(0U, received_suggestions_.count); } // Tests that, when no providers have suggestions to offer for a form/field, // they aren't asked and no suggestions are displayed. TEST_P(FormSuggestionControllerTest, FormActivityShouldRetrieveSuggestions_NoSuggestionsAvailable) { // Set up the controller with some providers, but none of them will // have suggestions available. TestSuggestionProvider* provider1 = [[TestSuggestionProvider alloc] initWithSuggestions:@[]]; TestSuggestionProvider* provider2 = [[TestSuggestionProvider alloc] initWithSuggestions:@[]]; SetUpController(@[ provider1, provider2 ]); GURL url("http://foo.com"); fake_web_state_.SetCurrentURL(url); auto main_frame = web::FakeWebFrame::CreateMainWebFrame(url); autofill::FormActivityParams params; params.form_name = "form"; params.field_identifier = "field_id"; params.field_type = FieldType::kText; params.type = ActivityType::kFocus; params.value = "value"; params.input_missing = false; test_form_activity_tab_helper_.FormActivityRegistered(main_frame.get(), params); // The providers should each be asked if they have suggestions for the // form in question. EXPECT_TRUE([provider1 askedIfSuggestionsAvailable]); EXPECT_TRUE([provider2 askedIfSuggestionsAvailable]); // Since none of the providers had suggestions available, none of them // should have been asked for suggestions. EXPECT_FALSE([provider1 askedForSuggestions]); EXPECT_FALSE([provider2 askedForSuggestions]); // Verify that the suggestions were set from the completion block call, even // if no suggestions are available. ASSERT_TRUE(SuggestionsReceived()); // The suggestions should be empty. EXPECT_FALSE(received_suggestions_.count); EXPECT_EQ(0U, received_suggestions_.count); } // Tests that concurrent requests can be handled when no suggestions are // offered. TEST_P( FormSuggestionControllerTest, FormActivityShouldRetrieveSuggestions_NoSuggestionsAvailable_Concurrency) { // Set up the controller with some providers, but none of them will // have suggestions available. AsyncTestSuggestionProvider* provider = [[AsyncTestSuggestionProvider alloc] initWithSuggestions:@[]]; SetUpController(@[ provider ]); GURL url("http://foo.com"); fake_web_state_.SetCurrentURL(url); auto main_frame = web::FakeWebFrame::CreateMainWebFrame(url); autofill::FormActivityParams params; params.form_name = "form"; params.field_identifier = "field_id"; params.field_type = FieldType::kText; params.type = ActivityType::kFocus; params.value = "value"; params.input_missing = false; // Register 2 subsequent form activities so there are 2 concurrent requests. test_form_activity_tab_helper_.FormActivityRegistered(main_frame.get(), params); test_form_activity_tab_helper_.FormActivityRegistered(main_frame.get(), params); ASSERT_EQ(2, provider.pendingRequestsCount); // Run the async requests that were dispatched. base::RunLoop().RunUntilIdle(); ASSERT_EQ(0, provider.pendingRequestsCount); // Verify that the suggestions were set from the completion block call, even // if no suggestions are available. ASSERT_TRUE(SuggestionsReceived()); // The suggestions should be empty. EXPECT_FALSE(received_suggestions_.count); EXPECT_EQ(0U, received_suggestions_.count); } // Tests that, once a provider is asked if it has suggestions for a form/field, // it and only it is asked to provide them, and that suggestions are then sent. TEST_P(FormSuggestionControllerTest, FormActivityShouldRetrieveSuggestions_SuggestionsAddedToAccessoryView) { autofill::FormActivityParams params; params.form_name = "form"; params.field_identifier = "field_id"; params.field_type = FieldType::kText; params.type = ActivityType::kFocus; params.value = "value"; params.input_missing = false; TestSuggestionProvider* provider1 = [[TestSuggestionProvider alloc] initWithSuggestions:@[]]; // Set up the controller with some providers, one of which can provide // suggestions. NSArray* provider1Suggestions = @[ [FormSuggestion copy:[FormSuggestion suggestionWithValue:@"foo" displayDescription:nil icon:nil type:autofill::SuggestionType:: kAutocompleteEntry payload:autofill::Suggestion::Payload() requiresReauth:NO] andSetParams:params provider:provider1], [FormSuggestion copy:[FormSuggestion suggestionWithValue:@"bar" displayDescription:nil icon:nil type:autofill::SuggestionType:: kAddressEntry payload:autofill::Suggestion::Payload() requiresReauth:NO] andSetParams:params provider:provider1] ]; [provider1 setSuggestions:provider1Suggestions]; TestSuggestionProvider* provider2 = [[TestSuggestionProvider alloc] initWithSuggestions:@[]]; SetUpController(@[ provider1, provider2 ]); GURL url("http://foo.com"); fake_web_state_.SetCurrentURL(url); auto main_frame = web::FakeWebFrame::CreateMainWebFrame(url); test_form_activity_tab_helper_.FormActivityRegistered(main_frame.get(), params); // Since the first provider has suggestions available, it and only it // should have been asked. EXPECT_TRUE([provider1 askedIfSuggestionsAvailable]); EXPECT_FALSE([provider2 askedIfSuggestionsAvailable]); // Since the first provider said it had suggestions, it and only it // should have been asked to provide them. EXPECT_TRUE([provider1 askedForSuggestions]); EXPECT_FALSE([provider2 askedForSuggestions]); // The controller should have provided suggestions. EXPECT_EQ(2u, received_suggestions_.count); // Verify that the controller provided the suggestions. FormSuggestion* suggestion = [received_suggestions_ objectAtIndex:0]; EXPECT_NSEQ(@"foo", suggestion.value); suggestion = [received_suggestions_ objectAtIndex:1]; EXPECT_NSEQ(@"bar", suggestion.value); } // Tests that concurrent requests can be handled when suggestions are offered. TEST_P( FormSuggestionControllerTest, FormActivityShouldRetrieveSuggestions_SuggestionsAddedToAccessoryView_Concurrency) { autofill::FormActivityParams params; params.form_name = "form"; params.field_identifier = "field_id"; params.field_type = FieldType::kText; params.type = ActivityType::kFocus; params.value = "value"; params.input_missing = false; AsyncTestSuggestionProvider* provider = [[AsyncTestSuggestionProvider alloc] initWithSuggestions:@[]]; NSArray* suggestions = @[ [FormSuggestion copy:[FormSuggestion suggestionWithValue:@"foo" displayDescription:nil icon:nil type:autofill::SuggestionType:: kAutocompleteEntry payload:autofill::Suggestion::Payload() requiresReauth:NO] andSetParams:params provider:provider] ]; [provider setSuggestions:suggestions]; SetUpController(@[ provider ]); GURL url("http://foo.com"); fake_web_state_.SetCurrentURL(url); auto main_frame = web::FakeWebFrame::CreateMainWebFrame(url); // Start 2 concurrent suggestions retrieval requests. test_form_activity_tab_helper_.FormActivityRegistered(main_frame.get(), params); test_form_activity_tab_helper_.FormActivityRegistered(main_frame.get(), params); ASSERT_EQ(2, provider.pendingRequestsCount); // Run the async requests that were dispatched. base::RunLoop().RunUntilIdle(); ASSERT_EQ(0, provider.pendingRequestsCount); ASSERT_EQ(1u, received_suggestions_.count); // Verify that only the latest concurrent request is // handled, so one request. EXPECT_EQ(1, provider.askForSuggestionsCount); // Briefly verify that the returned suggestion corresponds to what the // provider provides. FormSuggestion* suggestion = [received_suggestions_ objectAtIndex:0]; EXPECT_NSEQ(@"foo", suggestion.value); } // Tests that with dedupping disabled, concurrent requests can be handled when // suggestions are offered. TEST_P( FormSuggestionControllerTest, FormActivityShouldRetrieveSuggestions_SuggestionsAddedToAccessoryView_Concurrency_WithoutDedupping) { base::test::ScopedFeatureList scoped_featurelist; scoped_featurelist.InitAndDisableFeature( kStatelessFormSuggestionControllerWithRequestDeduping); autofill::FormActivityParams params; params.form_name = "form"; params.field_identifier = "field_id"; params.field_type = FieldType::kText; params.type = ActivityType::kFocus; params.value = "value"; params.input_missing = false; AsyncTestSuggestionProvider* provider = [[AsyncTestSuggestionProvider alloc] initWithSuggestions:@[]]; NSArray* suggestions = @[ [FormSuggestion copy:[FormSuggestion suggestionWithValue:@"foo" displayDescription:nil icon:nil type:autofill::SuggestionType:: kAutocompleteEntry payload:autofill::Suggestion::Payload() requiresReauth:NO] andSetParams:params provider:provider] ]; [provider setSuggestions:suggestions]; SetUpController(@[ provider ]); GURL url("http://foo.com"); fake_web_state_.SetCurrentURL(url); auto main_frame = web::FakeWebFrame::CreateMainWebFrame(url); // Start 2 concurrent suggestions retrieval requests. test_form_activity_tab_helper_.FormActivityRegistered(main_frame.get(), params); test_form_activity_tab_helper_.FormActivityRegistered(main_frame.get(), params); ASSERT_EQ(2, provider.pendingRequestsCount); // Run the async requests that were dispatched. base::RunLoop().RunUntilIdle(); ASSERT_EQ(0, provider.pendingRequestsCount); ASSERT_EQ(1u, received_suggestions_.count); if (IsStateless()) { EXPECT_EQ(2, provider.askForSuggestionsCount); } else { // Verify that when not stateless, only the latest concurrent request is // handled, so one request. EXPECT_EQ(1, provider.askForSuggestionsCount); } // Briefly verify that the returned suggestion corresponds to what the // provider provides. FormSuggestion* suggestion = [received_suggestions_ objectAtIndex:0]; EXPECT_NSEQ(@"foo", suggestion.value); } // Tests that selecting a suggestion informs the specified delegate for that // suggestion. TEST_P(FormSuggestionControllerTest, SelectingSuggestionShouldNotifyDelegate) { GURL url("http://foo.com"); fake_web_state_.SetCurrentURL(url); auto main_frame = web::FakeWebFrame::CreateMainWebFrame(url); autofill::FormActivityParams params; params.form_name = "form"; params.field_identifier = "field_id"; params.field_type = FieldType::kText; params.type = ActivityType::kFocus; params.value = "value"; params.frame_id = "frame_id"; params.input_missing = false; TestSuggestionProvider* provider = [[TestSuggestionProvider alloc] initWithSuggestions:@[]]; // Send some suggestions to the controller and then tap one. NSArray* suggestions = @[ [FormSuggestion copy:[FormSuggestion suggestionWithValue:@"foo" displayDescription:nil icon:nil type:autofill::SuggestionType:: kAutocompleteEntry payload:autofill::Suggestion::Payload() requiresReauth:NO] andSetParams:params provider:provider], ]; [provider setSuggestions:suggestions]; SetUpController(@[ provider ]); test_form_activity_tab_helper_.FormActivityRegistered(main_frame.get(), params); // Selecting a suggestion should notify the delegate. [suggestion_controller_ didSelectSuggestion:suggestions[0] atIndex:0 completion:nil]; EXPECT_TRUE([provider selected]); EXPECT_NSEQ(@"form", [provider formName]); EXPECT_NSEQ(@"field_id", [provider fieldIdentifier]); EXPECT_NSEQ(@"frame_id", [provider frameID]); EXPECT_NSEQ(suggestions[0], [provider suggestion]); } // Tests that password generation suggestions always have an icon. TEST_P(FormSuggestionControllerTest, CopyAndAdjustSuggestions) { SetUpController(@[ [TestSuggestionProvider providerWithSuggestions] ]); NSMutableArray* suggestions = [NSMutableArray array]; FormSuggestion* suggestion = [FormSuggestion suggestionWithValue:@"" displayDescription:nil icon:nil type:autofill::SuggestionType::kGeneratePasswordEntry payload:autofill::Suggestion::Payload() requiresReauth:NO]; [suggestions addObject:suggestion]; NSArray* adjusted_suggestions = [suggestion_controller_ copyAndAdjustSuggestions:suggestions]; EXPECT_TRUE(adjusted_suggestions.count); EXPECT_TRUE(adjusted_suggestions[0].icon); } // Tests that metadata and suggestion_delegate are preserved when suggestions // are adjusted (e.g. for icons). TEST_P(FormSuggestionControllerTest, PreservesMetadataAndDelegateOnSuggestionCopy) { SetUpController(@[ [TestSuggestionProvider providerWithSuggestions] ]); autofill::MockAutofillSuggestionDelegate mock_delegate; FormSuggestionMetadata metadata; metadata.suggestion_delegate = mock_delegate.GetWeakPtr(); FormSuggestion* suggestion = [FormSuggestion suggestionWithValue:@"test-value" displayDescription:nil icon:nil type:autofill::SuggestionType::kAddressEntry payload:autofill::Suggestion::Payload() requiresReauth:NO acceptanceA11yAnnouncement:nil metadata:metadata]; NSArray* adjusted_suggestions = [suggestion_controller_ copyAndAdjustSuggestions:@[ suggestion ]]; ASSERT_EQ(adjusted_suggestions.count, 1U); EXPECT_EQ(adjusted_suggestions[0].metadata.suggestion_delegate.get(), &mock_delegate); } std::string ParamToString(const testing::TestParamInfo& params_info) { return params_info.param ? "Stateless" : "Stateful"; } INSTANTIATE_TEST_SUITE_P(, FormSuggestionControllerTest, ::testing::Bool(), ParamToString); } // namespace