// Copyright 2022 The Chromium Authors // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. #include "components/autofill/core/browser/payments/iban_save_manager.h" #include "base/json/json_reader.h" #include "base/strings/string_number_conversions.h" #include "base/strings/utf_string_conversions.h" #include "base/test/gmock_callback_support.h" #include "base/test/metrics/histogram_tester.h" #include "base/test/scoped_feature_list.h" #include "base/test/task_environment.h" #include "base/uuid.h" #include "components/autofill/core/browser/data_manager/payments/payments_data_manager.h" #include "components/autofill/core/browser/data_manager/test_personal_data_manager.h" #include "components/autofill/core/browser/data_model/payments/iban.h" #include "components/autofill/core/browser/foundations/test_autofill_client.h" #include "components/autofill/core/browser/metrics/payments/iban_metrics.h" #include "components/autofill/core/browser/payments/iban_save_manager_test_api.h" #include "components/autofill/core/browser/payments/mock_test_payments_network_interface.h" #include "components/autofill/core/browser/payments/payments_autofill_client.h" #include "components/autofill/core/browser/payments/payments_network_interface.h" #include "components/autofill/core/browser/strike_databases/payments/iban_save_strike_database.h" #include "components/autofill/core/browser/test_utils/autofill_test_utils.h" #include "components/autofill/core/common/autofill_prefs.h" #include "components/prefs/pref_service.h" #include "components/sync/test/test_sync_service.h" #include "testing/gmock/include/gmock/gmock.h" #include "testing/gtest/include/gtest/gtest.h" namespace autofill { namespace { using ::testing::_; using ::testing::AllOf; using ::testing::Field; #if !BUILDFLAG(IS_ANDROID) && !BUILDFLAG(IS_IOS) constexpr char kLegalMessageLines[] = "{" " \"line\" : [ {" " \"template\": \"The legal documents are: {0} and {1}.\"," " \"template_parameter\" : [ {" " \"display_text\" : \"Terms of Service\"," " \"url\": \"http://www.example.com/tos\"" " }, {" " \"display_text\" : \"Privacy Policy\"," " \"url\": \"http://www.example.com/pp\"" " } ]" " } ]" "}"; constexpr char kInvalidLegalMessageLines[] = "{" " \"line\" : [ {" " \"template\": \"Panda {0}.\"," " \"template_parameter\": [ {" " \"display_text\": \"bear\"" " } ]" " } ]" "}"; constexpr char16_t kCapitalizedIbanRegex[] = u"^[A-Z]{2}[0-9]{2}[A-Z0-9]{4}[0-9]{7}[A-Z0-9]{0,18}$"; class IbanSaveManagerTest : public testing::Test { public: IbanSaveManagerTest() { autofill_client_.GetPaymentsAutofillClient() ->set_payments_network_interface( std::make_unique()); autofill_client_.set_sync_service(&sync_service_); std::unique_ptr test_strike_database = std::make_unique(); strike_database_ = test_strike_database.get(); autofill_client_.set_test_strike_database(std::move(test_strike_database)); personal_data().payments_data_manager().SetSyncingForTest(true); iban_save_manager_ = std::make_unique(&autofill_client_); } using SaveIbanOfferUserDecision = payments::PaymentsAutofillClient::SaveIbanOfferUserDecision; IbanSaveManager& GetIbanSaveManager() { return *iban_save_manager_; } void SetUpGetIbanUploadDetailsResponse( bool is_successful, const std::u16string& regex = kCapitalizedIbanRegex, bool includes_invalid_legal_message = false) { ON_CALL(*payments_network_interface(), GetIbanUploadDetails) .WillByDefault( [is_successful, regex, includes_invalid_legal_message]( const std::string& app_locale, const std::vector& client_behavior_signals, int64_t billing_customer_number, const std::string& country_code, base::OnceCallback)> callback) { std::move(callback).Run( is_successful ? payments::PaymentsAutofillClient:: PaymentsRpcResult::kSuccess : payments::PaymentsAutofillClient:: PaymentsRpcResult::kPermanentFailure, regex, u"this is a context token", includes_invalid_legal_message ? std::make_unique( base::JSONReader::ReadDict( kInvalidLegalMessageLines, base::JSON_PARSE_CHROMIUM_EXTENSIONS) .value()) : std::make_unique( base::JSONReader::ReadDict( kLegalMessageLines, base::JSON_PARSE_CHROMIUM_EXTENSIONS) .value())); }); } void SetUpUploadIbanResponse(bool is_successful) { ON_CALL(*payments_network_interface(), UploadIban) .WillByDefault( [is_successful]( const payments::UploadIbanRequestDetails& request_details, base::OnceCallback callback) { std::move(callback).Run( is_successful ? payments::PaymentsAutofillClient:: PaymentsRpcResult::kSuccess : payments::PaymentsAutofillClient:: PaymentsRpcResult::kPermanentFailure); }); } protected: TestPersonalDataManager& personal_data() { return autofill_client_.GetPersonalDataManager(); } MockTestPaymentsNetworkInterface* payments_network_interface() { return static_cast( autofill_client_.GetPaymentsAutofillClient() ->GetPaymentsNetworkInterface()); } base::test::TaskEnvironment task_environment_; test::AutofillUnitTestEnvironment autofill_test_environment_; syncer::TestSyncService sync_service_; TestAutofillClient autofill_client_; std::unique_ptr iban_save_manager_; raw_ptr strike_database_; }; TEST_F(IbanSaveManagerTest, AttemptToOfferSave_NewIban_ShouldOfferSave) { Iban iban; iban.set_value(std::u16string(test::kIbanValue16)); EXPECT_TRUE(GetIbanSaveManager().AttemptToOfferSave(iban)); } TEST_F(IbanSaveManagerTest, AttemptToOfferSave_LocalIban_ShouldOfferSave) { Iban iban; iban.set_value(std::u16string(test::kIbanValue16)); personal_data().payments_data_manager().AddAsLocalIban(iban); Iban another_iban; another_iban.set_value(iban.value()); EXPECT_TRUE(GetIbanSaveManager().AttemptToOfferSave(iban)); } // Test that new IBANs should not be offered upload save due to reaching the // maximum limit. TEST_F(IbanSaveManagerTest, ShouldOfferUploadSave_MaxServerIban) { Iban iban; iban.set_value(std::u16string(test::kIbanValue16)); for (int num_server_ibans = 1; num_server_ibans <= kMaxNumServerIbans + 1; num_server_ibans++) { Iban server_iban((Iban::InstrumentId(num_server_ibans))); server_iban.set_prefix(u"DE"); server_iban.set_suffix( (base::UTF8ToUTF16(base::NumberToString(10 + num_server_ibans)))); personal_data().test_payments_data_manager().AddServerIban(server_iban); EXPECT_EQ(num_server_ibans <= kMaxNumServerIbans ? IbanSaveManager::TypeOfOfferToSave::kOfferServerSave : IbanSaveManager::TypeOfOfferToSave::kOfferLocalSave, test_api(GetIbanSaveManager()).DetermineHowToSaveIban(iban)); } } // Test that new IBANs should be offered upload save to Google Payments. TEST_F(IbanSaveManagerTest, ShouldOfferUploadSave_NewIban) { Iban iban; iban.set_value(std::u16string(test::kIbanValue16)); EXPECT_EQ(IbanSaveManager::TypeOfOfferToSave::kOfferServerSave, test_api(GetIbanSaveManager()).DetermineHowToSaveIban(iban)); } // Test that an existing local IBAN should still be offered upload save to // Google Payments. TEST_F(IbanSaveManagerTest, ShouldOfferUploadSave_LocalIban) { Iban iban; iban.set_value(std::u16string(test::kIbanValue16)); personal_data().payments_data_manager().AddAsLocalIban(iban); Iban another_iban; another_iban.set_value(iban.value()); EXPECT_EQ(IbanSaveManager::TypeOfOfferToSave::kOfferServerSave, test_api(GetIbanSaveManager()).DetermineHowToSaveIban(iban)); } // Test that an existing local and server IBAN should not be offered save at // all. TEST_F(IbanSaveManagerTest, ShouldOfferUploadSave_LocalAndServerIban) { Iban local_iban; local_iban.set_value(u"DE91100000000123456789"); personal_data().payments_data_manager().AddAsLocalIban(local_iban); Iban server_iban(Iban::InstrumentId(1234567)); server_iban.set_prefix(u"DE91"); server_iban.set_suffix(u"6789"); personal_data().test_payments_data_manager().AddServerIban(server_iban); // Creates an unknown IBAN with the same prefix, suffix and length as the // above server IBAN. Iban iban; iban.set_value(u"DE91100000000123456789"); EXPECT_FALSE(GetIbanSaveManager().AttemptToOfferSave(iban)); } // Test that an existing server IBAN should not be offered save at all. TEST_F(IbanSaveManagerTest, ShouldOfferUploadSave_ServerIban) { Iban iban(Iban::InstrumentId(1234567)); iban.set_prefix(u"DE91"); iban.set_suffix(u"6789"); personal_data().test_payments_data_manager().AddServerIban(iban); // Creates an unknown IBAN with the same prefix, suffix and length as the // above server IBAN. Iban another_iban; another_iban.set_value(u"DE91100000000123456789"); EXPECT_EQ(IbanSaveManager::TypeOfOfferToSave::kDoNotOfferToSave, test_api(GetIbanSaveManager()).DetermineHowToSaveIban(iban)); } TEST_F(IbanSaveManagerTest, OnUserDidDecideOnLocalSave_Accepted) { Iban iban; iban.set_value(std::u16string(test::kIbanValue16)); EXPECT_TRUE(test_api(GetIbanSaveManager()).AttemptToOfferLocalSave(iban)); test_api(GetIbanSaveManager()) .OnUserDidDecideOnLocalSave(iban, SaveIbanOfferUserDecision::kAccepted, u" My teacher's IBAN "); const std::vector ibans = personal_data().payments_data_manager().GetLocalIbans(); // Verify IBAN has been successfully updated with the new nickname on accept. ASSERT_EQ(ibans.size(), 1U); EXPECT_EQ(ibans[0]->value(), iban.value()); EXPECT_EQ(ibans[0]->nickname(), u"My teacher's IBAN"); } TEST_F(IbanSaveManagerTest, OnUserDidDecideOnLocalSave_Declined) { Iban iban; iban.set_value(std::u16string(test::kIbanValue16)); EXPECT_TRUE(test_api(*iban_save_manager_).AttemptToOfferLocalSave(iban)); EXPECT_TRUE(personal_data().payments_data_manager().GetLocalIbans().empty()); test_api(GetIbanSaveManager()) .OnUserDidDecideOnLocalSave(iban, SaveIbanOfferUserDecision::kDeclined); const std::vector ibans = personal_data().payments_data_manager().GetLocalIbans(); EXPECT_TRUE(personal_data().payments_data_manager().GetLocalIbans().empty()); } TEST_F(IbanSaveManagerTest, OnUserDidDecideOnLocalSave_Ignored) { Iban iban; iban.set_value(std::u16string(test::kIbanValue16)); EXPECT_TRUE(test_api(*iban_save_manager_).AttemptToOfferLocalSave(iban)); EXPECT_TRUE(personal_data().payments_data_manager().GetLocalIbans().empty()); test_api(GetIbanSaveManager()) .OnUserDidDecideOnLocalSave(iban, SaveIbanOfferUserDecision::kIgnored); const std::vector ibans = personal_data().payments_data_manager().GetLocalIbans(); EXPECT_TRUE(personal_data().payments_data_manager().GetLocalIbans().empty()); } TEST_F(IbanSaveManagerTest, LocallySaveIban_NotEnoughStrikesShouldOfferToSave) { Iban iban; iban.set_value(std::u16string(test::kIbanValue16)); const std::string partial_iban_hash = IbanSaveManager::GetPartialIbanHashString( base::UTF16ToUTF8(iban.value())); IbanSaveStrikeDatabase iban_save_strike_database(strike_database_); iban_save_strike_database.AddStrike(partial_iban_hash); // Verify `kIbanValue` has been successfully added to the strike database. EXPECT_EQ(1, iban_save_strike_database.GetStrikes(partial_iban_hash)); EXPECT_TRUE(test_api(GetIbanSaveManager()).AttemptToOfferLocalSave(iban)); } TEST_F(IbanSaveManagerTest, LocallySaveIban_MaxStrikesShouldNotOfferToSave) { Iban iban; iban.set_value(std::u16string(test::kIbanValue16)); const std::string partial_iban_hash = IbanSaveManager::GetPartialIbanHashString( base::UTF16ToUTF8(iban.value())); IbanSaveStrikeDatabase iban_save_strike_database(strike_database_); iban_save_strike_database.AddStrikes( iban_save_strike_database.GetMaxStrikesLimit(), partial_iban_hash); EXPECT_EQ(iban_save_strike_database.GetMaxStrikesLimit(), iban_save_strike_database.GetStrikes(partial_iban_hash)); EXPECT_FALSE(test_api(GetIbanSaveManager()).AttemptToOfferLocalSave(iban)); } TEST_F(IbanSaveManagerTest, OnUserDidDecideOnLocalSave_Accepted_ClearsStrikes) { Iban iban; iban.set_value(std::u16string(test::kIbanValue16)); const std::string partial_iban_hash = IbanSaveManager::GetPartialIbanHashString( base::UTF16ToUTF8(iban.value())); EXPECT_TRUE(test_api(GetIbanSaveManager()).AttemptToOfferLocalSave(iban)); IbanSaveStrikeDatabase iban_save_strike_database(strike_database_); iban_save_strike_database.AddStrike(partial_iban_hash); // Verify partial hashed value of `partial_iban_hash` has been // successfully added to the strike database. EXPECT_EQ(1, iban_save_strike_database.GetStrikes(partial_iban_hash)); test_api(GetIbanSaveManager()) .OnUserDidDecideOnLocalSave(iban, SaveIbanOfferUserDecision::kAccepted, u"My teacher's IBAN"); // Verify partial hashed value of `partial_iban_hash` has been // cleared in the strike database. EXPECT_EQ(0, iban_save_strike_database.GetStrikes(partial_iban_hash)); } TEST_F(IbanSaveManagerTest, OnUserDidDecideOnLocalSave_Declined_AddsStrike) { Iban iban; iban.set_value(std::u16string(test::kIbanValue16)); const std::string partial_iban_hash = IbanSaveManager::GetPartialIbanHashString( base::UTF16ToUTF8(iban.value())); EXPECT_TRUE(test_api(GetIbanSaveManager()).AttemptToOfferLocalSave(iban)); IbanSaveStrikeDatabase iban_save_strike_database(strike_database_); EXPECT_EQ(0, iban_save_strike_database.GetStrikes(partial_iban_hash)); test_api(GetIbanSaveManager()) .OnUserDidDecideOnLocalSave(iban, SaveIbanOfferUserDecision::kDeclined, u"My teacher's IBAN"); // Verify partial hashed value of `partial_iban_hash` has been // added to the strike database. EXPECT_EQ(1, iban_save_strike_database.GetStrikes(partial_iban_hash)); } TEST_F(IbanSaveManagerTest, OnUserDidDecideOnLocalSave_Ignored_AddsStrike) { Iban iban; iban.set_value(std::u16string(test::kIbanValue16)); const std::string partial_iban_hash = IbanSaveManager::GetPartialIbanHashString( base::UTF16ToUTF8(iban.value())); EXPECT_TRUE(test_api(GetIbanSaveManager()).AttemptToOfferLocalSave(iban)); IbanSaveStrikeDatabase iban_save_strike_database(strike_database_); EXPECT_EQ(0, iban_save_strike_database.GetStrikes(partial_iban_hash)); test_api(GetIbanSaveManager()) .OnUserDidDecideOnLocalSave(iban, SaveIbanOfferUserDecision::kDeclined, u"My teacher's IBAN"); // Verify partial hashed value of `partial_iban_hash` has been // added to the strike database. EXPECT_EQ(1, iban_save_strike_database.GetStrikes(partial_iban_hash)); } TEST_F(IbanSaveManagerTest, LocallySaveIban_OfferIbanSave) { Iban iban; iban.set_value(std::u16string(test::kIbanValue16)); EXPECT_TRUE(test_api(GetIbanSaveManager()).AttemptToOfferLocalSave(iban)); EXPECT_TRUE(autofill_client_.GetPaymentsAutofillClient() ->ConfirmSaveIbanLocallyWasCalled()); } TEST_F(IbanSaveManagerTest, LocallySaveIban_MaxStrikesShouldNotOfferToSave_Metrics) { base::HistogramTester histogram_tester; Iban iban; iban.set_value(std::u16string(test::kIbanValue16)); IbanSaveStrikeDatabase iban_save_strike_database(strike_database_); iban_save_strike_database.AddStrikes( iban_save_strike_database.GetMaxStrikesLimit(), IbanSaveManager::GetPartialIbanHashString( test::GetStrippedValue(test::kIbanValue))); EXPECT_EQ(iban_save_strike_database.GetMaxStrikesLimit(), iban_save_strike_database.GetStrikes( IbanSaveManager::GetPartialIbanHashString( test::GetStrippedValue(test::kIbanValue)))); EXPECT_FALSE(test_api(GetIbanSaveManager()).AttemptToOfferLocalSave(iban)); histogram_tester.ExpectBucketCount( "Autofill.StrikeDatabase.IbanSaveNotOfferedDueToMaxStrikes", AutofillMetrics::SaveTypeMetric::LOCAL, 1); } TEST_F(IbanSaveManagerTest, StrikesPresentWhenIbanSaved_Local) { base::HistogramTester histogram_tester; Iban iban; iban.set_value(std::u16string(test::kIbanValue16)); IbanSaveStrikeDatabase iban_save_strike_database(strike_database_); iban_save_strike_database.AddStrike(IbanSaveManager::GetPartialIbanHashString( test::GetStrippedValue(test::kIbanValue))); EXPECT_TRUE(test_api(GetIbanSaveManager()).AttemptToOfferLocalSave(iban)); test_api(GetIbanSaveManager()) .OnUserDidDecideOnLocalSave(iban, SaveIbanOfferUserDecision::kAccepted, u"My teacher's IBAN"); histogram_tester.ExpectBucketCount( "Autofill.StrikeDatabase.StrikesPresentWhenIbanSaved.Local", /*sample=*/1, /*expected_count=*/1); } TEST_F(IbanSaveManagerTest, IsIbanUploadEnabled_SyncServiceNotAvailable) { base::HistogramTester histogram_tester; EXPECT_FALSE(IbanSaveManager::IsIbanUploadEnabled( /*sync_service=*/nullptr, AutofillMetrics::PaymentsSigninState::kSignedOut)); histogram_tester.ExpectUniqueSample( "Autofill.IbanUploadEnabled", autofill_metrics::IbanUploadEnabledStatus::kSyncServiceNull, 1); histogram_tester.ExpectUniqueSample( "Autofill.IbanUploadEnabled.SignedOut", autofill_metrics::IbanUploadEnabledStatus::kSyncServiceNull, 1); } TEST_F(IbanSaveManagerTest, IsIbanUploadEnabled_AuthError) { base::HistogramTester histogram_tester; // Set the SyncService to paused state. sync_service_.SetPersistentAuthError(); EXPECT_FALSE(IbanSaveManager::IsIbanUploadEnabled( &sync_service_, AutofillMetrics::PaymentsSigninState::kSyncPaused)); histogram_tester.ExpectUniqueSample( "Autofill.IbanUploadEnabled", autofill_metrics::IbanUploadEnabledStatus::kSyncServicePaused, 1); histogram_tester.ExpectUniqueSample( "Autofill.IbanUploadEnabled.SyncPaused", autofill_metrics::IbanUploadEnabledStatus::kSyncServicePaused, 1); } TEST_F(IbanSaveManagerTest, IsIbanUploadEnabled_SyncDoesNotHaveAutofillWalletDataActiveType) { base::HistogramTester histogram_tester; sync_service_.GetUserSettings()->SetSelectedTypes( /*sync_everything=*/false, /*types=*/syncer::UserSelectableTypeSet()); EXPECT_FALSE(IbanSaveManager::IsIbanUploadEnabled( &sync_service_, AutofillMetrics::PaymentsSigninState::kSignedInAndSyncFeatureEnabled)); histogram_tester.ExpectUniqueSample( "Autofill.IbanUploadEnabled", autofill_metrics::IbanUploadEnabledStatus:: kSyncServiceMissingAutofillWalletDataActiveType, 1); histogram_tester.ExpectUniqueSample( "Autofill.IbanUploadEnabled.SignedInAndSyncFeatureEnabled", autofill_metrics::IbanUploadEnabledStatus:: kSyncServiceMissingAutofillWalletDataActiveType, 1); } TEST_F(IbanSaveManagerTest, IsIbanUploadEnabled_SyncServiceUsingExplicitPassphrase) { base::HistogramTester histogram_tester; sync_service_.SetIsUsingExplicitPassphrase(true); EXPECT_FALSE(IbanSaveManager::IsIbanUploadEnabled( &sync_service_, AutofillMetrics::PaymentsSigninState::kSignedInAndSyncFeatureEnabled)); histogram_tester.ExpectUniqueSample( "Autofill.IbanUploadEnabled", autofill_metrics::IbanUploadEnabledStatus::kUsingExplicitSyncPassphrase, 1); histogram_tester.ExpectUniqueSample( "Autofill.IbanUploadEnabled.SignedInAndSyncFeatureEnabled", autofill_metrics::IbanUploadEnabledStatus::kUsingExplicitSyncPassphrase, 1); } TEST_F(IbanSaveManagerTest, IsIbanUploadEnabled_SyncServiceLocalSyncOnly) { base::HistogramTester histogram_tester; sync_service_.SetLocalSyncEnabled(true); EXPECT_FALSE(IbanSaveManager::IsIbanUploadEnabled( &sync_service_, AutofillMetrics::PaymentsSigninState::kSignedInAndSyncFeatureEnabled)); histogram_tester.ExpectUniqueSample( "Autofill.IbanUploadEnabled", autofill_metrics::IbanUploadEnabledStatus:: kSyncServiceMissingAutofillWalletDataActiveType, 1); histogram_tester.ExpectUniqueSample( "Autofill.IbanUploadEnabled.SignedInAndSyncFeatureEnabled", autofill_metrics::IbanUploadEnabledStatus:: kSyncServiceMissingAutofillWalletDataActiveType, 1); } TEST_F(IbanSaveManagerTest, IsIbanUploadEnabled_Enabled) { base::HistogramTester histogram_tester; EXPECT_TRUE(IbanSaveManager::IsIbanUploadEnabled( &sync_service_, AutofillMetrics::PaymentsSigninState::kSignedInAndSyncFeatureEnabled)); histogram_tester.ExpectUniqueSample( "Autofill.IbanUploadEnabled", autofill_metrics::IbanUploadEnabledStatus::kEnabled, 1); histogram_tester.ExpectUniqueSample( "Autofill.IbanUploadEnabled.SignedInAndSyncFeatureEnabled", autofill_metrics::IbanUploadEnabledStatus::kEnabled, 1); } // Test that upload save should be offered to a new IBAN when the preflight // call succeeded and the `legal_message` is parsed successfully. TEST_F(IbanSaveManagerTest, OfferUploadSave_NewIban_Success) { Iban iban; iban.set_value(std::u16string(test::kIbanValue16)); SetUpGetIbanUploadDetailsResponse(/*is_successful=*/true); EXPECT_TRUE(test_api(GetIbanSaveManager()).AttemptToOfferUploadSave(iban)); EXPECT_TRUE(autofill_client_.GetPaymentsAutofillClient()->risk_data_loaded()); EXPECT_TRUE(autofill_client_.GetPaymentsAutofillClient() ->ConfirmUploadIbanToCloudWasCalled()); EXPECT_FALSE(autofill_client_.GetPaymentsAutofillClient() ->ConfirmSaveIbanLocallyWasCalled()); } // Test that upload save should be not be offered for a new IBAN when the // regex validation does not pass. TEST_F(IbanSaveManagerTest, OfferUploadSave_NewIban_FailureOnRegexNotMatch) { Iban iban; // Set up a valid France IBAN value. iban.set_value(std::u16string(test::kIbanValue16)); // Set up a Finland validation regex. SetUpGetIbanUploadDetailsResponse( /*is_successful=*/true, u"^FI{2}[0-9]{2}[A-Z0-9]{4}[0-9]{7}[A-Z0-9]{0,18}$", /*includes_invalid_legal_message=*/false); EXPECT_TRUE(test_api(GetIbanSaveManager()).AttemptToOfferUploadSave(iban)); EXPECT_FALSE(autofill_client_.GetPaymentsAutofillClient() ->ConfirmUploadIbanToCloudWasCalled()); EXPECT_TRUE(autofill_client_.GetPaymentsAutofillClient() ->ConfirmSaveIbanLocallyWasCalled()); } // Test that upload save should not be offered when the preflight call failed. // In this case, local save should be offered because the extracted IBAN is a // new IBAN. TEST_F(IbanSaveManagerTest, OfferUploadSave_NewIban_Failure_ThenAttemptToOfferLocalSave) { Iban iban; iban.set_value(std::u16string(test::kIbanValue16)); SetUpGetIbanUploadDetailsResponse(/*is_successful=*/false); EXPECT_TRUE(test_api(GetIbanSaveManager()).AttemptToOfferUploadSave(iban)); EXPECT_FALSE(autofill_client_.GetPaymentsAutofillClient() ->ConfirmUploadIbanToCloudWasCalled()); EXPECT_TRUE(autofill_client_.GetPaymentsAutofillClient() ->ConfirmSaveIbanLocallyWasCalled()); } // Test that upload save should not be offered when the preflight call succeeded // but the `legal_message` is not parsed successfully. In this case, local save // should be offered because the extracted IBAN is a new IBAN. TEST_F( IbanSaveManagerTest, OfferUploadSave_NewIban_InvalidLegalMessage_ThenAttemptToOfferLocalSave) { Iban iban; iban.set_value(std::u16string(test::kIbanValue16)); SetUpGetIbanUploadDetailsResponse(/*is_successful=*/true, kCapitalizedIbanRegex, /*includes_invalid_legal_message=*/true); EXPECT_TRUE(test_api(GetIbanSaveManager()).AttemptToOfferUploadSave(iban)); EXPECT_FALSE(autofill_client_.GetPaymentsAutofillClient() ->ConfirmUploadIbanToCloudWasCalled()); EXPECT_TRUE(autofill_client_.GetPaymentsAutofillClient() ->ConfirmSaveIbanLocallyWasCalled()); } // call succeeded and the `legal_message` is parsed successfully. TEST_F(IbanSaveManagerTest, OfferUploadSave_LocalIban_Success) { Iban local_iban; local_iban.set_value(std::u16string(test::kIbanValue16)); personal_data().payments_data_manager().AddAsLocalIban(local_iban); Iban another_iban; another_iban.set_value(local_iban.value()); SetUpGetIbanUploadDetailsResponse(/*is_successful=*/true); EXPECT_TRUE( test_api(GetIbanSaveManager()).AttemptToOfferUploadSave(another_iban)); EXPECT_TRUE(autofill_client_.GetPaymentsAutofillClient() ->ConfirmUploadIbanToCloudWasCalled()); EXPECT_FALSE(autofill_client_.GetPaymentsAutofillClient() ->ConfirmSaveIbanLocallyWasCalled()); } // Test that upload save should not be offered when the preflight call failed // and the `legal_message` is parsed successfully. Then Local save should not be // offered because the extracted IBAN already exists. TEST_F(IbanSaveManagerTest, OfferUploadSave_LocalIban_Failure_LocalSaveNotOffered) { Iban local_iban; local_iban.set_value(std::u16string(test::kIbanValue16)); personal_data().payments_data_manager().AddAsLocalIban(local_iban); Iban another_iban; another_iban.set_value(local_iban.value()); SetUpGetIbanUploadDetailsResponse(/*is_successful=*/false); EXPECT_TRUE( test_api(GetIbanSaveManager()).AttemptToOfferUploadSave(another_iban)); EXPECT_FALSE(autofill_client_.GetPaymentsAutofillClient() ->ConfirmUploadIbanToCloudWasCalled()); EXPECT_FALSE(autofill_client_.GetPaymentsAutofillClient() ->ConfirmSaveIbanLocallyWasCalled()); } TEST_F(IbanSaveManagerTest, UploadSaveIban_Accept_SuccessShouldClearStrikes) { base::HistogramTester histogram_tester; SetUpGetIbanUploadDetailsResponse(/*is_successful=*/true); SetUpUploadIbanResponse(/*is_successful=*/true); Iban iban; iban.set_value(std::u16string(test::kIbanValue16)); const std::string& partial_iban_hash = IbanSaveManager::GetPartialIbanHashString( base::UTF16ToUTF8(iban.value())); IbanSaveStrikeDatabase iban_save_strike_database(strike_database_); iban_save_strike_database.AddStrike(partial_iban_hash); // Verify `kIbanValue` has been successfully added to the strike database. EXPECT_EQ(1, iban_save_strike_database.GetStrikes(partial_iban_hash)); EXPECT_TRUE(test_api(GetIbanSaveManager()).AttemptToOfferUploadSave(iban)); std::move(autofill_client_.GetPaymentsAutofillClient() ->confirm_upload_iban_to_cloud_callbacks() .back()) .Run(SaveIbanOfferUserDecision::kAccepted, u"My teacher's IBAN"); // Verify the IBAN's strikes have been cleared. EXPECT_EQ(0, iban_save_strike_database.GetStrikes(partial_iban_hash)); histogram_tester.ExpectBucketCount( "Autofill.StrikeDatabase.StrikesPresentWhenIbanSaved.Upload", /*sample=*/1, /*expected_count=*/1); } TEST_F(IbanSaveManagerTest, UploadSaveIban_Accept_FailureShouldAddStrike) { SetUpGetIbanUploadDetailsResponse(/*is_successful=*/true); SetUpUploadIbanResponse(/*is_successful=*/false); Iban iban; iban.set_value(std::u16string(test::kIbanValue16)); const std::string& partial_iban_hash = IbanSaveManager::GetPartialIbanHashString( base::UTF16ToUTF8(iban.value())); IbanSaveStrikeDatabase iban_save_strike_database(strike_database_); iban_save_strike_database.AddStrike(partial_iban_hash); EXPECT_TRUE(test_api(GetIbanSaveManager()).AttemptToOfferUploadSave(iban)); std::move(autofill_client_.GetPaymentsAutofillClient() ->confirm_upload_iban_to_cloud_callbacks() .back()) .Run(SaveIbanOfferUserDecision::kAccepted, u"My teacher's IBAN"); // Verify the IBAN's strikes have been added by 1. EXPECT_EQ(2, iban_save_strike_database.GetStrikes(partial_iban_hash)); } TEST_F(IbanSaveManagerTest, OnUserDidDecideOnUploadSave_Decline_AddsStrike) { Iban iban; iban.set_value(std::u16string(test::kIbanValue16)); const std::string& partial_iban_hash = IbanSaveManager::GetPartialIbanHashString( base::UTF16ToUTF8(iban.value())); EXPECT_TRUE(test_api(GetIbanSaveManager()).AttemptToOfferUploadSave(iban)); IbanSaveStrikeDatabase iban_save_strike_database(strike_database_); test_api(GetIbanSaveManager()) .OnUserDidDecideOnUploadSave(iban, SaveIbanOfferUserDecision::kDeclined); // Verify the IBAN's strikes have been added by 1. EXPECT_EQ(1, iban_save_strike_database.GetStrikes(partial_iban_hash)); // Verify that `UploadIban` handler is not triggered. EXPECT_CALL(*payments_network_interface(), UploadIban).Times(0); } TEST_F(IbanSaveManagerTest, OnUserDidDecideOnUploadSave_Ignore_AddsStrike) { Iban iban; iban.set_value(std::u16string(test::kIbanValue16)); const std::string& partial_iban_hash = IbanSaveManager::GetPartialIbanHashString( base::UTF16ToUTF8(iban.value())); EXPECT_TRUE(test_api(GetIbanSaveManager()).AttemptToOfferUploadSave(iban)); IbanSaveStrikeDatabase iban_save_strike_database(strike_database_); test_api(GetIbanSaveManager()) .OnUserDidDecideOnUploadSave(iban, SaveIbanOfferUserDecision::kIgnored); // Verify the IBAN's strikes have been added by 1. EXPECT_EQ(1, iban_save_strike_database.GetStrikes(partial_iban_hash)); // Verify that `UploadIban` handler is not triggered. EXPECT_CALL(*payments_network_interface(), UploadIban).Times(0); } // Test that offer-to-upload IBAN origin is logged as `kNewIban` for a new IBAN. TEST_F(IbanSaveManagerTest, Metric_UploadOfferedIbanOrigin_NewIban) { base::HistogramTester histogram_tester; Iban iban; iban.set_value(base::UTF8ToUTF16(std::string(test::kIbanValue))); ASSERT_TRUE(GetIbanSaveManager().AttemptToOfferSave(iban)); histogram_tester.ExpectBucketCount( "Autofill.UploadIban.Offered", /*sample=*/ autofill_metrics::UploadIbanOriginMetric::kNewIban, /*expected_count=*/1); } // Test that offer-to-upload IBAN origin is logged as `kLocalIban` for a local // IBAN. TEST_F(IbanSaveManagerTest, Metric_UploadOfferedIbanOrigin_LocalIban) { base::HistogramTester histogram_tester; Iban iban; iban.set_value(base::UTF8ToUTF16(std::string(test::kIbanValue))); personal_data().payments_data_manager().AddAsLocalIban(iban); ASSERT_TRUE(GetIbanSaveManager().AttemptToOfferSave(iban)); histogram_tester.ExpectBucketCount( "Autofill.UploadIban.Offered", /*sample=*/ autofill_metrics::UploadIbanOriginMetric::kLocalIban, /*expected_count=*/1); } // Test that when upload is offered for a new IBAN and the offer is accepted, // `kAccepted` and `kNewIban` are logged. TEST_F(IbanSaveManagerTest, Metric_AcceptedOfferedIbanOrigin_NewIban) { base::HistogramTester histogram_tester; SetUpGetIbanUploadDetailsResponse(/*is_successful=*/true); SetUpUploadIbanResponse(/*is_successful=*/true); Iban iban; iban.set_value(base::UTF8ToUTF16(std::string(test::kIbanValue))); ASSERT_TRUE(GetIbanSaveManager().AttemptToOfferSave(iban)); test_api(GetIbanSaveManager()) .OnUserDidDecideOnUploadSave(iban, SaveIbanOfferUserDecision::kAccepted, u"My teacher's IBAN"); histogram_tester.ExpectBucketCount( "Autofill.UploadIban.Accepted", /*sample=*/ autofill_metrics::UploadIbanOriginMetric::kNewIban, /*expected_count=*/1); } // Test that when upload is offered for an existing IBAN and the offer is // accepted, `kAccepted` and `kLocalIban` are logged. TEST_F(IbanSaveManagerTest, Metric_AcceptedOfferedIbanOrigin_LocalIban) { base::HistogramTester histogram_tester; SetUpGetIbanUploadDetailsResponse(/*is_successful=*/true); SetUpUploadIbanResponse(/*is_successful=*/true); Iban iban; iban.set_value(base::UTF8ToUTF16(std::string(test::kIbanValue))); personal_data().payments_data_manager().AddAsLocalIban(iban); ASSERT_TRUE(GetIbanSaveManager().AttemptToOfferSave(iban)); test_api(GetIbanSaveManager()) .OnUserDidDecideOnUploadSave(iban, SaveIbanOfferUserDecision::kAccepted, u"My teacher's IBAN"); histogram_tester.ExpectBucketCount( "Autofill.UploadIban.Accepted", /*sample=*/ autofill_metrics::UploadIbanOriginMetric::kLocalIban, /*expected_count=*/1); } // Test that when upload is offered for a new IBAN and the offer is declined, // `kDeclined` and `kNewIban` are logged. TEST_F(IbanSaveManagerTest, Metric_DeclinedOfferedIbanOrigin_NewIban) { base::HistogramTester histogram_tester; Iban iban; iban.set_value(base::UTF8ToUTF16(std::string(test::kIbanValue))); EXPECT_TRUE(GetIbanSaveManager().AttemptToOfferSave(iban)); test_api(GetIbanSaveManager()) .OnUserDidDecideOnUploadSave(iban, SaveIbanOfferUserDecision::kDeclined, u"My teacher's IBAN"); histogram_tester.ExpectBucketCount( "Autofill.UploadIban.Declined", /*sample=*/autofill_metrics::UploadIbanOriginMetric::kNewIban, /*expected_count=*/1); } // Test that when upload is offered for an existing IBAN and the offer is // declined, `kDeclined` and `kLocalIban` are logged. TEST_F(IbanSaveManagerTest, Metric_DeclinedOfferedIbanOrigin_LocalIban) { base::HistogramTester histogram_tester; SetUpGetIbanUploadDetailsResponse(/*is_successful=*/true); SetUpUploadIbanResponse(/*is_successful=*/true); Iban iban; iban.set_value(base::UTF8ToUTF16(std::string(test::kIbanValue))); personal_data().payments_data_manager().AddAsLocalIban(iban); ASSERT_TRUE(GetIbanSaveManager().AttemptToOfferSave(iban)); test_api(GetIbanSaveManager()) .OnUserDidDecideOnUploadSave(iban, SaveIbanOfferUserDecision::kDeclined, u"My teacher's IBAN"); histogram_tester.ExpectBucketCount( "Autofill.UploadIban.Declined", /*sample=*/ autofill_metrics::UploadIbanOriginMetric::kLocalIban, /*expected_count=*/1); } // Test that when upload is offered for a new IBAN and the offer is ignored, // `kIgnored` and `kNewIban` are logged. TEST_F(IbanSaveManagerTest, Metric_IgnoredOfferedIbanOrigin_NewIban) { base::HistogramTester histogram_tester; Iban iban; iban.set_value(base::UTF8ToUTF16(std::string(test::kIbanValue))); EXPECT_TRUE(GetIbanSaveManager().AttemptToOfferSave(iban)); test_api(GetIbanSaveManager()) .OnUserDidDecideOnUploadSave(iban, SaveIbanOfferUserDecision::kIgnored, u"My teacher's IBAN"); histogram_tester.ExpectBucketCount( "Autofill.UploadIban.Ignored", /*sample=*/autofill_metrics::UploadIbanOriginMetric::kNewIban, /*expected_count=*/1); } // Test that when upload is offered for an existing IBAN and the offer is // ignored, `kIgnored` and `kLocalIban` are logged. TEST_F(IbanSaveManagerTest, Metric_IgnoredOfferedIbanOrigin_LocalIban) { base::HistogramTester histogram_tester; SetUpGetIbanUploadDetailsResponse(/*is_successful=*/true); SetUpUploadIbanResponse(/*is_successful=*/true); Iban iban; iban.set_value(base::UTF8ToUTF16(std::string(test::kIbanValue))); personal_data().payments_data_manager().AddAsLocalIban(iban); ASSERT_TRUE(GetIbanSaveManager().AttemptToOfferSave(iban)); test_api(GetIbanSaveManager()) .OnUserDidDecideOnUploadSave(iban, SaveIbanOfferUserDecision::kIgnored, u"My teacher's IBAN"); histogram_tester.ExpectBucketCount( "Autofill.UploadIban.Ignored", /*sample=*/ autofill_metrics::UploadIbanOriginMetric::kLocalIban, /*expected_count=*/1); } TEST_F(IbanSaveManagerTest, Metric_CountryOfSaveOffered_LocalIban) { // Set the SyncService to paused state. sync_service_.SetPersistentAuthError(); base::HistogramTester histogram_tester; Iban iban; iban.set_value(u"FR7630006000011234567890189"); ASSERT_TRUE(GetIbanSaveManager().AttemptToOfferSave(iban)); histogram_tester.ExpectUniqueSample("Autofill.Iban.CountryOfSaveOfferedIban", Iban::IbanSupportedCountry::kFR, 1); } TEST_F(IbanSaveManagerTest, Metric_CountryOfSaveOffered_ServerIban) { base::HistogramTester histogram_tester; Iban iban; iban.set_value(u"FR7630006000011234567890189"); ASSERT_TRUE(GetIbanSaveManager().AttemptToOfferSave(iban)); histogram_tester.ExpectUniqueSample("Autofill.Iban.CountryOfSaveOfferedIban", Iban::IbanSupportedCountry::kFR, 1); } TEST_F(IbanSaveManagerTest, Metric_CountryOfSaveAccepted_LocalIban) { base::HistogramTester histogram_tester; Iban iban; iban.set_value(u"FR7630006000011234567890189"); EXPECT_TRUE(test_api(GetIbanSaveManager()).AttemptToOfferLocalSave(iban)); test_api(GetIbanSaveManager()) .OnUserDidDecideOnLocalSave(iban, SaveIbanOfferUserDecision::kAccepted, u"IBAN nickname"); histogram_tester.ExpectUniqueSample("Autofill.Iban.CountryOfSaveAcceptedIban", Iban::IbanSupportedCountry::kFR, 1); } TEST_F(IbanSaveManagerTest, Metric_CountryOfSaveAccepted_ServerIban) { base::HistogramTester histogram_tester; SetUpGetIbanUploadDetailsResponse(/*is_successful=*/true); SetUpUploadIbanResponse(/*is_successful=*/true); Iban iban; iban.set_value(u"FR7630006000011234567890189"); EXPECT_TRUE(GetIbanSaveManager().AttemptToOfferSave(iban)); test_api(GetIbanSaveManager()) .OnUserDidDecideOnUploadSave(iban, SaveIbanOfferUserDecision::kAccepted, u"IBAN nickname"); histogram_tester.ExpectUniqueSample("Autofill.Iban.CountryOfSaveAcceptedIban", Iban::IbanSupportedCountry::kFR, 1); } // Tests that the `RanLocalSaveFallback` metric records that a new IBAN was // saved during the local IBAN save fallback for a server upload failure. TEST_F(IbanSaveManagerTest, Metrics_OnUploadIban_FallbackToLocalSave_NewIbanAdded) { base::HistogramTester histogram_tester; Iban iban; iban.set_value(std::u16string(test::kIbanValue16)); ASSERT_TRUE(personal_data().payments_data_manager().GetLocalIbans().empty()); test_api(GetIbanSaveManager()) .OnDidUploadIban(std::make_unique(iban), /*show_save_prompt=*/true, payments::PaymentsAutofillClient::PaymentsRpcResult:: kPermanentFailure); histogram_tester.ExpectUniqueSample("Autofill.IbanUpload.SaveFailed", true, 1); EXPECT_EQ(personal_data().payments_data_manager().GetLocalIbans().size(), 1U); } // Tests that the `RanLocalSaveFallback` metric records that an existing local // IBAN was not saved during the local IBAN save fallback for a server upload // failure. TEST_F(IbanSaveManagerTest, Metrics_OnUploadIban_FallbackToLocalSave_LocalIbanNotAdded) { base::HistogramTester histogram_tester; Iban iban; iban.set_value(std::u16string(test::kIbanValue16)); personal_data().payments_data_manager().AddAsLocalIban(iban); ASSERT_EQ(personal_data().payments_data_manager().GetLocalIbans().size(), 1U); test_api(GetIbanSaveManager()) .OnDidUploadIban(std::make_unique(iban), /*show_save_prompt=*/true, payments::PaymentsAutofillClient::PaymentsRpcResult:: kPermanentFailure); histogram_tester.ExpectUniqueSample("Autofill.IbanUpload.SaveFailed", false, 1); EXPECT_EQ(personal_data().payments_data_manager().GetLocalIbans().size(), 1U); } // Tests that the `RanLocalSaveFallback` metric records that a matched local // IBAN (same IBAN value but different nickname) was not saved during the local // IBAN save fallback for a server upload failure. TEST_F( IbanSaveManagerTest, Metrics_OnUploadIban_FallbackToLocalSave_LocalIbanWithDifferentNicknameNotAdded) { base::HistogramTester histogram_tester; Iban iban; iban.set_value(std::u16string(test::kIbanValue16)); personal_data().payments_data_manager().AddAsLocalIban(iban); ASSERT_EQ(personal_data().payments_data_manager().GetLocalIbans().size(), 1U); iban.set_nickname(u"new nickname"); test_api(GetIbanSaveManager()) .OnDidUploadIban(std::make_unique(iban), /*show_save_prompt=*/true, payments::PaymentsAutofillClient::PaymentsRpcResult:: kPermanentFailure); histogram_tester.ExpectUniqueSample("Autofill.IbanUpload.SaveFailed", false, 1); EXPECT_EQ(personal_data().payments_data_manager().GetLocalIbans().size(), 1U); EXPECT_EQ( personal_data().payments_data_manager().GetLocalIbans()[0]->nickname(), u""); } // Tests that overlapping upload flows preserve independent context tokens and // IBAN candidates. TEST_F(IbanSaveManagerTest, UploadSaveIban_OverlappingUploadFlows) { Iban iban1; iban1.set_value(std::u16string(test::kIbanValue16)); Iban iban2; iban2.set_value(u"CH56 0483 5012 3456 7800 9"); EXPECT_CALL(*payments_network_interface(), GetIbanUploadDetails) .WillOnce(base::test::RunOnceCallback<4>( payments::PaymentsAutofillClient::PaymentsRpcResult::kSuccess, kCapitalizedIbanRegex, u"token1", std::make_unique(*base::JSONReader::ReadDict( kLegalMessageLines, base::JSON_PARSE_CHROMIUM_EXTENSIONS)))) .WillOnce(base::test::RunOnceCallback<4>( payments::PaymentsAutofillClient::PaymentsRpcResult::kSuccess, kCapitalizedIbanRegex, u"token2", std::make_unique(*base::JSONReader::ReadDict( kLegalMessageLines, base::JSON_PARSE_CHROMIUM_EXTENSIONS)))); EXPECT_CALL( *payments_network_interface(), UploadIban(AllOf(Field(&payments::UploadIbanRequestDetails::value, iban1.value()), Field(&payments::UploadIbanRequestDetails::context_token, u"token1")), _)) .WillOnce(base::test::RunOnceCallback<1>( payments::PaymentsAutofillClient::PaymentsRpcResult::kSuccess)); EXPECT_TRUE(test_api(GetIbanSaveManager()).AttemptToOfferUploadSave(iban1)); EXPECT_TRUE(test_api(GetIbanSaveManager()).AttemptToOfferUploadSave(iban2)); ASSERT_EQ(autofill_client_.GetPaymentsAutofillClient() ->confirm_upload_iban_to_cloud_callbacks() .size(), 2U); std::move(autofill_client_.GetPaymentsAutofillClient() ->confirm_upload_iban_to_cloud_callbacks()[0]) .Run(payments::PaymentsAutofillClient::SaveIbanOfferUserDecision:: kAccepted, u"My IBAN"); } // Tests that when the user accepts the upload save prompt BEFORE risk data // finishes loading, the upload request is sent cleanly once risk data arrives. TEST_F(IbanSaveManagerTest, UploadSaveIban_UserAcceptsBeforeRiskDataReady) { Iban iban; iban.set_value(std::u16string(test::kIbanValue16)); SetUpGetIbanUploadDetailsResponse(/*is_successful=*/true); autofill_client_.GetPaymentsAutofillClient() ->set_defer_load_risk_data_responses(true); EXPECT_CALL( *payments_network_interface(), UploadIban( AllOf(Field(&payments::UploadIbanRequestDetails::value, iban.value()), Field(&payments::UploadIbanRequestDetails::risk_data, "delayed risk data")), _)) .WillOnce(base::test::RunOnceCallback<1>( payments::PaymentsAutofillClient::PaymentsRpcResult::kSuccess)); EXPECT_TRUE(test_api(GetIbanSaveManager()).AttemptToOfferUploadSave(iban)); ASSERT_EQ(autofill_client_.GetPaymentsAutofillClient() ->confirm_upload_iban_to_cloud_callbacks() .size(), 1U); ASSERT_EQ(autofill_client_.GetPaymentsAutofillClient() ->load_risk_data_callbacks() .size(), 1U); // 1. User accepts prompt FIRST (before risk data is ready). std::move(autofill_client_.GetPaymentsAutofillClient() ->confirm_upload_iban_to_cloud_callbacks()[0]) .Run(payments::PaymentsAutofillClient::SaveIbanOfferUserDecision:: kAccepted, u"My IBAN"); // 2. Risk data finishes loading SECOND. std::move(autofill_client_.GetPaymentsAutofillClient() ->load_risk_data_callbacks()[0]) .Run("delayed risk data"); } #endif // !BUILDFLAG(IS_ANDROID) && !BUILDFLAG(IS_IOS) } // namespace } // namespace autofill