// Copyright 2025 The Chromium Authors // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. #include #include "base/strings/strcat.h" #include "base/test/metrics/histogram_tester.h" #include "base/test/scoped_feature_list.h" #include "base/test/test_future.h" #include "chrome/browser/apps/app_service/app_registry_cache_waiter.h" #include "chrome/browser/apps/link_capturing/link_capturing_feature_test_support.h" #include "chrome/browser/ui/browser_commands.h" #include "chrome/browser/ui/browser_tabstrip.h" #include "chrome/browser/ui/browser_window/public/browser_window_interface.h" #include "chrome/browser/ui/navigator/browser_navigator.h" #include "chrome/browser/ui/navigator/browser_navigator_params.h" #include "chrome/browser/ui/navigator/browser_navigator_params_utils.h" #include "chrome/browser/ui/views/frame/browser_view.h" #include "chrome/browser/ui/web_applications/navigation_capturing_process.h" #include "chrome/browser/ui/web_applications/test/web_app_browsertest_util.h" #include "chrome/browser/ui/web_applications/web_app_browser_controller.h" #include "chrome/browser/ui/web_applications/web_app_browsertest_base.h" #include "chrome/browser/ui/web_applications/web_app_launch_navigation_handle_user_data.h" #include "chrome/browser/web_applications/mojom/user_display_mode.mojom-shared.h" #include "chrome/browser/web_applications/navigation_capturing_metrics.h" #include "chrome/browser/web_applications/test/web_app_install_test_utils.h" #include "chrome/browser/web_applications/web_app_command_scheduler.h" #include "chrome/browser/web_applications/web_app_provider.h" #include "chrome/test/base/in_process_browser_test.h" #include "chrome/test/base/ui_test_utils.h" #include "components/metrics/content/subprocess_metrics_provider.h" #include "components/webapps/common/web_app_id.h" #include "content/public/browser/navigation_controller.h" #include "content/public/browser/render_frame_host.h" #include "content/public/browser/web_contents.h" #include "content/public/test/browser_test.h" #include "content/public/test/browser_test_utils.h" #include "third_party/blink/public/common/features_generated.h" #include "third_party/blink/public/mojom/manifest/manifest_launch_handler.mojom-shared.h" #include "ui/base/window_open_disposition.h" namespace web_app { namespace { constexpr char kLandingPage[] = "/web_apps/simple/index.html"; constexpr char kFinalPage[] = "/web_apps/simple/index2.html"; constexpr char kRedirectFromPage[] = "/web_apps/simple2/index.html"; constexpr char kAppNoManifestUrl[] = "/web_apps/no_manifest.html"; constexpr char kNavigateExistingUrl[] = "/web_apps/simple_navigate_existing/index.html"; constexpr char kNavigateExistingSecondUrl[] = "/web_apps/simple_navigate_existing/index2.html"; constexpr char kFocusExistingUrl[] = "/web_apps/simple_focus_existing/index.html"; constexpr char kFocusExistingSecondUrl[] = "/web_apps/simple_focus_existing/index2.html"; constexpr char kDisplayBrowserUrl[] = "/web_apps/display_browser.html"; constexpr char kLaunchParamsEnqueueMetricWithNavigation[] = "Webapp.NavigationCapturing.LaunchParamsConsumedTime.WithNavigation"; constexpr char kLaunchParamsEnqueueMetricWithoutNavigation[] = "Webapp.NavigationCapturing.LaunchParamsConsumedTime.WithoutNavigation"; class NavigationCapturingBrowserNavigatorBrowserTest : public WebAppBrowserTestBase { public: NavigationCapturingBrowserNavigatorBrowserTest() { enabled_features = apps::test::GetFeaturesToEnableLinkCapturingUX( apps::test::LinkCapturingFeatureVersion::kV2DefaultOn); enabled_features.emplace_back(blink::features::kDesktopPWAsTabStrip, base::FieldTrialParams()); enabled_features.emplace_back( blink::features::kDesktopPWAsTabStripCustomizations, base::FieldTrialParams()); feature_list_.InitWithFeaturesAndParameters( /*enabled_features=*/enabled_features, /*disabled_features=*/{}); } void SetUpOnMainThread() override { WebAppBrowserTestBase::SetUpOnMainThread(); ASSERT_TRUE(embedded_test_server()->Start()); } GURL GetLandingPage() const { return embedded_test_server()->GetURL(kLandingPage); } GURL GetFinalPage() const { return embedded_test_server()->GetURL(kFinalPage); } GURL GetAppNoManifestUrl() const { return embedded_test_server()->GetURL(kAppNoManifestUrl); } GURL GetNavigateExistingUrl() const { return embedded_test_server()->GetURL(kNavigateExistingUrl); } GURL GetNavigateExistingSecondUrl() const { return embedded_test_server()->GetURL(kNavigateExistingSecondUrl); } GURL GetFocusExistingUrl() const { return embedded_test_server()->GetURL(kFocusExistingUrl); } GURL GetFocusExistingSecondUrl() const { return embedded_test_server()->GetURL(kFocusExistingSecondUrl); } GURL GetDisplayBrowserUrl() const { return embedded_test_server()->GetURL(kDisplayBrowserUrl); } // InstallTestWebApp should not be called with a url that has a manifest link. // This may cause flaky tests as it will be susceptible to manifest update as // soon as url loads. Instead, consider using test::InstallWebApp(). webapps::AppId InstallTestWebApp( const GURL& start_url, mojom::UserDisplayMode user_display_mode, blink::mojom::ManifestLaunchHandler_ClientMode client_mode = blink::mojom::ManifestLaunchHandler_ClientMode::kAuto) { auto web_app_info = WebAppInstallInfo::CreateWithStartUrlForTesting(start_url); web_app_info->scope = start_url.GetWithoutFilename(); web_app_info->user_display_mode = user_display_mode; web_app_info->launch_handler = blink::Manifest::LaunchHandler(client_mode); const webapps::AppId app_id = test::InstallWebApp(profile(), std::move(web_app_info)); return app_id; } std::pair GetTwoDistinctBrowsersForSameApp(const webapps::AppId& app_id, const GURL& url_to_navigate_to) { // First, launch an app browser. BrowserWindowInterface* app_browser_to_use = LaunchWebAppBrowser(app_id); // Second, create another app browser (LaunchWebAppBrowser() will not work // since the launch handling mode makes it look for an existing instance). // Mimic navigation capturing via shift click into a new window. BrowserWindowInterface* second_app_browser = nullptr; { NavigateParams params(app_browser_to_use, url_to_navigate_to, ui::PAGE_TRANSITION_LINK); params.disposition = WindowOpenDisposition::NEW_WINDOW; Navigate(¶ms); second_app_browser = params.browser; } EXPECT_NE(nullptr, second_app_browser); EXPECT_NE(second_app_browser, app_browser_to_use); test::CompletePageLoadForAllWebContents(); return {app_browser_to_use, second_app_browser}; } protected: void AwaitMetricsAvailableFromRenderer() { content::FetchHistogramsFromChildProcesses(); metrics::SubprocessMetricsProvider::MergeHistogramDeltasForTesting(); } std::vector GetNavigationCapturingFinalDisplayMetric( const base::HistogramTester& tester) { std::vector display_result_buckets = tester.GetAllSamples("Webapp.NavigationCapturing.FinalDisplay.Result"); std::vector bucket_list; for (const base::Bucket& bucket : display_result_buckets) { for (int count = 0; count < bucket.count; count++) { bucket_list.push_back( static_cast(bucket.min)); } } return bucket_list; } base::test::ScopedFeatureList feature_list_; std::vector enabled_features; }; IN_PROC_BROWSER_TEST_F(NavigationCapturingBrowserNavigatorBrowserTest, NavigateBrowserUserForBrowserTabAppLaunch) { // Test that the browser provided in NavigateParams is used when using a // browser to open a browser tab app in a tab, instead of the most recently // active browser. const webapps::AppId& app_id = InstallWebAppInNewTabAndClose(browser(), GetLandingPage()); // Change the web app's user display mode to kBrowser base::test::TestFuture future; provider().scheduler().SetUserDisplayMode( app_id, mojom::UserDisplayMode::kBrowser, future.GetCallback()); ASSERT_TRUE(future.Wait()); base::HistogramTester histograms; // Create a new browser which will be considered the most recently active one. BrowserWindowInterface* new_browser = ui_test_utils::OpenNewEmptyWindowAndWaitUntilActivated(profile()); chrome::NewTab(new_browser, NewTabTypes::kNoUserAction); // Do a capturable navigation to the landing page, and ensure that it opens in // the browser(). ui_test_utils::AllBrowserTabAddedWaiter new_tab_observer; NavigateParams params(browser(), GetLandingPage(), ui::PAGE_TRANSITION_LINK); params.source_contents = new_browser->tab_strip_model()->GetActiveWebContents(); params.disposition = WindowOpenDisposition::NEW_FOREGROUND_TAB; Navigate(¶ms); content::WebContents* new_tab = new_tab_observer.Wait(); content::WaitForLoadStop(new_tab); apps::test::FlushLaunchQueuesForAllBrowserTabs(); AwaitMetricsAvailableFromRenderer(); // Ensure that capturing happened. histograms.ExpectUniqueSample( "WebApp.LaunchSource", apps::LaunchSource::kFromNavigationCapturing, 1); histograms.ExpectTotalCount(kLaunchParamsEnqueueMetricWithNavigation, 1); EXPECT_THAT( GetNavigationCapturingFinalDisplayMetric(histograms), testing::ElementsAre( NavigationCapturingDisplayModeResult::kAppBrowserTabFinalBrowserTab)); ASSERT_TRUE(new_tab); // Make sure that web contents is a tab in `browser()` and not `new_browser`. EXPECT_NE(browser()->tab_strip_model()->GetIndexOfWebContents(new_tab), TabStripModel::kNoTab); } IN_PROC_BROWSER_TEST_F(NavigationCapturingBrowserNavigatorBrowserTest, MiddleClickToOpenBrowserAppFromDifferentWindow) { const webapps::AppId& app_id = InstallTestWebApp( GetDisplayBrowserUrl(), mojom::UserDisplayMode::kBrowser, blink::mojom::ManifestLaunchHandler_ClientMode::kNavigateExisting); EXPECT_EQ(apps::test::EnableLinkCapturingByUser(profile(), app_id), base::ok()); // Use LaunchBrowserForWebAppInTab to ensure the app is recognized as running. // This opens the app in a tab (since it's forced to kBrowser). BrowserWindowInterface* app_browser = ::web_app::LaunchBrowserForWebAppInTab(profile(), app_id); ASSERT_TRUE(app_browser); content::WebContents* new_tab = app_browser->tab_strip_model()->GetActiveWebContents(); ASSERT_TRUE(new_tab); content::WaitForLoadStop(new_tab); apps::test::FlushLaunchQueuesForAllBrowserTabs(); AwaitMetricsAvailableFromRenderer(); BrowserWindowInterface* new_browser = ui_test_utils::OpenNewEmptyWindowAndWaitUntilActivated(profile()); ASSERT_TRUE( ui_test_utils::NavigateToURL(new_browser, GURL(url::kAboutBlankURL))); base::HistogramTester histograms; ui_test_utils::AllBrowserTabAddedWaiter new_tab_observer2; NavigateParams params2(new_browser, GetDisplayBrowserUrl(), ui::PAGE_TRANSITION_LINK); params2.source_contents = new_browser->tab_strip_model()->GetActiveWebContents(); params2.disposition = WindowOpenDisposition::NEW_BACKGROUND_TAB; Navigate(¶ms2); content::WebContents* new_tab2 = new_tab_observer2.Wait(); ASSERT_TRUE(new_tab2); content::WaitForLoadStop(new_tab2); apps::test::FlushLaunchQueuesForAllBrowserTabs(); AwaitMetricsAvailableFromRenderer(); histograms.ExpectUniqueSample( "WebApp.LaunchSource", apps::LaunchSource::kFromNavigationCapturing, 1); histograms.ExpectUniqueSample( "Webapp.NavigationCapturing.Result", NavigationCapturingInitialResult::kForcedContextAppBrowserTab, 1); histograms.ExpectTotalCount(kLaunchParamsEnqueueMetricWithNavigation, 0); EXPECT_THAT( GetNavigationCapturingFinalDisplayMetric(histograms), testing::ElementsAre( NavigationCapturingDisplayModeResult::kAppBrowserTabFinalBrowserTab)); int index = new_browser->tab_strip_model()->GetIndexOfWebContents(new_tab2); EXPECT_NE(index, TabStripModel::kNoTab); } // Test that the browser provided in NavigateParams is used when finding an app // window for navigation capturing to happen for navigate-existing, provided the // `app_id` is the same. IN_PROC_BROWSER_TEST_F(NavigationCapturingBrowserNavigatorBrowserTest, NavigateBrowserUsedForNavigateExistingAppWindow) { const webapps::AppId& app_id = InstallWebAppInNewTabAndClose(browser(), GetNavigateExistingUrl()); BrowserWindowInterface* app_browser_1 = nullptr; BrowserWindowInterface* app_browser_2 = nullptr; std::tie(app_browser_1, app_browser_2) = GetTwoDistinctBrowsersForSameApp(app_id, GetNavigateExistingUrl()); EXPECT_TRUE(WebAppBrowserController::IsForWebApp(app_browser_1, app_id)); EXPECT_TRUE(WebAppBrowserController::IsForWebApp(app_browser_2, app_id)); // Do a capturable navigation to the landing page, and ensure that it opens in // `app_browser_1`. base::HistogramTester histograms; ui_test_utils::UrlLoadObserver url_observer(GetNavigateExistingSecondUrl()); { NavigateParams params(app_browser_1, GetNavigateExistingSecondUrl(), ui::PAGE_TRANSITION_LINK); params.disposition = WindowOpenDisposition::NEW_FOREGROUND_TAB; params.source_contents = browser()->tab_strip_model()->GetActiveWebContents(); Navigate(¶ms); content::NavigationController::LoadURLParams load_url_params = LoadURLParamsFromNavigateParams(¶ms); (void)params.navigated_or_inserted_contents->GetController() .LoadURLWithParams(load_url_params); } url_observer.Wait(); apps::test::FlushLaunchQueuesForAllBrowserTabs(); AwaitMetricsAvailableFromRenderer(); content::WebContents* contents_navigation_happened_in = url_observer.web_contents(); EXPECT_NE(contents_navigation_happened_in, app_browser_2->tab_strip_model()->GetActiveWebContents()); EXPECT_EQ(contents_navigation_happened_in, app_browser_1->tab_strip_model()->GetActiveWebContents()); // Ensure that capturing happened. histograms.ExpectUniqueSample( "WebApp.LaunchSource", apps::LaunchSource::kFromNavigationCapturing, 1); EXPECT_THAT( GetNavigationCapturingFinalDisplayMetric(histograms), testing::ElementsAre( NavigationCapturingDisplayModeResult::kAppStandaloneFinalStandalone)); // This is measured twice, once for each launch param obtained. histograms.ExpectTotalCount(kLaunchParamsEnqueueMetricWithNavigation, 2); } // Test that the browser provided in NavigateParams is used when finding an app // window for navigation capturing to happen for focus-existing, provided the // `app_id` is the same. IN_PROC_BROWSER_TEST_F(NavigationCapturingBrowserNavigatorBrowserTest, NavigateBrowserUsedForFocusExistingAppWindow) { const webapps::AppId& app_id = InstallWebAppInNewTabAndClose(browser(), GetFocusExistingUrl()); // Launch 2 distinct app_browsers for the same app_id. Since `app_browser_2` // is created last, ensure that is activated. BrowserWindowInterface* app_browser_1 = nullptr; BrowserWindowInterface* app_browser_2 = nullptr; std::tie(app_browser_1, app_browser_2) = GetTwoDistinctBrowsersForSameApp(app_id, GetFocusExistingUrl()); EXPECT_TRUE(WebAppBrowserController::IsForWebApp(app_browser_1, app_id)); EXPECT_TRUE(WebAppBrowserController::IsForWebApp(app_browser_2, app_id)); // Do a capturable navigation to the landing page, and ensure that it opens in // `app_browser_1`. Since the web_app has a client_mode of `focus-existing`, // `app_browser_1` should be activated with no navigations happening. base::HistogramTester histograms; { NavigateParams params(app_browser_1, GetFocusExistingSecondUrl(), ui::PAGE_TRANSITION_LINK); params.source_contents = browser()->tab_strip_model()->GetActiveWebContents(); params.disposition = WindowOpenDisposition::NEW_FOREGROUND_TAB; Navigate(¶ms); } test::CompletePageLoadForAllWebContents(); apps::test::FlushLaunchQueuesForAllBrowserTabs(); AwaitMetricsAvailableFromRenderer(); content::WebContents* contents_to_finish = app_browser_1->tab_strip_model()->GetActiveWebContents(); // `kFocusExistingUrl` should be obtained first when the browser is launched, // and `kFocusExistingSecondUrl` is added later when navigation capturing // happens. EXPECT_THAT( apps::test::GetLaunchParamUrlsInContents(contents_to_finish, "launchParamsTargetUrls"), testing::ElementsAre(GetFocusExistingUrl(), GetFocusExistingSecondUrl())); // `app_browser_1` should still be at the starting page. EXPECT_EQ(GetFocusExistingUrl(), app_browser_1->tab_strip_model() ->GetActiveWebContents() ->GetLastCommittedURL()); histograms.ExpectUniqueSample( "WebApp.LaunchSource", apps::LaunchSource::kFromNavigationCapturing, 1); EXPECT_THAT( GetNavigationCapturingFinalDisplayMetric(histograms), testing::ElementsAre( NavigationCapturingDisplayModeResult::kAppStandaloneFinalStandalone)); // This is measured twice, once for each launch param obtained. The first // metric is measured when the navigate-existing container enqueues the launch // params, while the 2nd metric is measured when the focus-existing container // does so. histograms.ExpectTotalCount(kLaunchParamsEnqueueMetricWithNavigation, 1); histograms.ExpectTotalCount(kLaunchParamsEnqueueMetricWithoutNavigation, 1); } IN_PROC_BROWSER_TEST_F(NavigationCapturingBrowserNavigatorBrowserTest, FocusExistingUsesLatestActivatedAppWindow) { const webapps::AppId& app_id = InstallWebAppInNewTabAndClose(browser(), GetFocusExistingUrl()); // Launch 2 distinct app_browsers for the same app_id. Since `app_browser_2` // is created last, ensure that is activated, and will be used for launching // a web app. BrowserWindowInterface* app_browser_1 = nullptr; BrowserWindowInterface* app_browser_2 = nullptr; std::tie(app_browser_1, app_browser_2) = GetTwoDistinctBrowsersForSameApp(app_id, GetFocusExistingUrl()); EXPECT_TRUE(WebAppBrowserController::IsForWebApp(app_browser_1, app_id)); EXPECT_TRUE(WebAppBrowserController::IsForWebApp(app_browser_2, app_id)); // Since the web_app has a client_mode of `focus-existing`, `app_browser_2` // should be activated with no navigations happening. { NavigateParams params(browser()->GetProfile(), GetFocusExistingSecondUrl(), ui::PAGE_TRANSITION_LINK); params.source_contents = browser()->tab_strip_model()->GetActiveWebContents(); params.disposition = WindowOpenDisposition::NEW_FOREGROUND_TAB; Navigate(¶ms); } test::CompletePageLoadForAllWebContents(); apps::test::FlushLaunchQueuesForAllBrowserTabs(); content::WebContents* contents_to_finish = app_browser_2->tab_strip_model()->GetActiveWebContents(); // `kFocusExistingUrl` should be obtained first when the browser is launched, // and `kFocusExistingSecondUrl` is added later when navigation capturing // happens. EXPECT_THAT( apps::test::GetLaunchParamUrlsInContents(contents_to_finish, "launchParamsTargetUrls"), testing::ElementsAre(GetFocusExistingUrl(), GetFocusExistingSecondUrl())); // `app_browser_2` should still be at the starting page. EXPECT_EQ(GetFocusExistingUrl(), app_browser_2->tab_strip_model() ->GetActiveWebContents() ->GetLastCommittedURL()); } IN_PROC_BROWSER_TEST_F(NavigationCapturingBrowserNavigatorBrowserTest, FocusExistingWithBrowserAvoidsOutOfScope) { const webapps::AppId& app_id = InstallWebAppInNewTabAndClose(browser(), GetFocusExistingUrl()); GURL out_of_scope = embedded_test_server()->GetURL("/web_apps/simple2/index.html"); // Open the browser and navigate to out-of-scope url. BrowserWindowInterface* app_browser = LaunchWebAppBrowser(app_id); ASSERT_TRUE(ui_test_utils::NavigateToURL(app_browser, out_of_scope)); content::WaitForLoadStop( app_browser->tab_strip_model()->GetActiveWebContents()); // Populate the browser for a focus-existing navigation, which should reject // it because the current web contents is not in-scope of the app. And thus // create a new window. base::HistogramTester histograms; ui_test_utils::BrowserCreatedObserver browser_created_observer; { NavigateParams params(app_browser, GetFocusExistingUrl(), ui::PAGE_TRANSITION_LINK); params.source_contents = browser()->tab_strip_model()->GetActiveWebContents(); params.disposition = WindowOpenDisposition::NEW_FOREGROUND_TAB; Navigate(¶ms); } BrowserWindowInterface* new_app_browser = browser_created_observer.Wait(); test::CompletePageLoadForAllWebContents(); apps::test::FlushLaunchQueuesForAllBrowserTabs(); AwaitMetricsAvailableFromRenderer(); EXPECT_EQ(out_of_scope, app_browser->tab_strip_model() ->GetActiveWebContents() ->GetLastCommittedURL()); EXPECT_EQ(GetFocusExistingUrl(), new_app_browser->tab_strip_model() ->GetActiveWebContents() ->GetLastCommittedURL()); histograms.ExpectUniqueSample( "WebApp.LaunchSource", apps::LaunchSource::kFromNavigationCapturing, 1); histograms.ExpectTotalCount(kLaunchParamsEnqueueMetricWithNavigation, 1); EXPECT_THAT( GetNavigationCapturingFinalDisplayMetric(histograms), testing::ElementsAre( NavigationCapturingDisplayModeResult::kAppStandaloneFinalStandalone)); } IN_PROC_BROWSER_TEST_F(NavigationCapturingBrowserNavigatorBrowserTest, NavigateExistingIgnoresNonHtml) { const webapps::AppId app_id = InstallWebAppInNewTabAndClose(browser(), GetFocusExistingUrl()); GURL image_url = embedded_test_server()->GetURL( "/web_apps/simple_focus_existing/basic-48.png"); // Open the browser and navigate to an in-scope image (non-html item); BrowserWindowInterface* app_browser = LaunchWebAppBrowser(app_id); ASSERT_TRUE(ui_test_utils::NavigateToURL(app_browser, image_url)); content::WaitForLoadStop( app_browser->tab_strip_model()->GetActiveWebContents()); // Do a capturable navigation to the landing page, and ensure that it opens in // a new browser; base::HistogramTester histograms; ui_test_utils::BrowserCreatedObserver browser_created_observer; { NavigateParams params(browser(), GetFocusExistingUrl(), ui::PAGE_TRANSITION_LINK); params.source_contents = browser()->tab_strip_model()->GetActiveWebContents(); params.disposition = WindowOpenDisposition::NEW_FOREGROUND_TAB; Navigate(¶ms); } BrowserWindowInterface* new_app_browser = browser_created_observer.Wait(); test::CompletePageLoadForAllWebContents(); apps::test::FlushLaunchQueuesForAllBrowserTabs(); AwaitMetricsAvailableFromRenderer(); EXPECT_EQ(image_url, app_browser->tab_strip_model() ->GetActiveWebContents() ->GetLastCommittedURL()); EXPECT_EQ(GetFocusExistingUrl(), new_app_browser->tab_strip_model() ->GetActiveWebContents() ->GetLastCommittedURL()); histograms.ExpectUniqueSample( "WebApp.LaunchSource", apps::LaunchSource::kFromNavigationCapturing, 1); histograms.ExpectTotalCount(kLaunchParamsEnqueueMetricWithNavigation, 1); EXPECT_THAT( GetNavigationCapturingFinalDisplayMetric(histograms), testing::ElementsAre( NavigationCapturingDisplayModeResult::kAppStandaloneFinalStandalone)); } // This test is flaky on the Mac 13 bot. // TODO(crbug.com/447403523): Enable the test on Mac bots. #if BUILDFLAG(IS_MAC) #define MAYBE_NavigateBrowserUsedForNavigateExistingToBrowserTab \ DISABLED_NavigateBrowserUsedForNavigateExistingToBrowserTab #else #define MAYBE_NavigateBrowserUsedForNavigateExistingToBrowserTab \ NavigateBrowserUsedForNavigateExistingToBrowserTab #endif IN_PROC_BROWSER_TEST_F( NavigationCapturingBrowserNavigatorBrowserTest, MAYBE_NavigateBrowserUsedForNavigateExistingToBrowserTab) { // Test that the browser provided in NavigateParams is used when using a // browser to open a browser tab, instead of the most recently active browser. const webapps::AppId& app_id = InstallTestWebApp( GetAppNoManifestUrl(), mojom::UserDisplayMode::kBrowser, blink::mojom::ManifestLaunchHandler_ClientMode::kNavigateExisting); // Navigate to GetAppUrl() in browser() so that a browser tab for the app_id // exists. ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), GetAppNoManifestUrl())); content::WaitForLoadStop( browser()->tab_strip_model()->GetActiveWebContents()); const content::WebContents* contents = browser()->tab_strip_model()->GetActiveWebContents(); int tab_index = browser()->tab_strip_model()->GetIndexOfWebContents(contents); int tab_count_for_browser = browser()->tab_strip_model()->count(); // Create a new browser which will be considered the most recently active // one. BrowserWindowInterface* new_browser = ui_test_utils::OpenNewEmptyWindowAndWaitUntilActivated(profile()); chrome::NewTab(new_browser, NewTabTypes::kNoUserAction); // Do a capturable navigation to the landing page, and ensure that it // opens in the browser(). base::HistogramTester histograms; ui_test_utils::UrlLoadObserver url_observer(GetFinalPage()); { NavigateParams params(browser(), GetFinalPage(), ui::PAGE_TRANSITION_LINK); params.source_contents = new_browser->tab_strip_model()->GetActiveWebContents(); params.disposition = WindowOpenDisposition::NEW_FOREGROUND_TAB; Navigate(¶ms); content::NavigationController::LoadURLParams load_url_params = LoadURLParamsFromNavigateParams(¶ms); (void)params.navigated_or_inserted_contents->GetController() .LoadURLWithParams(load_url_params); } test::CompletePageLoadForAllWebContents(); url_observer.Wait(); apps::test::FlushLaunchQueuesForAllBrowserTabs(); AwaitMetricsAvailableFromRenderer(); content::WebContents* contents_navigation_happened_in = url_observer.web_contents(); // Ensure that capturing happened. histograms.ExpectUniqueSample( "WebApp.LaunchSource", apps::LaunchSource::kFromNavigationCapturing, 1); histograms.ExpectTotalCount(kLaunchParamsEnqueueMetricWithNavigation, 1); EXPECT_THAT( GetNavigationCapturingFinalDisplayMetric(histograms), testing::ElementsAre( NavigationCapturingDisplayModeResult::kAppBrowserTabFinalBrowserTab)); EXPECT_NE(contents_navigation_happened_in, new_browser->tab_strip_model()->GetActiveWebContents()); EXPECT_EQ(contents_navigation_happened_in, browser()->tab_strip_model()->GetActiveWebContents()); EXPECT_EQ(tab_index, browser()->tab_strip_model()->GetIndexOfWebContents( contents_navigation_happened_in)); EXPECT_EQ(tab_count_for_browser, browser()->tab_strip_model()->count()); } IN_PROC_BROWSER_TEST_F(NavigationCapturingBrowserNavigatorBrowserTest, NavigateBrowserUsedForFocusExistingToBrowserTab) { // Test that the browser provided in NavigateParams is used when using a // browser to open a browser tab, instead of the most recently active browser. const webapps::AppId& app_id = InstallTestWebApp( GetAppNoManifestUrl(), mojom::UserDisplayMode::kBrowser, blink::mojom::ManifestLaunchHandler_ClientMode::kFocusExisting); // Navigate to GetAppUrl() in browser() so that a browser tab for the // app_id exists. ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), GetAppNoManifestUrl())); content::WaitForLoadStop( browser()->tab_strip_model()->GetActiveWebContents()); int tab_count_for_browser = browser()->tab_strip_model()->count(); // Create a new browser which will be considered the most recently active // one. BrowserWindowInterface* new_browser = ui_test_utils::OpenNewEmptyWindowAndWaitUntilActivated(profile()); chrome::NewTab(new_browser, NewTabTypes::kNoUserAction); // Do a capturable navigation to the landing page, and ensure that it opens in // browser(). Since the web_app has a client_mode of `focus-existing`, // browser() should be activated with no navigations happening. base::HistogramTester histograms; { NavigateParams params(browser(), GetFinalPage(), ui::PAGE_TRANSITION_LINK); params.source_contents = new_browser->tab_strip_model()->GetActiveWebContents(); params.disposition = WindowOpenDisposition::NEW_FOREGROUND_TAB; Navigate(¶ms); } test::CompletePageLoadForAllWebContents(); apps::test::FlushLaunchQueuesForAllBrowserTabs(); AwaitMetricsAvailableFromRenderer(); // Ensure that capturing happened. histograms.ExpectUniqueSample( "WebApp.LaunchSource", apps::LaunchSource::kFromNavigationCapturing, 1); // With the absence of a consumer set on the site, launch params will not be // enqueued, and hence this metric will not be measured. histograms.ExpectTotalCount(kLaunchParamsEnqueueMetricWithNavigation, 0); EXPECT_THAT( GetNavigationCapturingFinalDisplayMetric(histograms), testing::ElementsAre( NavigationCapturingDisplayModeResult::kAppBrowserTabFinalBrowserTab)); // browser() should still be at the GetAppUrl() page. EXPECT_EQ(GetAppNoManifestUrl(), browser() ->tab_strip_model() ->GetActiveWebContents() ->GetLastCommittedURL()); EXPECT_EQ(tab_count_for_browser, browser()->tab_strip_model()->count()); } IN_PROC_BROWSER_TEST_F( NavigationCapturingBrowserNavigatorBrowserTest, NavigateBrowserUsedForNavigateExistingToAppBrowserTabStandalone) { // Test that the app browser provided in NavigateParams is used even if a // separate browser is populated with a matching tab. const webapps::AppId& app_id = InstallWebAppInNewTabAndClose(browser(), GetNavigateExistingUrl()); // Launch app in an app browser that will be passed in as the browser for // NavigateParams. BrowserWindowInterface* app_browser_to_use = LaunchWebAppBrowser(app_id); // Change the web app's user display mode to kBrowser base::test::TestFuture future; provider().scheduler().SetUserDisplayMode( app_id, mojom::UserDisplayMode::kBrowser, future.GetCallback()); ASSERT_TRUE(future.Wait()); // Navigate to GetNavigateExistingUrl in browser() so that a browser tab for // the app_id exists. ASSERT_TRUE( ui_test_utils::NavigateToURL(browser(), GetNavigateExistingUrl())); content::WebContents* blank_new_tab = chrome::AddAndReturnTabAt( browser(), GURL(url::kAboutBlankURL), /*index=*/0, /*foreground=*/true); content::WaitForLoadStop( browser()->tab_strip_model()->GetActiveWebContents()); // Do a capturable navigation to the landing page, and ensure that it // opens in the app_browser_to_use instead of browser(). base::HistogramTester histograms; ui_test_utils::UrlLoadObserver url_observer(GetNavigateExistingSecondUrl()); { NavigateParams params(app_browser_to_use, GetNavigateExistingSecondUrl(), ui::PAGE_TRANSITION_LINK); params.source_contents = blank_new_tab; params.disposition = WindowOpenDisposition::NEW_FOREGROUND_TAB; Navigate(¶ms); content::NavigationController::LoadURLParams load_url_params = LoadURLParamsFromNavigateParams(¶ms); (void)params.navigated_or_inserted_contents->GetController() .LoadURLWithParams(load_url_params); } test::CompletePageLoadForAllWebContents(); url_observer.Wait(); apps::test::FlushLaunchQueuesForAllBrowserTabs(); AwaitMetricsAvailableFromRenderer(); content::WebContents* contents_navigation_happened_in = url_observer.web_contents(); EXPECT_NE(contents_navigation_happened_in, blank_new_tab); // Ensure that capturing happened. histograms.ExpectUniqueSample( "WebApp.LaunchSource", apps::LaunchSource::kFromNavigationCapturing, 1); histograms.ExpectTotalCount(kLaunchParamsEnqueueMetricWithNavigation, 1); EXPECT_THAT( GetNavigationCapturingFinalDisplayMetric(histograms), testing::ElementsAre( NavigationCapturingDisplayModeResult::kAppBrowserTabFinalStandalone)); EXPECT_EQ(contents_navigation_happened_in, app_browser_to_use->tab_strip_model()->GetActiveWebContents()); EXPECT_EQ(0, app_browser_to_use->tab_strip_model()->GetIndexOfWebContents( contents_navigation_happened_in)); EXPECT_EQ(TabStripModel::kNoTab, browser()->tab_strip_model()->GetIndexOfWebContents( contents_navigation_happened_in)); } IN_PROC_BROWSER_TEST_F( NavigationCapturingBrowserNavigatorBrowserTest, NavigateBrowserUsedForFocusExistingToAppBrowserTabStandalone) { // Test that the app browser provided in NavigateParams is used even if a // separate browser is populated with a matching tab. const webapps::AppId& app_id = InstallWebAppInNewTabAndClose(browser(), GetFocusExistingUrl()); // Launch app in an app browser that will be passed in as the browser for // NavigateParams. BrowserWindowInterface* app_browser_to_use = LaunchWebAppBrowser(app_id); // Change the web app's user display mode to kBrowser base::test::TestFuture future; provider().scheduler().SetUserDisplayMode( app_id, mojom::UserDisplayMode::kBrowser, future.GetCallback()); ASSERT_TRUE(future.Wait()); // Navigate to GetFocusExistingUrl() in browser() so that a browser tab for // the app_id exists. ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), GetFocusExistingUrl())); content::WaitForLoadStop( browser()->tab_strip_model()->GetActiveWebContents()); // Do a capturable navigation to the landing page, and ensure that it opens in // browser(). Since the web_app has a client_mode of `focus-existing`, // browser() should be activated with no navigations happening. base::HistogramTester histograms; { NavigateParams params(app_browser_to_use, GetFocusExistingSecondUrl(), ui::PAGE_TRANSITION_LINK); params.source_contents = browser()->tab_strip_model()->GetActiveWebContents(); params.disposition = WindowOpenDisposition::NEW_FOREGROUND_TAB; Navigate(¶ms); } test::CompletePageLoadForAllWebContents(); apps::test::FlushLaunchQueuesForAllBrowserTabs(); AwaitMetricsAvailableFromRenderer(); // Ensure that capturing happened. histograms.ExpectUniqueSample( "WebApp.LaunchSource", apps::LaunchSource::kFromNavigationCapturing, 1); histograms.ExpectTotalCount(kLaunchParamsEnqueueMetricWithNavigation, 1); EXPECT_THAT( GetNavigationCapturingFinalDisplayMetric(histograms), testing::ElementsAre( NavigationCapturingDisplayModeResult::kAppBrowserTabFinalBrowserTab)); EXPECT_EQ(GetFocusExistingUrl(), app_browser_to_use->tab_strip_model() ->GetActiveWebContents() ->GetLastCommittedURL()); } // Regression test for crbug.com/529425540. A same-document navigation in a // subframe that matches the navigation capturing target URL must not receive // the forwarded launch data, since that data CHECKs IsInPrimaryMainFrame(). A // subsequent primary main frame navigation to the same URL should still receive // the launch data. IN_PROC_BROWSER_TEST_F(NavigationCapturingBrowserNavigatorBrowserTest, SameDocumentSubframeNavigationDoesNotAttachLaunchData) { const GURL app_url = GetAppNoManifestUrl(); const webapps::AppId app_id = InstallTestWebApp(app_url, mojom::UserDisplayMode::kStandalone); content::WebContents* contents = browser()->tab_strip_model()->GetActiveWebContents(); ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), GetLandingPage())); ASSERT_TRUE(content::ExecJs( contents, content::JsReplace("new Promise(resolve => {" " const f = document.createElement('iframe');" " f.id = 'child';" " f.src = $1;" " f.onload = () => resolve(true);" " document.body.appendChild(f);" "});", app_url))); content::RenderFrameHost* subframe = content::ChildFrameAt(contents->GetPrimaryMainFrame(), 0); ASSERT_TRUE(subframe); ASSERT_EQ(subframe->GetLastCommittedURL(), app_url); // Drive the navigation capturing pipeline directly, using the same entry // points as `browser_navigator.cc`, and stop right after the forwarder is // installed on `contents`. This is deliberate: it lets the subframe // navigation below start first, deterministically. Going through a real // navigation (e.g. window.open) would also start a primary main frame // navigation to `app_url`, which would race the subframe navigation and make // this repro flaky - it could pass even without the fix. NavigateParams params(browser(), app_url, ui::PAGE_TRANSITION_LINK); params.initiating_profile = profile(); params.disposition = WindowOpenDisposition::NEW_FOREGROUND_TAB; params.source_contents = contents; std::unique_ptr process = NavigationCapturingProcess::MaybeHandleAppNavigation(params); ASSERT_TRUE(process); std::optional override_result = process->GetInitialNavigationParamsOverride(params); ASSERT_TRUE(override_result.has_value()); NavigationCapturingProcess::AfterWebContentsCreation( std::move(process), *contents, /*navigation_handle=*/nullptr); // The same-document subframe navigation matches `target_url_` but must be // ignored: attaching the launch data to it would trip the CHECK. Without the // fix, this crashes the browser process. ASSERT_TRUE( content::ExecJs(subframe, "history.pushState({}, '', location.href);")); EXPECT_TRUE(contents->GetPrimaryMainFrame()->IsRenderFrameLive()); EXPECT_EQ(contents->GetLastCommittedURL(), GetLandingPage()); // The forwarder is still installed, so a subsequent primary main frame // navigation to the target URL should receive the forwarded launch data. content::TestNavigationManager main_frame_nav(contents, app_url); ASSERT_TRUE( content::ExecJs(contents->GetPrimaryMainFrame(), content::JsReplace("location.href = $1;", app_url), content::EXECUTE_SCRIPT_NO_USER_GESTURE)); ASSERT_TRUE(main_frame_nav.WaitForRequestStart()); content::NavigationHandle* main_frame_handle = main_frame_nav.GetNavigationHandle(); ASSERT_TRUE(main_frame_handle); ASSERT_TRUE(main_frame_handle->IsInPrimaryMainFrame()); EXPECT_TRUE(WebAppLaunchNavigationHandleUserData::GetForNavigationHandle( *main_frame_handle)); ASSERT_TRUE(main_frame_nav.WaitForNavigationFinished()); } using LaunchQueueLatencyMetricBrowserTest = NavigationCapturingBrowserNavigatorBrowserTest; IN_PROC_BROWSER_TEST_F(LaunchQueueLatencyMetricBrowserTest, ReloadsDoNotMeasure) { base::HistogramTester histograms; // Test that the browser provided in NavigateParams is used when using a // browser to open a browser tab app in a tab, instead of the most recently // active browser. const webapps::AppId app_id = InstallWebAppInNewTabAndClose(browser(), GetLandingPage()); base::test::TestFuture future; provider().scheduler().SetUserDisplayMode( app_id, mojom::UserDisplayMode::kBrowser, future.GetCallback()); ASSERT_TRUE(future.Wait()); // Create a new browser which will be considered the most recently active one. BrowserWindowInterface* new_browser = ui_test_utils::OpenNewEmptyWindowAndWaitUntilActivated(profile()); chrome::NewTab(new_browser, NewTabTypes::kNoUserAction); // Do a capturable navigation to the landing page, and ensure that it opens in // the browser(). ui_test_utils::AllBrowserTabAddedWaiter new_tab_observer; { NavigateParams params(browser(), GetLandingPage(), ui::PAGE_TRANSITION_LINK); params.source_contents = new_browser->tab_strip_model()->GetActiveWebContents(); params.disposition = WindowOpenDisposition::NEW_FOREGROUND_TAB; Navigate(¶ms); } // Measure the first set of launch params that are enqueued. content::WebContents* new_tab = new_tab_observer.Wait(); content::WaitForLoadStop(new_tab); apps::test::FlushLaunchQueuesForAllBrowserTabs(); AwaitMetricsAvailableFromRenderer(); histograms.ExpectTotalCount(kLaunchParamsEnqueueMetricWithNavigation, 1); EXPECT_THAT(apps::test::GetLaunchParamUrlsInContents( new_tab, "launchParamsTargetUrls"), testing::ElementsAre(GetLandingPage())); // Reloading the tab should not measure the latency of launch params being // enqueued again, and the launch params are not sent again. chrome::Reload(browser(), WindowOpenDisposition::CURRENT_TAB); content::WaitForLoadStop(new_tab); apps::test::FlushLaunchQueuesForAllBrowserTabs(); AwaitMetricsAvailableFromRenderer(); histograms.ExpectTotalCount(kLaunchParamsEnqueueMetricWithNavigation, 1); EXPECT_THAT(apps::test::GetLaunchParamUrlsInContents( new_tab, "launchParamsTargetUrls"), testing::IsEmpty()); } using LaunchContainerMetricMeasurementTest = NavigationCapturingBrowserNavigatorBrowserTest; IN_PROC_BROWSER_TEST_F(LaunchContainerMetricMeasurementTest, NavigateExistingStandaloneToTab) { // Load 'kNavigateExistingUrl` and `kFocusExistingUrl` in new tabs. chrome::NewTab(browser(), NewTabTypes::kNoUserAction); ASSERT_TRUE( ui_test_utils::NavigateToURL(browser(), GetNavigateExistingUrl())); content::WebContents* target_contents = browser()->tab_strip_model()->GetActiveWebContents(); chrome::NewTab(browser(), NewTabTypes::kNoUserAction); ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), GetFocusExistingUrl())); // Install both apps. const webapps::AppId& source_app = InstallWebAppInNewTabAndClose(browser(), GetFocusExistingUrl()); const webapps::AppId& dest_app = InstallWebAppInNewTabAndClose(browser(), GetNavigateExistingUrl()); // Trigger a navigation to `kNavigateExistingUrl`. This should end up in the // browser tab. base::HistogramTester histograms; { NavigateParams params(profile(), GetNavigateExistingUrl(), ui::PAGE_TRANSITION_LINK); params.source_contents = browser()->tab_strip_model()->GetActiveWebContents(); params.disposition = WindowOpenDisposition::NEW_FOREGROUND_TAB; Navigate(¶ms); content::NavigationController::LoadURLParams load_url_params = LoadURLParamsFromNavigateParams(¶ms); (void)params.navigated_or_inserted_contents->GetController() .LoadURLWithParams(load_url_params); } content::WaitForLoadStop(target_contents); apps::test::FlushLaunchQueuesForAllBrowserTabs(); AwaitMetricsAvailableFromRenderer(); // Verify that navigation did indeed end up in the browser tab via navigation // capturing. histograms.ExpectUniqueSample( "WebApp.LaunchSource", apps::LaunchSource::kFromNavigationCapturing, 1); EXPECT_THAT( GetNavigationCapturingFinalDisplayMetric(histograms), testing::ElementsAre( NavigationCapturingDisplayModeResult::kAppStandaloneFinalBrowserTab)); } class NavigationCapturingWithRedirectionBrowserNavigatorTest : public NavigationCapturingBrowserNavigatorBrowserTest { public: void SetUpOnMainThread() override { // Set up redirection before calling the `SetUpOnMainThread` on the parent // class, as that will start the server. embedded_test_server()->RegisterRequestHandler(base::BindRepeating( &NavigationCapturingWithRedirectionBrowserNavigatorTest:: HandleRedirection, base::Unretained(this))); NavigationCapturingBrowserNavigatorBrowserTest::SetUpOnMainThread(); } GURL GetRedirectFromPage() const { return embedded_test_server()->GetURL(kRedirectFromPage); } std::unique_ptr HandleRedirection( const net::test_server::HttpRequest& request) { if (request.GetURL() != GetRedirectFromPage()) { return nullptr; } GURL redirect_to = GetLandingPage(); auto response = std::make_unique(); response->set_code(net::HTTP_TEMPORARY_REDIRECT); response->set_content_type("text/html"); response->AddCustomHeader("Location", redirect_to.spec()); response->AddCustomHeader("Access-Control-Allow-Origin", "*"); response->set_content(base::StrCat( {"

Redirecting to %s", redirect_to.spec().c_str()})); return response; } }; IN_PROC_BROWSER_TEST_F(NavigationCapturingWithRedirectionBrowserNavigatorTest, NavigateBrowserUsedForBrowserTabAppLaunch) { // Test that the browser provided in NavigateParams is respected after it is // initially captured into an app window, only to be determined to need a // browser tabbed app after redirection. const webapps::AppId& app_id = InstallWebAppInNewTabAndClose(browser(), GetLandingPage()); // Change the web app's user display mode to kBrowser base::test::TestFuture future; provider().scheduler().SetUserDisplayMode( app_id, mojom::UserDisplayMode::kBrowser, future.GetCallback()); ASSERT_TRUE(future.Wait()); InstallTestWebApp(GetRedirectFromPage(), mojom::UserDisplayMode::kStandalone); // Create a new browser which will be considered the most recently active one. BrowserWindowInterface* new_browser = ui_test_utils::OpenNewEmptyWindowAndWaitUntilActivated(profile()); chrome::NewTab(new_browser, NewTabTypes::kNoUserAction); // Do a capturable navigation to kRedirectFromPage (which redirects to // kLandingPage), and ensure that it opens in the browser(). ui_test_utils::AllBrowserTabAddedWaiter new_tab_observer; base::HistogramTester histograms; NavigateParams params(browser(), GetRedirectFromPage(), ui::PAGE_TRANSITION_LINK); params.source_contents = new_browser->tab_strip_model()->GetActiveWebContents(); params.disposition = WindowOpenDisposition::NEW_FOREGROUND_TAB; Navigate(¶ms); content::WebContents* new_tab = new_tab_observer.Wait(); content::WaitForLoadStop(new_tab); apps::test::FlushLaunchQueuesForAllBrowserTabs(); AwaitMetricsAvailableFromRenderer(); // Ensure that capturing happened. histograms.ExpectUniqueSample( "WebApp.LaunchSource", apps::LaunchSource::kFromNavigationCapturing, 1); histograms.ExpectTotalCount(kLaunchParamsEnqueueMetricWithNavigation, 1); // Make sure that web contents is a tab in `browser()` and not `new_browser`. EXPECT_NE(browser()->tab_strip_model()->GetIndexOfWebContents(new_tab), TabStripModel::kNoTab); EXPECT_THAT( GetNavigationCapturingFinalDisplayMetric(histograms), testing::ElementsAre( NavigationCapturingDisplayModeResult::kAppBrowserTabFinalBrowserTab)); } IN_PROC_BROWSER_TEST_F(NavigationCapturingWithRedirectionBrowserNavigatorTest, NavigateBrowserUsedForBrowserTabLaunch) { // Test that the browser provided in NavigateParams is respected after it is // initially captured into an app window, only to be determined to need a // browser tab after redirection. InstallTestWebApp(GetRedirectFromPage(), mojom::UserDisplayMode::kStandalone); // Create a new browser which will be considered the most recently active one. BrowserWindowInterface* new_browser = ui_test_utils::OpenNewEmptyWindowAndWaitUntilActivated(profile()); chrome::NewTab(new_browser, NewTabTypes::kNoUserAction); // Do a capturable navigation to kRedirectFromPage (which redirects to // kLandingPage), and ensure that it opens in the browser(). ui_test_utils::AllBrowserTabAddedWaiter new_tab_observer; base::HistogramTester histograms; NavigateParams params(browser(), GetRedirectFromPage(), ui::PAGE_TRANSITION_LINK); params.source_contents = new_browser->tab_strip_model()->GetActiveWebContents(); params.disposition = WindowOpenDisposition::NEW_FOREGROUND_TAB; Navigate(¶ms); content::WebContents* new_tab = new_tab_observer.Wait(); content::WaitForLoadStop(new_tab); apps::test::FlushLaunchQueuesForAllBrowserTabs(); AwaitMetricsAvailableFromRenderer(); histograms.ExpectUniqueSample( "WebApp.LaunchSource", apps::LaunchSource::kFromNavigationCapturing, 0); histograms.ExpectTotalCount(kLaunchParamsEnqueueMetricWithNavigation, 0); EXPECT_THAT(GetNavigationCapturingFinalDisplayMetric(histograms), testing::IsEmpty()); // Make sure that web contents is a tab in `browser()` and not `new_browser`. EXPECT_NE(browser()->tab_strip_model()->GetIndexOfWebContents(new_tab), TabStripModel::kNoTab); } } // namespace } // namespace web_app